Merge pull request #22 from parca-dev/close

brancz · web-flow · commit 2aed7009bf6d · 2024-05-21T15:05:48.000+02:00
Correctly close tar and zstd writers
diff --git a/cmd/parca-debuginfo/main.go b/cmd/parca-debuginfo/main.go
@@ -376,8 +376,10 @@ func run(kongCtx *kong.Context, flags flags) error {
 			if err != nil {
 				return fmt.Errorf("create zstd writer: %w", err)
 			}
+			defer zw.Close()
 
 			tw := tar.NewWriter(zw)
+			defer tw.Close()
 
 			d, err := f.DWARF()
 			if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -376,8 +376,10 @@ func run(kongCtx *kong.Context, flags flags) error {`
`376`	`376`	`if err != nil {`
`377`	`377`	`return fmt.Errorf("create zstd writer: %w", err)`
`378`	`378`	`}`
	`379`	`+ defer zw.Close()`
`379`	`380`
`380`	`381`	`tw := tar.NewWriter(zw)`
	`382`	`+ defer tw.Close()`
`381`	`383`
`382`	`384`	`d, err := f.DWARF()`
`383`	`385`	`if err != nil {`