Add sumBy parameter to commitDraft in query state hooks

This allows updating the sumBy value when committing a draft.

Author: yomete

ui/packages/shared/profile/src/ProfileFlameGraph/index.tsx

@@ -376,7 +376,9 @@ const ProfileFlameGraph = function ProfileFlameGraphNonMemo({
         errorMessage={
           <>
             <span>
-              {error.message ? capitalizeOnlyFirstLetter(error.message) : 'An error occurred'}
+              {error.message != null
+                ? capitalizeOnlyFirstLetter(error.message)
+                : 'An error occurred'}
             </span>
             {isFlameChart ? flamechartHelpText ?? null : null}
           </>

ui/packages/shared/profile/src/ProfileSelector/useAutoFlameChartQuerySelector.ts

@@ -29,7 +29,11 @@ interface UseAutoFlameChartQuerySelectorProps {
   setTimeRangeSelection: Dispatch<SetStateAction<DateTimeRange>>;
   setDraftTimeRange: (from: number, to: number, timeSelection: string) => void;
   setDraftSumBy: (sumBy: string[] | undefined) => void;
-  commitDraft: (refreshedTimeRange?: {from: number; to: number; timeSelection: string}) => void;
+  commitDraft: (
+    refreshedTimeRange?: {from: number; to: number; timeSelection: string},
+    expression?: string,
+    sumBy?: string[] | undefined
+  ) => void;
 }
 
 export const useAutoFlameChartQuerySelector = ({
@@ -102,11 +106,15 @@ export const useAutoFlameChartQuerySelector = ({
     setDraftTimeRange(fromMs, toMs, timeSelection);
     setDraftSumBy(optimalSumBy);
 
-    commitDraft({
-      from: fromMs,
-      to: toMs,
-      timeSelection,
-    });
+    commitDraft(
+      {
+        from: fromMs,
+        to: toMs,
+        timeSelection,
+      },
+      undefined,
+      optimalSumBy
+    );
 
     previousDashboardItems.current = dashboardItems;
   }, [

ui/packages/shared/profile/src/hooks/useQueryState.ts

@@ -270,10 +270,12 @@ export const useQueryState = (options: UseQueryStateOptions = {}): UseQueryState
   // Optional refreshedTimeRange parameter allows re-evaluating relative time ranges (e.g., "last 15 minutes")
   // to the current moment when the Search button is clicked
   // Optional expression parameter allows updating the expression before committing
+  // Optional sumBy parameter allows updating the sumBy before committing
   const commitDraft = useCallback(
     (
       refreshedTimeRange?: {from: number; to: number; timeSelection: string},
-      expression?: string
+      expression?: string,
+      sumBy?: string[] | undefined
     ) => {
       batchUpdates(() => {
         // Use provided expression or current draft expression
@@ -314,8 +316,12 @@ export const useQueryState = (options: UseQueryStateOptions = {}): UseQueryState
         // Parse the final expression to check if it's a delta profile
         const finalQuery = Query.parse(finalExpression);
         const isDelta = finalQuery.profileType().delta;
+
+        // Use provided sumBy or fall back to draftSumBy
+        const finalSumBy = sumBy !== undefined ? sumBy : draftSumBy;
+
         if (isDelta) {
-          setSumByParam(sumByToParam(draftSumBy));
+          setSumByParam(sumByToParam(finalSumBy));
         } else {
           setSumByParam(DEFAULT_EMPTY_SUM_BY);
         }

ui/packages/shared/profile/src/useSumBy.ts

@@ -267,7 +267,7 @@ export const useDraftSumBy = (
 
   return {
     draftSumBy: draftSumBy ?? defaultSumBy ?? DEFAULT_EMPTY_SUM_BY,
-    setDraftSumBy: setDraftSumBy,
+    setDraftSumBy,
     isDraftSumByLoading: isLoading,
   };
 };