HasProfileData endpoint usage fixes and time range for ProfileTypes query

Author: manojVivek

pkg/parcacol/querier.go

@@ -882,7 +882,7 @@ func (q *Querier) ProfileTypes(
 }
 
 func (q *Querier) HasProfileData(ctx context.Context) (bool, error) {
-	types, err := q.ProfileTypes(ctx, time.Time{}, time.Time{})
+	types, err := q.ProfileTypes(ctx, time.UnixMilli(0), time.UnixMilli(0))
 	if err != nil {
 		return false, err
 	}

ui/packages/shared/profile/src/ProfileSelector/index.tsx

@@ -15,7 +15,7 @@ import {Dispatch, SetStateAction, useEffect, useMemo, useRef, useState} from 're
 
 import {RpcError} from '@protobuf-ts/runtime-rpc';
 
-import {ProfileTypesResponse, QueryServiceClient} from '@parca/client';
+import { ProfileTypesRequest, ProfileTypesResponse, QueryServiceClient } from '@parca/client';
 import {
   DateTimeRange,
   IconButton,
@@ -26,7 +26,7 @@ import {
 import {CloseIcon} from '@parca/icons';
 import {Query} from '@parca/parser';
 import {TEST_IDS, testId} from '@parca/test-utils';
-import {type NavigateFunction} from '@parca/utilities';
+import { millisToProtoTimestamp, type NavigateFunction } from '@parca/utilities';
 
 import {ProfileSelection} from '..';
 import {useLabelNames} from '../MatchersInput/index';
@@ -36,6 +36,7 @@ import {useDefaultSumBy, useSumBySelection} from '../useSumBy';
 import {MetricsGraphSection} from './MetricsGraphSection';
 import {QueryControls} from './QueryControls';
 import {useAutoQuerySelector} from './useAutoQuerySelector';
+import useGrpcQuery from '../useGrpcQuery';
 
 export interface QuerySelection {
   expression: string;
@@ -104,24 +105,30 @@ export interface IProfileTypesResult {
   error?: RpcError;
 }
 
-export const useProfileTypes = (client: QueryServiceClient): IProfileTypesResult => {
-  const [result, setResult] = useState<ProfileTypesResponse | undefined>(undefined);
-  const [error, setError] = useState<RpcError | undefined>(undefined);
-  const [loading, setLoading] = useState(true);
+export const useProfileTypes = (client:
+  QueryServiceClient, start?: number, end?: number):
+  IProfileTypesResult => {
   const metadata = useGrpcMetadata();
+  const metadataString = useMemo(() => JSON.stringify(metadata), [metadata]);
+  const request: ProfileTypesRequest = {};
+
+  if (start != null && end != null) {
+    request.start = millisToProtoTimestamp(start);
+    request.end = millisToProtoTimestamp(end);
+  }
+
+  const { isLoading, data, error } = useGrpcQuery({
+    key: ['profileTypes', metadataString, start, end],
+    queryFn: async (abort) => {
+      const { response } = await client.profileTypes(request, {
+        meta: metadata,
+        abort,
+      });
+      return response;
+    },
+  });
 
-  useEffect(() => {
-    if (!loading) {
-      return;
-    }
-    const call = client.profileTypes({}, {meta: metadata});
-    call.response
-      .then(response => setResult(response))
-      .catch(error => setError(error))
-      .finally(() => setLoading(false));
-  }, [client, metadata, loading]);
-
-  return {loading, data: result, error};
+  return { loading: isLoading, data, error: error as RpcError };
 };
 
 const ProfileSelector = ({
@@ -144,11 +151,6 @@ const ProfileSelector = ({
   utilizationLabels,
   onUtilizationSeriesSelect,
 }: ProfileSelectorProps): JSX.Element => {
-  const {
-    loading: profileTypesLoading,
-    data: profileTypesData,
-    error,
-  } = useProfileTypes(queryClient);
   const {heightStyle} = useMetricsGraphDimensions(comparing, utilizationMetrics != null);
   const {viewComponent} = useParcaContext();
   const [queryBrowserMode, setQueryBrowserMode] = useURLState('query_browser_mode');
@@ -174,6 +176,12 @@ const ProfileSelector = ({
   const from = timeRangeSelection.getFromMs();
   const to = timeRangeSelection.getToMs();
 
+  const {
+    loading: profileTypesLoading,
+    data: profileTypesData,
+    error,
+  } = useProfileTypes(queryClient, from, to);
+
   const {loading: labelNamesLoading, result} = useLabelNames(
     queryClient,
     profileType.toString(),

ui/packages/shared/profile/src/useHasProfileData.ts

@@ -14,14 +14,19 @@
 import {HasProfileDataResponse, QueryServiceClient} from '@parca/client';
 
 import useGrpcQuery from './useGrpcQuery';
+import { useGrpcMetadata } from '@parca/components';
+import { useMemo } from 'react';
 
 export const useHasProfileData = (
   client: QueryServiceClient
 ): {loading: boolean; data: boolean; error: Error | any} => {
+  const metadata = useGrpcMetadata();
+  const metadataString = useMemo(() => JSON.stringify(metadata), [metadata]);
+
   const {data, isLoading, error} = useGrpcQuery<HasProfileDataResponse>({
-    key: ['hasProfileData'],
+    key: ['hasProfileData', metadataString],
     queryFn: async signal => {
-      const {response} = await client.hasProfileData({}, {abort: signal});
+      const {response} = await client.hasProfileData({}, {abort: signal, meta: metadata});
       return response;
     },
   });