`gas` call option not respected

[TorstenStueber]

Given the following contract

contract Test {
    bool public executed;

    function main() public returns (bool) {
        this.f1{gas: 1}();
        return executed;
    }

    function f1() public {
        executed = true;
    }
}

However, in revive the call is successful and the function returns 1. This holds both for kitchensink and the revive dev node – and it holds both for dry running and for executing the function on chain.

Expected Behavior

The expected result of calling main in Test is that the function reverts as f1 should run out of gas.

[athei]

@xermicus Does revive ignore the gas limit? I thought it does interpret it as ref_time?

The expected result of calling main in Test is that the function reverts as f1 should run out of gas.

Error handling in Solidity is explicit. This would silently succeed. But the executed flag would be false.

[pgherveou]

This is expected for now and should be fixed with @athei next PR

[athei]

Yes

[xermicus]

For context: resolc ignores the gas stipend. Which isn't necessary anymore after a recent series of changes in the pallet and will change before deploy on mainnet.

[TorstenStueber]

This is still an issue with the latest version of pallet-revive (commit 736230e943c8fd47e9f993c969a6ec53ffdf0105) and resolc 0.4.1.

It doesn't work correctly for the EVM backend either.

[athei]

Fixed on the EVM backend with paritytech/polkadot-sdk#10018

[TorstenStueber]

Fixed on the EVM backend with paritytech/polkadot-sdk#10018

Yes, this works for EVM now.