Phase 2: Modify foundry linking logic to support PVM

[smiasojed]

Support deploy-time linking, ensuring that contracts can reference library correctly

[pkhry]

Support deploy-time linking, ensuring that contracts can reference library correctly

Can you please elaborate more as resolc produced bytecode should be linked correctly from the get-go judging from the code inside revive repo.

Re: deploy time linking
Are you referencing this?
if yes, should we revive this?

[smiasojed]

Are you referencing paritytech/revive#91?

yes

if yes, should we revive paritytech/revive#146?

I am not sure if it is needed here

[pkhry]

Are you referencing paritytech/revive#91?

yes

if yes, should we revive paritytech/revive#146?

I am not sure if it is needed here

Can you please elaborate more as resolc produced bytecode should be linked correctly from the get-go judging from the code inside revive repo.

[smiasojed]

Yes, the bytecode must be correctly linked. This requires additional handling: libraries with public methods must be deployed first, and their deployed addresses or hashes probably must be passed during the linking process when compiling the main contract. It depends on this how the on chain execution is going to be handled. I think that some more context may provide @xermicus

[pkhry]

Progress report

Currently waiting on the Resolc deploy time linking implementation.

Currently there's no concrete implementation path for this feature in foundry.

For reference: foundry-zksync implementation based on zksolc --link command