Skip to content

Commit 844f7af

Browse files
authored
Revert "Stabilize transactionWatch to version 1" (#149)
1 parent 814228a commit 844f7af

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

src/SUMMARY.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,5 +44,5 @@
4444
- [transaction_v1_broadcast](api/transaction_v1_broadcast.md)
4545
- [transaction_v1_stop](api/transaction_v1_stop.md)
4646
- [transactionWatch](api/transactionWatch.md)
47-
- [transactionWatch_v1_submitAndWatch](api/transactionWatch_v1_submitAndWatch.md)
48-
- [transactionWatch_v1_unwatch](api/transactionWatch_v1_unwatch.md)
47+
- [transactionWatch_unstable_submitAndWatch](api/transactionWatch_unstable_submitAndWatch.md)
48+
- [transactionWatch_unstable_unwatch](api/transactionWatch_unstable_unwatch.md)

src/api/transactionWatch_v1_submitAndWatch.md renamed to src/api/transactionWatch_unstable_submitAndWatch.md

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
1-
# transactionWatch_v1_submitAndWatch
1+
# transactionWatch_unstable_submitAndWatch
22

33
**Parameters**:
44

55
- `transaction`: String containing the hexadecimal-encoded SCALE-encoded transaction to try to include in a block.
66

77
**Return value**: String representing the subscription.
88

9-
The string returned by this function is opaque and its meaning can't be interpreted by the JSON-RPC client. It is only meant to be matched with the `subscription` field of events and potentially passed to `transactionWatch_v1_unwatch`.
9+
The string returned by this function is opaque and its meaning can't be interpreted by the JSON-RPC client. It is only meant to be matched with the `subscription` field of events and potentially passed to `transactionWatch_unstable_unwatch`.
1010

11-
Once this function has been called, the server will try to propagate this transaction over the peer-to-peer network and/or include it onto the chain even if `transactionWatch_v1_unwatch` is called or that the JSON-RPC client disconnects. In other words, it is not possible to cancel submitting a transaction.
11+
Once this function has been called, the server will try to propagate this transaction over the peer-to-peer network and/or include it onto the chain even if `transactionWatch_unstable_unwatch` is called or that the JSON-RPC client disconnects. In other words, it is not possible to cancel submitting a transaction.
1212

13-
The JSON-RPC server must accept at least 4 `transactionWatch_v1_submitAndWatch` subscriptions per JSON-RPC client.
14-
Trying to open more might lead to a JSON-RPC error when calling `transactionWatch_v1_submitAndWatch`.
13+
The JSON-RPC server must accept at least 4 `transactionWatch_unstable_submitAndWatch` subscriptions per JSON-RPC client.
14+
Trying to open more might lead to a JSON-RPC error when calling `transactionWatch_unstable_submitAndWatch`.
1515

1616
## Notifications format
1717

@@ -20,7 +20,7 @@ This function will later generate one or more notifications in the following for
2020
```json
2121
{
2222
"jsonrpc": "2.0",
23-
"method": "transactionWatch_v1_watchEvent",
23+
"method": "transactionWatch_unstable_watchEvent",
2424
"params": {
2525
"subscription": "...",
2626
"result": ...
@@ -168,5 +168,5 @@ JSON-RPC servers are allowed to skip sending events as long as it properly keeps
168168

169169
## Possible errors
170170

171-
- A JSON-RPC error with error code `-32800` can be generated if the JSON-RPC client has already opened 4 or more `transactionWatch_v1_submitAndWatch` subscriptions.
171+
- A JSON-RPC error with error code `-32800` can be generated if the JSON-RPC client has already opened 4 or more `transactionWatch_unstable_submitAndWatch` subscriptions.
172172
- A JSON-RPC error with error code `-32602` is generated if the `transaction` parameter is not a valid hex string. Note that no error is produced if the bytes of the `transaction`, once decoded, are invalid. Instead, an `invalid` notification will be generated.

src/api/transactionWatch_v1_unwatch.md renamed to src/api/transactionWatch_unstable_unwatch.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# transactionWatch_v1_unwatch
1+
# transactionWatch_unstable_unwatch
22

33
**Parameters**:
44

5-
- `subscription`: Opaque string equal to the value returned by `transactionWatch_v1_submitAndWatch`
5+
- `subscription`: Opaque string equal to the value returned by `transactionWatch_unstable_submitAndWatch`
66

77
**Return value**: *null*
88

src/dos-attacks-resilience.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ The events coming from the blockchain node can be seen as a stream. This stream
3434

3535
However, sending a message to a JSON-RPC client might take a long time, in case the client has (intentionally or not) little bandwidth. The threads that are receiving the stream of events should never wait for a client to be ready to accept more data before sending a notification to it. If the client isn't ready, then the notification must either be added to a send queue or simply discarded. Because queues must be bounded, it is unavoidable to sometimes have to discard some notifications.
3636

37-
Consequently, all functions that consist in sending notifications must be designed having in mind that the queue of notifications to send out must be bounded to a certain value. For example, the queue of notifications for `transactionWatch_v1_submitAndWatch` must have a size of 3. When the queue is full, new notifications must overwrite the notifications already in the queue. The design of all JSON-RPC functions should take into account the fact that this shouldn't result in a loss of important information for the JSON-RPC client.
37+
Consequently, all functions that consist in sending notifications must be designed having in mind that the queue of notifications to send out must be bounded to a certain value. For example, the queue of notifications for `transactionWatch_unstable_submitAndWatch` must have a size of 3. When the queue is full, new notifications must overwrite the notifications already in the queue. The design of all JSON-RPC functions should take into account the fact that this shouldn't result in a loss of important information for the JSON-RPC client.
3838

3939
## Distinguishing between light and heavy calls
4040

0 commit comments

Comments
 (0)