Skip to content

Commit 24685ca

Browse files
authored
Use ?/std for optional dependencies within bounded-collections/std (#948)
* Use `?/std` for optional dependencies within `bounded-collections/std` * Add necessary `cfg(feature = "serde")` to relevant tests
1 parent 069c108 commit 24685ca

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

bounded-collections/Cargo.toml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,9 @@ default = ["std"]
2626
json-schema = ["dep:schemars"]
2727
std = [
2828
"log/std",
29-
"jam-codec/std",
30-
"scale-codec/std",
31-
"scale-info/std",
32-
"serde/std",
29+
"jam-codec?/std",
30+
"scale-codec?/std",
31+
"scale-info?/std",
32+
"serde?/std",
3333
]
3434
scale-codec = [ "dep:scale-codec", "scale-info" ]

bounded-collections/src/bounded_vec.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1248,12 +1248,14 @@ mod test {
12481248
assert_eq!(*b, vec![1, 2, 3]);
12491249
}
12501250

1251+
#[cfg(feature = "serde")]
12511252
#[test]
12521253
fn test_serializer() {
12531254
let c: BoundedVec<u32, ConstU32<6>> = bounded_vec![0, 1, 2];
12541255
assert_eq!(serde_json::json!(&c).to_string(), r#"[0,1,2]"#);
12551256
}
12561257

1258+
#[cfg(feature = "serde")]
12571259
#[test]
12581260
fn test_deserializer() {
12591261
let c: BoundedVec<u32, ConstU32<6>> = serde_json::from_str(r#"[0,1,2]"#).unwrap();
@@ -1264,6 +1266,7 @@ mod test {
12641266
assert_eq!(c[2], 2);
12651267
}
12661268

1269+
#[cfg(feature = "serde")]
12671270
#[test]
12681271
fn test_deserializer_bound() {
12691272
let c: BoundedVec<u32, ConstU32<3>> = serde_json::from_str(r#"[0,1,2]"#).unwrap();
@@ -1274,6 +1277,7 @@ mod test {
12741277
assert_eq!(c[2], 2);
12751278
}
12761279

1280+
#[cfg(feature = "serde")]
12771281
#[test]
12781282
fn test_deserializer_failed() {
12791283
let c: Result<BoundedVec<u32, ConstU32<4>>, serde_json::error::Error> = serde_json::from_str(r#"[0,1,2,3,4]"#);

0 commit comments

Comments
 (0)