[stable2506] Backport #9445 (#9449)

Backport #9445 into `stable2506` from acatangiu.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Adrian Catangiu <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Karol Kokoszka <[email protected]>
Co-authored-by: Egor_P <[email protected]>

Author: 4 people

polkadot/xcm/pallet-xcm/src/benchmarking.rs

@@ -603,11 +603,18 @@ mod benchmarks {
 		let origin = RawOrigin::Signed(who.clone());
 		let origin_location: VersionedLocation =
 			T::ExecuteXcmOrigin::try_origin(origin.clone().into())
-				.map_err(|_| BenchmarkError::Override(BenchmarkResult::from_weight(Weight::MAX)))?
+				.map_err(|_| {
+					tracing::error!(
+						target: "xcm::benchmarking::pallet_xcm::add_authorized_alias",
+						?origin,
+						"try_origin failed",
+					);
+					BenchmarkError::Override(BenchmarkResult::from_weight(Weight::MAX))
+				})?
 				.into();
 
 		// Give some multiple of ED
-		let balance = T::ExistentialDeposit::get() * 1000u32.into();
+		let balance = T::ExistentialDeposit::get() * 1000000u32.into();
 		let _ =
 			<pallet_balances::Pallet::<T> as frame_support::traits::Currency<_>>::make_free_balance_be(&who, balance);
 
@@ -620,8 +627,17 @@ mod benchmarks {
 			let aliaser = OriginAliaser { location: alias, expiry: None };
 			existing_aliases.try_push(aliaser).unwrap()
 		}
-		let ticket = TicketOf::<T>::new(&who, aliasers_footprint(existing_aliases.len()))
-			.map_err(|_| BenchmarkError::Override(BenchmarkResult::from_weight(Weight::MAX)))?;
+		let footprint = aliasers_footprint(existing_aliases.len());
+		let ticket = TicketOf::<T>::new(&who, footprint).map_err(|e| {
+			tracing::error!(
+				target: "xcm::benchmarking::pallet_xcm::add_authorized_alias",
+				?who,
+				?footprint,
+				error=?e,
+				"could not create ticket",
+			);
+			BenchmarkError::Override(BenchmarkResult::from_weight(Weight::MAX))
+		})?;
 		let entry = AuthorizedAliasesEntry { aliasers: existing_aliases, ticket };
 		AuthorizedAliases::<T>::insert(&origin_location, entry);
 
@@ -642,17 +658,31 @@ mod benchmarks {
 		let origin = RawOrigin::Signed(who.clone());
 		let error = BenchmarkError::Override(BenchmarkResult::from_weight(Weight::MAX));
 		let origin_location =
-			T::ExecuteXcmOrigin::try_origin(origin.clone().into()).map_err(|_| error.clone())?;
+			T::ExecuteXcmOrigin::try_origin(origin.clone().into()).map_err(|_| {
+				tracing::error!(
+					target: "xcm::benchmarking::pallet_xcm::remove_authorized_alias",
+					?origin,
+					"try_origin failed",
+				);
+				error.clone()
+			})?;
 		// remove `network` from inner `AccountId32` for easier matching of automatic AccountId ->
 		// Location conversions.
 		let origin_location: VersionedLocation = match origin_location.unpack() {
 			(0, [AccountId32 { network: _, id }]) =>
 				Location::new(0, [AccountId32 { network: None, id: *id }]).into(),
-			_ => return Err(error.clone()),
+			_ => {
+				tracing::error!(
+					target: "xcm::benchmarking::pallet_xcm::remove_authorized_alias",
+					?origin_location,
+					"unexpected origin failed",
+				);
+				return Err(error.clone())
+			},
 		};
 
 		// Give some multiple of ED
-		let balance = T::ExistentialDeposit::get() * 1000u32.into();
+		let balance = T::ExistentialDeposit::get() * 1000000u32.into();
 		let _ =
 			<pallet_balances::Pallet::<T> as frame_support::traits::Currency<_>>::make_free_balance_be(&who, balance);
 
@@ -665,8 +695,17 @@ mod benchmarks {
 			let aliaser = OriginAliaser { location: alias, expiry: None };
 			existing_aliases.try_push(aliaser).unwrap()
 		}
-		let ticket = TicketOf::<T>::new(&who, aliasers_footprint(existing_aliases.len()))
-			.map_err(|_| error)?;
+		let footprint = aliasers_footprint(existing_aliases.len());
+		let ticket = TicketOf::<T>::new(&who, footprint).map_err(|e| {
+			tracing::error!(
+				target: "xcm::benchmarking::pallet_xcm::remove_authorized_alias",
+				?who,
+				?footprint,
+				error=?e,
+				"could not create ticket",
+			);
+			error
+		})?;
 		let entry = AuthorizedAliasesEntry { aliasers: existing_aliases, ticket };
 		AuthorizedAliases::<T>::insert(&origin_location, entry);
 

prdoc/pr_9445.prdoc

@@ -0,0 +1,10 @@
+title: "pallet-xcm: fix authorized_alias benchmarks"
+
+doc:
+  - audience: Runtime Dev
+    description: |-
+      Depending on runtime configuration of ED and storage deposits, the old benchmark code did not set up enough funds to cover authorized aliases storage deposits. Fix it by adding more funds as part of benchmark setup.
+
+crates:
+- name: pallet-xcm
+  bump: patch