Make NoOpPoll generic over Moment (#8938)

# Description
This PR enhances the flexibility of the `NoOpPoll` implementation by
introducing a generic `Moment` parameter. This change enables support
for diverse clock configurations across different runtimes, allowing
`NoOpPoll` to work seamlessly with various block number implementations
(e.g., `u32`, `u64`, or custom block number types).

### Integration
Downstream projects using `NoOpPoll` must make these adjustments:

- Add generic parameter: Specify the Moment type when using `NoOpPoll`

- Update type annotations: Modify existing references to include the
generic parameter

### Example Migration:

```diff
// Before
use frame_support::traits::NoOpPoll;

let _ = NoOpPoll;

// After
use frame_support::traits::NoOpPoll;
use frame_system::pallet_prelude::BlockNumberFor;
```

### Generic struct update:

```diff
- pub struct NoOpPoll;
+ pub struct NoOpPoll<Moment>(core::marker::PhantomData<Moment>);
```
### Polling trait implementation:
```diff
- impl<Tally> Polling<Tally> for NoOpPoll {
+ impl<Tally, Moment> Polling<Tally> for NoOpPoll<Moment> {
     type Index = u8;
     type Votes = u32;
     type Class = u16;
-    type Moment = u64;
+    type Moment = Moment;
```

---------

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: 4 people

prdoc/pr_8938.prdoc

@@ -0,0 +1,14 @@
+title: Make `NoOpPoll` generic over `Moment`
+doc:
+- audience: Runtime Dev
+  description: |-
+    This PR enhances the flexibility of the `NoOpPoll` implementation by introducing a generic `Moment` parameter. This change enables support for diverse clock configurations across different runtimes, allowing `NoOpPoll` to work seamlessly with various block number implementations (e.g., `u32`, `u64`, or custom block number types).
+crates:
+- name: pallet-ranked-collective
+  bump: patch
+- name: frame-support
+  bump: minor
+- name: pallet-core-fellowship
+  bump: patch
+- name: pallet-salary
+  bump: patch

substrate/frame/core-fellowship/src/tests/integration.rs

@@ -25,7 +25,7 @@ use frame_support::{
 	parameter_types,
 	traits::{ConstU16, EitherOf, IsInVec, MapSuccess, NoOpPoll, TryMapSuccess},
 };
-use frame_system::EnsureSignedBy;
+use frame_system::{pallet_prelude::BlockNumberFor, EnsureSignedBy};
 use pallet_ranked_collective::{EnsureRanked, Geometric, Rank};
 use sp_core::Get;
 use sp_runtime::{
@@ -117,7 +117,7 @@ impl pallet_ranked_collective::Config for Test {
 		// Members can exchange up to the rank of 2 below them.
 		MapSuccess<EnsureRanked<Test, (), 2>, ReduceBy<ConstU16<2>>>,
 	>;
-	type Polls = NoOpPoll;
+	type Polls = NoOpPoll<BlockNumberFor<Test>>;
 	type MinRankOfClass = MinRankOfClass<MinRankOfClassDelta>;
 	type MemberSwappedHandler = CoreFellowship;
 	type VoteWeight = Geometric;

substrate/frame/ranked-collective/src/benchmarking.rs

@@ -27,7 +27,7 @@ use frame_benchmarking::{
 };
 
 use frame_support::{assert_err, assert_ok, traits::NoOpPoll};
-use frame_system::RawOrigin as SystemOrigin;
+use frame_system::{pallet_prelude::BlockNumberFor, RawOrigin as SystemOrigin};
 
 const SEED: u32 = 0;
 
@@ -197,7 +197,7 @@ mod benchmarks {
 			T::Polls::create_ongoing(class.clone())
 				.expect("Poll creation should succeed for rank 0")
 		} else {
-			<NoOpPoll as Polling<T>>::Index::MAX.into()
+			<NoOpPoll<BlockNumberFor<T>> as Polling<T>>::Index::MAX.into()
 		};
 
 		// Benchmark the vote logic for a positive vote (true).
@@ -255,7 +255,7 @@ mod benchmarks {
 			T::Polls::create_ongoing(class.clone())
 				.expect("Poll creation should succeed for rank 0")
 		} else {
-			<NoOpPoll as Polling<T>>::Index::MAX.into()
+			<NoOpPoll<BlockNumberFor<T>> as Polling<T>>::Index::MAX.into()
 		};
 
 		// Simulate voting by `n` members.

substrate/frame/salary/src/tests/integration.rs

@@ -125,7 +125,7 @@ impl pallet_ranked_collective::Config for Test {
 		// Members can exchange up to the rank of 2 below them.
 		MapSuccess<EnsureRanked<Test, (), 2>, ReduceBy<ConstU16<2>>>,
 	>;
-	type Polls = NoOpPoll;
+	type Polls = NoOpPoll<BlockNumberFor<Test>>;
 	type MinRankOfClass = MinRankOfClass<MinRankOfClassDelta>;
 	type MemberSwappedHandler = Salary;
 	type VoteWeight = Geometric;

substrate/frame/support/src/traits/voting.rs

@@ -128,12 +128,12 @@ pub trait Polling<Tally> {
 }
 
 /// NoOp polling is required if pallet-referenda functionality not needed.
-pub struct NoOpPoll;
-impl<Tally> Polling<Tally> for NoOpPoll {
+pub struct NoOpPoll<Moment>(core::marker::PhantomData<Moment>);
+impl<Tally, Moment> Polling<Tally> for NoOpPoll<Moment> {
 	type Index = u8;
 	type Votes = u32;
 	type Class = u16;
-	type Moment = u64;
+	type Moment = Moment;
 
 	fn classes() -> Vec<Self::Class> {
 		vec![]