Cleanup unused crates (#8006)

Follow up to #7999

RustRover warns several dependencies are unused.
I tried to remove them, and it can pass compile and tests on my local
machine (macOS and Ubuntu 24.04), but `udeps` doesn't find these.

I've no confidence. Let's see what CI says.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: jasl

Cargo.lock

@@ -643,7 +643,8 @@ backoff = { version = "0.4" }
 backtrace = { version = "0.3.71" }
 binary-merkle-tree = { path = "substrate/utils/binary-merkle-tree", default-features = false }
 bincode = { version = "1.3.3" }
-bip39 = { version = "2.0.0" }
+# personal fork here as workaround for: https://github.com/rust-bitcoin/rust-bip39/pull/64
+bip39 = { package = "parity-bip39", version = "2.0.1", default-features = false }
 bitflags = { version = "1.3.2" }
 bitvec = { version = "1.0.1", default-features = false }
 blake2 = { version = "0.10.4", default-features = false }
@@ -690,7 +691,6 @@ chain-spec-guide-runtime = { path = "docs/sdk/src/reference_docs/chain_spec_runt
 chrono = { version = "0.4.31" }
 cid = { version = "0.9.0" }
 clap = { version = "4.5.13" }
-clap-num = { version = "1.0.2" }
 clap_complete = { version = "4.5.13" }
 cmd_lib = { version = "1.9.5" }
 coarsetime = { version = "0.1.22" }
@@ -803,11 +803,11 @@ frame-try-runtime = { path = "substrate/frame/try-runtime", default-features = f
 fs4 = { version = "0.7.0" }
 fs_extra = { version = "1.3.0" }
 futures = { version = "0.3.31" }
-futures-channel = { version = "0.3.23" }
 futures-timer = { version = "3.0.2" }
 futures-util = { version = "0.3.30", default-features = false }
 generate-bags = { path = "substrate/utils/frame/generate-bags", default-features = false }
 gethostname = { version = "0.2.3" }
+git2 = { version = "0.20.0", default-features = false }
 glob = { version = "0.3" }
 glutton-westend-runtime = { path = "cumulus/parachains/runtimes/glutton/glutton-westend" }
 governor = { version = "0.6.0" }
@@ -860,6 +860,7 @@ libc = { version = "0.2.155" }
 libfuzzer-sys = { version = "0.4" }
 libp2p = { version = "0.54.1" }
 libp2p-identity = { version = "0.2.9" }
+libp2p-kad = { version = "0.46.2", default-features = false }
 libsecp256k1 = { version = "0.7.0", default-features = false }
 linked-hash-map = { version = "0.5.4" }
 linked_hash_set = { version = "0.1.4" }
@@ -885,7 +886,6 @@ mmr-rpc = { path = "substrate/client/merkle-mountain-range/rpc", default-feature
 mockall = { version = "0.13.1" }
 multiaddr = { version = "0.18.1" }
 multihash = { version = "0.19.1", default-features = false }
-multihash-codetable = { version = "0.1.1" }
 multistream-select = { version = "0.13.0" }
 names = { version = "0.14.0", default-features = false }
 nix = { version = "0.29.0" }
@@ -1115,9 +1115,7 @@ polkavm-derive = "0.18.0"
 polkavm-linker = "0.18.0"
 portpicker = { version = "0.1.1" }
 pretty_assertions = { version = "1.3.0" }
-primitive-types = { version = "0.13.1", default-features = false, features = [
-	"num-traits",
-] }
+primitive-types = { version = "0.13.1", default-features = false, features = ["num-traits"] }
 proc-macro-crate = { version = "3.0.0" }
 proc-macro-warning = { version = "1.0.0", default-features = false }
 proc-macro2 = { version = "1.0.86" }
@@ -1137,14 +1135,12 @@ rand_chacha = { version = "0.3.1", default-features = false }
 rand_core = { version = "0.6.2" }
 rand_distr = { version = "0.4.3" }
 rand_pcg = { version = "0.3.1" }
-rayon = { version = "1.5.1" }
 rbtag = { version = "0.3" }
 ref-cast = { version = "1.0.23" }
 regex = { version = "1.10.2" }
 relay-substrate-client = { path = "bridges/relays/client-substrate" }
 relay-utils = { path = "bridges/relays/utils" }
 remote-externalities = { path = "substrate/utils/frame/remote-externalities", default-features = false, package = "frame-remote-externalities" }
-reqwest = { version = "0.12.9", default-features = false }
 ripemd = { version = "0.1.3", default-features = false }
 rlp = { version = "0.6.1", default-features = false }
 rococo-emulated-chain = { path = "cumulus/parachains/integration-tests/emulated/chains/relays/rococo" }
@@ -1397,6 +1393,7 @@ trybuild = { version = "1.0.103" }
 tt-call = { version = "1.0.8" }
 tuplex = { version = "0.1", default-features = false }
 twox-hash = { version = "1.6.3", default-features = false }
+txtesttool = { version = "0.4.0", package = "substrate-txtesttool" }
 unsigned-varint = { version = "0.7.2" }
 url = { version = "2.5.4" }
 void = { version = "1.0.2" }
@@ -1423,7 +1420,6 @@ xcm-procedural = { path = "polkadot/xcm/procedural", default-features = false }
 xcm-runtime-apis = { path = "polkadot/xcm/xcm-runtime-apis", default-features = false }
 xcm-simulator = { path = "polkadot/xcm/xcm-simulator", default-features = false }
 zeroize = { version = "1.7.0", default-features = false }
-zombienet-configuration = { version = "0.2.29" }
 zombienet-sdk = { version = "0.2.29" }
 zstd = { version = "0.12.4", default-features = false }
 

Cargo.toml

@@ -81,12 +81,12 @@ where
 		// `HaulBlobExporter` may consume the `universal_source` and `destination` arguments, so
 		// let's save them before
 		let bridge_origin_universal_location =
-			universal_source.clone().take().ok_or(SendError::MissingArgument)?;
+			universal_source.clone().ok_or(SendError::MissingArgument)?;
 		// Note: watch out this is `ExportMessage::destination`, which is relative to the `network`,
 		// which means it does not contain `GlobalConsensus`, We need to find `BridgeId` with
 		// `Self::bridge_locations` which requires **universal** location for destination.
 		let bridge_destination_universal_location = {
-			let dest = destination.clone().take().ok_or(SendError::MissingArgument)?;
+			let dest = destination.clone().ok_or(SendError::MissingArgument)?;
 			match dest.global_consensus() {
 				Ok(dest_network) => {
 					log::trace!(

bridges/modules/xcm-bridge-hub/src/exporter.rs

@@ -16,7 +16,6 @@ async-std = { features = ["attributes"], workspace = true }
 async-trait = { workspace = true }
 bp-header-chain = { workspace = true, default-features = true }
 finality-relay = { workspace = true }
-frame-support = { workspace = true, default-features = true }
 futures = { workspace = true }
 log = { workspace = true }
 num-traits = { workspace = true, default-features = true }

bridges/relays/equivocation/Cargo.toml

@@ -55,6 +55,5 @@ sp-runtime = { workspace = true, default-features = true }
 sp-trie = { workspace = true }
 
 [dev-dependencies]
-pallet-transaction-payment = { workspace = true, default-features = true }
 relay-substrate-client = { features = ["test-helpers"], workspace = true }
 scale-info = { features = ["derive"], workspace = true }

bridges/relays/lib-substrate-relay/Cargo.toml

@@ -23,6 +23,5 @@ bp-polkadot-core = { workspace = true, default-features = true }
 relay-substrate-client = { workspace = true }
 
 [dev-dependencies]
-codec = { workspace = true, default-features = true }
 relay-substrate-client = { features = ["test-helpers"], workspace = true }
 sp-core = { workspace = true, default-features = true }

bridges/relays/parachains/Cargo.toml

@@ -37,8 +37,6 @@ xcm = { workspace = true }
 xcm-executor = { workspace = true }
 
 [dev-dependencies]
-hex = { workspace = true, default-features = true }
-hex-literal = { workspace = true, default-features = true }
 pallet-balances = { workspace = true, default-features = true }
 snowbridge-test-utils = { workspace = true }
 

bridges/snowbridge/pallets/system-frontend/Cargo.toml

@@ -39,7 +39,6 @@ snowbridge-outbound-queue-primitives = { workspace = true }
 snowbridge-pallet-system = { workspace = true }
 
 [dev-dependencies]
-hex = { workspace = true, default-features = true }
 hex-literal = { workspace = true, default-features = true }
 pallet-balances = { workspace = true, default-features = true }
 polkadot-primitives = { workspace = true, default-features = true }

bridges/snowbridge/pallets/system-v2/Cargo.toml

@@ -37,9 +37,6 @@ xcm-executor = { workspace = true }
 
 bp-relayers = { workspace = true }
 
-[dev-dependencies]
-hex = { workspace = true, default-features = true }
-
 [features]
 default = ["std"]
 std = [

bridges/snowbridge/primitives/core/Cargo.toml

@@ -31,10 +31,6 @@ sp-std = { workspace = true }
 
 ethabi = { workspace = true }
 
-[dev-dependencies]
-rand = { workspace = true, default-features = true }
-serde_json = { workspace = true, default-features = true }
-
 [features]
 default = ["std"]
 expensive_tests = []