[stable2512] Backport #10590 (#10603)

Backport #10590 into `stable2512` from bkchr.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: 3 people

polkadot/Cargo.toml

@@ -101,6 +101,7 @@ runtime-metrics = ["polkadot-cli/runtime-metrics"]
 pyroscope = ["polkadot-cli/pyroscope"]
 jemalloc-allocator = [
 	"dep:tikv-jemallocator",
+	"polkadot-cli/jemalloc-allocator",
 	"polkadot-node-core-pvf-prepare-worker/jemalloc-allocator",
 	"polkadot-node-core-pvf/jemalloc-allocator",
 	"polkadot-overseer/jemalloc-allocator",

polkadot/cli/Cargo.toml

@@ -82,3 +82,4 @@ runtime-metrics = [
 	"polkadot-node-metrics/runtime-metrics",
 	"polkadot-service/runtime-metrics",
 ]
+jemalloc-allocator = ["sc-service?/jemalloc-allocator"]

prdoc/pr_10590.prdoc

@@ -0,0 +1,14 @@
+title: 'sc-client-db: Make `jemalloc` optional'
+doc:
+- audience: Node Dev
+  description: |-
+    This changes `sc-client-db` to not always enable `jemalloc` by default for rocksdb. Instead it is now controlled by `jemalloc-allocator` feature. This is now also forwarded up to `polkadot` via `polkadot-cli` and `sc-service`. There we ultimately decide if `jemalloc` should be enabled or not.
+crates:
+- name: polkadot
+  bump: minor
+- name: polkadot-cli
+  bump: minor
+- name: sc-client-db
+  bump: minor
+- name: sc-service
+  bump: minor

substrate/client/db/Cargo.toml

@@ -27,7 +27,7 @@ codec = { features = ["derive"], workspace = true, default-features = true }
 hash-db = { workspace = true, default-features = true }
 kvdb = { workspace = true }
 kvdb-memorydb = { workspace = true }
-kvdb-rocksdb = { optional = true, workspace = true, features = ["jemalloc"] }
+kvdb-rocksdb = { optional = true, workspace = true }
 linked-hash-map = { workspace = true }
 log = { workspace = true, default-features = true }
 parity-db = { workspace = true }
@@ -63,3 +63,4 @@ runtime-benchmarks = [
 	"sp-runtime/runtime-benchmarks",
 ]
 rocksdb = ["kvdb-rocksdb", "sp-database/rocksdb"]
+jemalloc-allocator = ["kvdb-rocksdb?/jemalloc"]

substrate/client/service/Cargo.toml

@@ -87,3 +87,4 @@ runtime-benchmarks = [
 	"sc-client-db/runtime-benchmarks",
 	"sp-runtime/runtime-benchmarks",
 ]
+jemalloc-allocator = ["sc-client-db/jemalloc-allocator"]