Skip to content

Commit 833478f

Browse files
authored
Relax approval requirements on CI files (#2564)
- Remove the old Cumulus checks as these files do not exist anymore - Relax requirements on CI files to also give two core devs the right to change these files - Relax requirements on the review bot configuration itself as well.
1 parent 0b3d067 commit 833478f

File tree

1 file changed

+12
-35
lines changed

1 file changed

+12
-35
lines changed

.github/review-bot.yml

Lines changed: 12 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
rules:
22
- name: CI files
3+
countAuthor: true
34
condition:
45
include:
56
- ^\.gitlab-ci\.yml
@@ -8,24 +9,26 @@ rules:
89
- ^\.gitlab/.*
910
- ^\.config/nextest.toml
1011
- ^\.cargo/.*
11-
exclude:
12+
exclude:
1213
- ^\.gitlab/pipeline/zombienet.*
13-
minApprovals: 2
14-
type: basic
15-
teams:
16-
- ci
17-
- release-engineering
14+
type: "or"
15+
reviewers:
16+
- minApprovals: 2
17+
teams:
18+
- ci
19+
- minApprovals: 2
20+
teams:
21+
- core-devs
1822

1923
- name: Audit rules
2024
type: basic
2125
condition:
2226
include:
23-
- ^polkadot/runtime\/(kusama|polkadot|common)\/.*
27+
- ^polkadot/runtime/common/.*
2428
- ^polkadot/primitives/src\/.+\.rs$
2529
- ^substrate/primitives/.*
2630
- ^substrate/frame/.*
2731
exclude:
28-
- ^polkadot/runtime\/(kusama|polkadot)\/src\/weights\/.+\.rs$
2932
- ^substrate\/frame\/.+\.md$
3033
minApprovals: 1
3134
allowedToSkipRule:
@@ -41,13 +44,8 @@ rules:
4144
- .*
4245
# excluding files from 'Runtime files' and 'CI files' rules
4346
exclude:
44-
- ^polkadot/runtime/(kusama|polkadot)/src/[^/]+\.rs$
45-
- ^cumulus/parachains/runtimes/assets/(asset-hub-kusama|asset-hub-polkadot)/src/[^/]+\.rs$
46-
- ^cumulus/parachains/runtimes/bridge-hubs/(bridge-hub-kusama|bridge-hub-polkadot)/src/[^/]+\.rs$
47-
- ^cumulus/parachains/runtimes/collectives/collectives-polkadot/src/[^/]+\.rs$
4847
- ^cumulus/parachains/common/src/[^/]+\.rs$
4948
- ^substrate/frame/(?!.*(nfts/.*|uniques/.*|babe/.*|grandpa/.*|beefy|merkle-mountain-range/.*|contracts/.*|election|nomination-pools/.*|staking/.*|aura/.*))
50-
- ^polkadot/runtime/(kusama|polkadot)/src/[^/]+\.rs$
5149
- ^\.gitlab-ci\.yml
5250
- ^docker/.*
5351
- ^\.github/.*
@@ -59,24 +57,6 @@ rules:
5957
teams:
6058
- core-devs
6159

62-
# cumulus
63-
- name: Runtime files cumulus
64-
countAuthor: true
65-
condition:
66-
include:
67-
- ^cumulus/parachains/runtimes/assets/(asset-hub-kusama|asset-hub-polkadot)/src/[^/]+\.rs$
68-
- ^cumulus/parachains/runtimes/bridge-hubs/(bridge-hub-kusama|bridge-hub-polkadot)/src/[^/]+\.rs$
69-
- ^cumulus/parachains/runtimes/collectives/collectives-polkadot/src/[^/]+\.rs$
70-
- ^cumulus/parachains/common/src/[^/]+\.rs$
71-
type: and-distinct
72-
reviewers:
73-
- minApprovals: 1
74-
teams:
75-
- locks-review
76-
- minApprovals: 1
77-
teams:
78-
- polkadot-review
79-
8060
# if there are any changes in the bridges subtree (in case of backport changes back to bridges repo)
8161
- name: Bridges subtree files
8262
type: basic
@@ -88,7 +68,6 @@ rules:
8868
- bridges-core
8969

9070
# substrate
91-
9271
- name: FRAME coders substrate
9372
condition:
9473
include:
@@ -104,6 +83,7 @@ rules:
10483

10584
# Protection of THIS file
10685
- name: Review Bot
86+
countAuthor: true
10787
condition:
10888
include:
10989
- review-bot\.yml
@@ -115,9 +95,6 @@ rules:
11595
- minApprovals: 1
11696
teams:
11797
- locks-review
118-
- minApprovals: 1
119-
teams:
120-
- ci
12198

12299
preventReviewRequests:
123100
teams:

0 commit comments

Comments
 (0)