[stable2506] Backport #9912 (#10042)

Backport #9912 into `stable2506` from AndreiEres.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Andrei Eres <[email protected]>
Co-authored-by: Guillaume Thiolliere <[email protected]>
Co-authored-by: gui1117 <[email protected]>
Co-authored-by: Adrian Catangiu <[email protected]>
Co-authored-by: Egor_P <[email protected]>

Author: 5 people

Cargo.lock

@@ -0,0 +1,15 @@
+title: '[WIP] Fix statement-store gossiping'
+doc:
+- audience: Node Dev
+  description: |-
+    Fixes gossiping and scalability issues in the statement-store networking:
+    reduces traffic by propagating only recent statements, skips duplicate processing,
+    and splits large batches to stay under MAX_STATEMENT_NOTIFICATION_SIZE.
+crates:
+- name: sc-network-statement
+  bump: minor
+- name: sc-statement-store
+  bump: minor
+- name: sp-statement-store
+  bump: minor
+  validate: false

prdoc/pr_9912.prdoc

@@ -21,19 +21,15 @@ async-channel = { workspace = true }
 codec = { features = ["derive"], workspace = true, default-features = true }
 futures = { workspace = true }
 log = { workspace = true, default-features = true }
-prometheus-endpoint.default-features = true
-prometheus-endpoint.workspace = true
-sc-network-common.default-features = true
-sc-network-common.workspace = true
-sc-network-sync.default-features = true
-sc-network-sync.workspace = true
-sc-network-types.default-features = true
-sc-network-types.workspace = true
-sc-network.default-features = true
-sc-network.workspace = true
-sp-consensus.default-features = true
-sp-consensus.workspace = true
-sp-runtime.default-features = true
-sp-runtime.workspace = true
-sp-statement-store.default-features = true
-sp-statement-store.workspace = true
+prometheus-endpoint = { workspace = true, default-features = true }
+sc-network = { workspace = true, default-features = true }
+sc-network-common = { workspace = true, default-features = true }
+sc-network-sync = { workspace = true, default-features = true }
+sc-network-types = { workspace = true, default-features = true }
+sp-consensus = { workspace = true, default-features = true }
+sp-runtime = { workspace = true, default-features = true }
+sp-statement-store = { workspace = true, default-features = true }
+tokio = { workspace = true }
+
+[dev-dependencies]
+async-trait = { workspace = true }

substrate/client/network/statement/Cargo.toml

@@ -24,10 +24,10 @@ use std::time;
 pub(crate) const PROPAGATE_TIMEOUT: time::Duration = time::Duration::from_millis(1000);
 
 /// Maximum number of known statement hashes to keep for a peer.
-pub(crate) const MAX_KNOWN_STATEMENTS: usize = 4 * 1024 * 1024;
+pub(crate) const MAX_KNOWN_STATEMENTS: usize = 4 * 1024 * 1024; // * 32 bytes for hash = 128 MB per peer
 
 /// Maximum allowed size for a statement notification.
-pub(crate) const MAX_STATEMENT_SIZE: u64 = 256 * 1024;
+pub(crate) const MAX_STATEMENT_NOTIFICATION_SIZE: u64 = 1024 * 1024;
 
 /// Maximum number of statement validation request we keep at any moment.
 pub(crate) const MAX_PENDING_STATEMENTS: usize = 2 * 1024 * 1024;