Skip to content

Commit b607922

Browse files
alvicsamggwpez
authored andcommitted
[ci] Add experimental feature in tests and cargo check (#1173)
* [ci] Add experimental feature in tests and cargo check * fix labels GHA * disable D-labels * add check license * add auto-label-issues * fix CHECK_SPECS for labels * rm useless commands * Update .github/workflows/check-labels.yml * fix * Fudge license scanner * remove spellcheck job --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]>
1 parent 9c6c484 commit b607922

File tree

6 files changed

+47
-23
lines changed

6 files changed

+47
-23
lines changed
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# If the author of the issues is not a contributor to the project, label
2+
# the issue with 'Z0-unconfirmed'
3+
4+
name: Label New Issues
5+
on:
6+
issues:
7+
types: [opened]
8+
9+
jobs:
10+
label-new-issues:
11+
runs-on: ubuntu-latest
12+
steps:
13+
- name: Label drafts
14+
uses: andymckay/labeler@e6c4322d0397f3240f0e7e30a33b5c5df2d39e90 # 1.0.4
15+
if: github.event.issue.author_association == 'NONE'
16+
with:
17+
add-labels: "I10-unconfirmed"

.github/workflows/check-labels.yml

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
API_BASE: https://api.github.com/repos
2323
REPO: ${{ github.repository }}
2424
RULES_PATH: labels/ruled_labels
25-
CHECK_SPECS: "[DRAFT]specs_monorepo.yaml"
25+
CHECK_SPECS: "specs_polkadot-sdk.yaml"
2626
run: |
2727
echo "REPO: ${REPO}"
2828
echo "GITHUB_PR: ${GITHUB_PR}"
@@ -32,10 +32,6 @@ jobs:
3232
3333
# Temporary, before https://github.com/paritytech/labels/pull/29 is not merged
3434
git clone https://github.com/paritytech/labels
35-
cd labels
36-
git fetch origin the-right-joyce-monorepo-labels
37-
git checkout the-right-joyce-monorepo-labels
38-
cd ..
3935
4036
# Fetch the labels for the PR under test
4137
echo "Fetch the labels for $API_BASE/${REPO}/pulls/${GITHUB_PR}"
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
name: Check licenses
2+
3+
on:
4+
pull_request:
5+
6+
jobs:
7+
check-licenses:
8+
runs-on: ubuntu-22.04
9+
steps:
10+
- name: Checkout sources
11+
uses: actions/checkout@v3
12+
- uses: actions/[email protected]
13+
with:
14+
node-version: '18.x'
15+
registry-url: 'https://npm.pkg.github.com'
16+
scope: '@paritytech'
17+
- name: Check the licenses
18+
run: |
19+
shopt -s globstar
20+
21+
npx --yes https://github.com/paritytech/license-scanner scan \
22+
--ensure-licenses=Apache-2.0 \
23+
--ensure-licenses=GPL-3.0-only \
24+
./**/*.rs
25+
env:
26+
NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.gitlab/pipeline/check.yml

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ check-try-runtime:
2020
- time cargo check --locked -p parachain-template-node --features try-runtime
2121
# add after https://github.com/paritytech/substrate/pull/14502 is merged
2222
# experimental code may rely on try-runtime and vice-versa
23-
# - time cargo check --locked --features try-runtime,experimental
23+
- time cargo check --locked --features try-runtime,experimental
2424

2525
cargo-fmt-manifest:
2626
stage: check
@@ -57,21 +57,6 @@ cargo-deny-licenses:
5757
paths:
5858
- deny.log
5959

60-
spellcheck:
61-
stage: check
62-
extends:
63-
- .kubernetes-env
64-
- .common-refs
65-
script:
66-
- cargo spellcheck --version
67-
# compare with the commit parent to the PR, given it's from a default branch
68-
- git fetch origin +${CI_DEFAULT_BRANCH}:${CI_DEFAULT_BRANCH}
69-
- echo "___Spellcheck is going to check your diff___"
70-
- cargo spellcheck list-files -vvv $(git diff --diff-filter=AM --name-only $(git merge-base ${CI_COMMIT_SHA} ${CI_DEFAULT_BRANCH} -- :^bridges))
71-
- time cargo spellcheck check -vvv --cfg=.gitlab/spellcheck.toml --checkers hunspell --code 1
72-
$(git diff --diff-filter=AM --name-only $(git merge-base ${CI_COMMIT_SHA} ${CI_DEFAULT_BRANCH} -- :^bridges))
73-
allow_failure: true
74-
7560
# from substrate
7661
# not sure if it's needed in monorepo
7762
check-dependency-rules:

.gitlab/pipeline/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ test-linux-stable:
3434
--release \
3535
--verbose \
3636
--no-fail-fast \
37-
--features runtime-benchmarks,try-runtime \
37+
--features runtime-benchmarks,try-runtime,experimental \
3838
--partition count:${CI_NODE_INDEX}/${CI_NODE_TOTAL}
3939
# run runtime-api tests with `enable-staging-api` feature on the 1st node
4040
- if [ ${CI_NODE_INDEX} == 1 ]; then time cargo nextest run -p sp-api-test --features enable-staging-api; fi

substrate/.github/workflows/auto-label-issues.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ jobs:
1414
uses: andymckay/labeler@e6c4322d0397f3240f0e7e30a33b5c5df2d39e90 # 1.0.4
1515
if: github.event.issue.author_association == 'NONE'
1616
with:
17-
add-labels: "J2-unconfirmed"
17+
add-labels: "I10-unconfirmed"

0 commit comments

Comments
 (0)