Skip to content

Commit c5dc882

Browse files
paritytech-release-backport-bot[bot]gui1117github-actions[bot]bkchr
authored
[stable2409] Backport #9355 (#9365)
Backport #9355 into `stable2409` from gui1117. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Guillaume Thiolliere <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bastian Köcher <[email protected]>
1 parent d5dda01 commit c5dc882

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

prdoc/pr_9355.prdoc

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
title: 'substrate-prometheus-endpoint: directly require the feature "tokio/net"'
2+
doc:
3+
- audience: Node Dev
4+
description: |-
5+
The crate `substrate-prometheus-endpoint` use tokio items given by the feature "net" but it doesn't explictly requires it in the `Cargo.toml`. It compiles on master because `hyper-util` enables the feature "tokio/net". But upgrading `hyper-util` break this indirect enabling.
6+
7+
This fix the issue by directly setting "net" feature as required, as it is used.
8+
We should also backport this ideally. It is not a breaking change given the code doesn't compile without the feature and only compiles if indirectly enabled by another crate.
9+
crates:
10+
- name: substrate-prometheus-endpoint
11+
bump: patch

substrate/utils/prometheus/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ hyper-util = { features = ["server-auto", "tokio"], workspace = true }
2222
log = { workspace = true, default-features = true }
2323
prometheus = { workspace = true }
2424
thiserror = { workspace = true }
25-
tokio = { features = ["parking_lot"], workspace = true, default-features = true }
25+
tokio = { features = ["net", "parking_lot"], workspace = true, default-features = true }
2626

2727
[dev-dependencies]
2828
hyper-util = { features = ["client-legacy", "tokio"], workspace = true, default-features = true }

0 commit comments

Comments
 (0)