transfer_assets benchmarking and weights for coretime chains (#8752)

Introduces implementation of `set_up_complex_asset_transfer()` to
correctly benchmark weights for `transfer_assets` extrinsics on Rococo
Coretime and Westend Coretime. Introducing also test scenarios to cover
common xcm teleport use cases

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Author: karolk91

Cargo.lock

@@ -21,7 +21,6 @@ sp-runtime = { workspace = true }
 polkadot-runtime-parachains = { workspace = true, default-features = true }
 rococo-runtime-constants = { workspace = true, default-features = true }
 xcm = { workspace = true }
-xcm-executor = { workspace = true }
 
 # Cumulus
 cumulus-pallet-parachain-system = { workspace = true, default-features = true }

cumulus/parachains/integration-tests/emulated/tests/coretime/coretime-rococo/Cargo.toml

@@ -27,12 +27,17 @@ mod imports {
 		assert_expected_events, Chain, Parachain, TestExt,
 	};
 	pub(crate) use rococo_system_emulated_network::{
+		asset_hub_rococo_emulated_chain::genesis::ED as ASSET_HUB_ROCOCO_ED,
 		coretime_rococo_emulated_chain::{
 			coretime_rococo_runtime::ExistentialDeposit as CoretimeRococoExistentialDeposit,
-			CoretimeRococoParaPallet as CoretimeRococoPallet,
+			genesis::ED as CORETIME_ROCOCO_ED, CoretimeRococoParaPallet as CoretimeRococoPallet,
 		},
-		CoretimeRococoPara as CoretimeRococo, CoretimeRococoParaReceiver as CoretimeRococoReceiver,
+		rococo_emulated_chain::{genesis::ED as ROCOCO_ED, RococoRelayPallet as RococoPallet},
+		AssetHubRococoPara as AssetHubRococo, AssetHubRococoParaReceiver as AssetHubRococoReceiver,
+		AssetHubRococoParaSender as AssetHubRococoSender, CoretimeRococoPara as CoretimeRococo,
+		CoretimeRococoParaReceiver as CoretimeRococoReceiver,
 		CoretimeRococoParaSender as CoretimeRococoSender, RococoRelay as Rococo,
+		RococoRelayReceiver as RococoReceiver, RococoRelaySender as RococoSender,
 	};
 }
 

cumulus/parachains/integration-tests/emulated/tests/coretime/coretime-rococo/src/lib.rs

@@ -15,3 +15,4 @@
 
 mod claim_assets;
 mod coretime_interface;
+mod teleport;

cumulus/parachains/integration-tests/emulated/tests/coretime/coretime-rococo/src/tests/mod.rs

@@ -0,0 +1,112 @@
+// Copyright (C) Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: Apache-2.0
+
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// 	http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use crate::imports::*;
+use emulated_integration_tests_common::{
+	test_parachain_is_trusted_teleporter, test_parachain_is_trusted_teleporter_for_relay,
+	test_relay_is_trusted_teleporter,
+};
+
+#[test]
+fn teleport_via_limited_teleport_assets_from_and_to_relay() {
+	let amount = ROCOCO_ED * 10;
+	let native_asset: Assets = (Here, amount).into();
+
+	test_relay_is_trusted_teleporter!(
+		Rococo,               // Origin
+		vec![CoretimeRococo], // Destinations
+		(native_asset, amount),
+		limited_teleport_assets
+	);
+
+	test_parachain_is_trusted_teleporter_for_relay!(
+		CoretimeRococo, // Origin
+		Rococo,         // Destination
+		amount,
+		limited_teleport_assets
+	);
+}
+
+#[test]
+fn teleport_via_transfer_assets_from_and_to_relay() {
+	let amount = ROCOCO_ED * 10;
+	let native_asset: Assets = (Here, amount).into();
+
+	test_relay_is_trusted_teleporter!(
+		Rococo,               // Origin
+		vec![CoretimeRococo], // Destinations
+		(native_asset, amount),
+		transfer_assets
+	);
+
+	test_parachain_is_trusted_teleporter_for_relay!(
+		CoretimeRococo, // Origin
+		Rococo,         // Destination
+		amount,
+		transfer_assets
+	);
+}
+
+#[test]
+fn teleport_via_limited_teleport_assets_from_coretime_to_asset_hub() {
+	let amount = ASSET_HUB_ROCOCO_ED * 100;
+	let native_asset: Assets = (Parent, amount).into();
+
+	test_parachain_is_trusted_teleporter!(
+		CoretimeRococo,       // Origin
+		vec![AssetHubRococo], // Destinations
+		(native_asset, amount),
+		limited_teleport_assets
+	);
+}
+
+#[test]
+fn teleport_via_transfer_assets_from_coretime_to_asset_hub() {
+	let amount = ASSET_HUB_ROCOCO_ED * 100;
+	let native_asset: Assets = (Parent, amount).into();
+
+	test_parachain_is_trusted_teleporter!(
+		CoretimeRococo,       // Origin
+		vec![AssetHubRococo], // Destinations
+		(native_asset, amount),
+		transfer_assets
+	);
+}
+
+#[test]
+fn teleport_via_limited_teleport_assets_from_asset_hub_to_coretime() {
+	let amount = CORETIME_ROCOCO_ED * 100;
+	let native_asset: Assets = (Parent, amount).into();
+
+	test_parachain_is_trusted_teleporter!(
+		AssetHubRococo,       // Origin
+		vec![CoretimeRococo], // Destinations
+		(native_asset, amount),
+		limited_teleport_assets
+	);
+}
+
+#[test]
+fn teleport_via_transfer_assets_from_asset_hub_to_coretime() {
+	let amount = CORETIME_ROCOCO_ED * 100;
+	let native_asset: Assets = (Parent, amount).into();
+
+	test_parachain_is_trusted_teleporter!(
+		AssetHubRococo,       // Origin
+		vec![CoretimeRococo], // Destinations
+		(native_asset, amount),
+		transfer_assets
+	);
+}

cumulus/parachains/integration-tests/emulated/tests/coretime/coretime-rococo/src/tests/teleport.rs

@@ -15,7 +15,6 @@ workspace = true
 frame-support = { workspace = true }
 pallet-broker = { workspace = true, default-features = true }
 pallet-message-queue = { workspace = true }
-pallet-xcm = { workspace = true }
 sp-runtime = { workspace = true }
 
 # Polkadot

cumulus/parachains/integration-tests/emulated/tests/coretime/coretime-westend/Cargo.toml

@@ -27,22 +27,28 @@ mod imports {
 		assert_expected_events, Chain, Parachain, TestExt,
 	};
 	pub(crate) use westend_system_emulated_network::{
-		asset_hub_westend_emulated_chain::AssetHubWestendParaPallet as AssetHubWestendPallet,
+		asset_hub_westend_emulated_chain::{
+			genesis::ED as ASSET_HUB_WESTEND_ED, AssetHubWestendParaPallet as AssetHubWestendPallet,
+		},
 		bridge_hub_westend_emulated_chain::BridgeHubWestendParaPallet as BridgeHubWestendPallet,
 		collectives_westend_emulated_chain::CollectivesWestendParaPallet as CollectivesWestendPallet,
 		coretime_westend_emulated_chain::{
 			self,
 			coretime_westend_runtime::ExistentialDeposit as CoretimeWestendExistentialDeposit,
-			CoretimeWestendParaPallet as CoretimeWestendPallet,
+			genesis::ED as CORETIME_WESTEND_ED, CoretimeWestendParaPallet as CoretimeWestendPallet,
 		},
 		penpal_emulated_chain::{PenpalAssetOwner, PenpalBParaPallet as PenpalBPallet},
 		people_westend_emulated_chain::PeopleWestendParaPallet as PeopleWestendPallet,
-		westend_emulated_chain::genesis::ED as WESTEND_ED,
-		AssetHubWestendPara as AssetHubWestend, BridgeHubWestendPara as BridgeHubWestend,
-		CollectivesWestendPara as CollectivesWestend, CoretimeWestendPara as CoretimeWestend,
+		westend_emulated_chain::{genesis::ED as WESTEND_ED, WestendRelayPallet as WestendPallet},
+		AssetHubWestendPara as AssetHubWestend,
+		AssetHubWestendParaReceiver as AssetHubWestendReceiver,
+		AssetHubWestendParaSender as AssetHubWestendSender,
+		BridgeHubWestendPara as BridgeHubWestend, CollectivesWestendPara as CollectivesWestend,
+		CoretimeWestendPara as CoretimeWestend,
 		CoretimeWestendParaReceiver as CoretimeWestendReceiver,
 		CoretimeWestendParaSender as CoretimeWestendSender, PenpalBPara as PenpalB,
 		PeopleWestendPara as PeopleWestend, WestendRelay as Westend,
+		WestendRelayReceiver as WestendReceiver, WestendRelaySender as WestendSender,
 	};
 }
 

cumulus/parachains/integration-tests/emulated/tests/coretime/coretime-westend/src/lib.rs

@@ -16,3 +16,4 @@
 mod aliases;
 mod claim_assets;
 mod coretime_interface;
+mod teleport;

cumulus/parachains/integration-tests/emulated/tests/coretime/coretime-westend/src/tests/mod.rs

@@ -0,0 +1,112 @@
+// Copyright (C) Parity Technologies (UK) Ltd.
+// SPDX-License-Identifier: Apache-2.0
+
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// 	http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+use crate::imports::*;
+use emulated_integration_tests_common::{
+	test_parachain_is_trusted_teleporter, test_parachain_is_trusted_teleporter_for_relay,
+	test_relay_is_trusted_teleporter,
+};
+
+#[test]
+fn teleport_via_limited_teleport_assets_from_and_to_relay() {
+	let amount = WESTEND_ED * 10;
+	let native_asset: Assets = (Here, amount).into();
+
+	test_relay_is_trusted_teleporter!(
+		Westend,               // Origin
+		vec![CoretimeWestend], // Destinations
+		(native_asset, amount),
+		limited_teleport_assets
+	);
+
+	test_parachain_is_trusted_teleporter_for_relay!(
+		CoretimeWestend, // Origin
+		Westend,         // Destination
+		amount,
+		limited_teleport_assets
+	);
+}
+
+#[test]
+fn teleport_via_transfer_assets_from_and_to_relay() {
+	let amount = WESTEND_ED * 10;
+	let native_asset: Assets = (Here, amount).into();
+
+	test_relay_is_trusted_teleporter!(
+		Westend,               // Origin
+		vec![CoretimeWestend], // Destinations
+		(native_asset, amount),
+		transfer_assets
+	);
+
+	test_parachain_is_trusted_teleporter_for_relay!(
+		CoretimeWestend, // Origin
+		Westend,         // Destination
+		amount,
+		transfer_assets
+	);
+}
+
+#[test]
+fn teleport_via_limited_teleport_assets_from_coretime_to_asset_hub() {
+	let amount = ASSET_HUB_WESTEND_ED * 100;
+	let native_asset: Assets = (Parent, amount).into();
+
+	test_parachain_is_trusted_teleporter!(
+		CoretimeWestend,       // Origin
+		vec![AssetHubWestend], // Destinations
+		(native_asset, amount),
+		limited_teleport_assets
+	);
+}
+
+#[test]
+fn teleport_via_transfer_assets_from_coretime_to_asset_hub() {
+	let amount = ASSET_HUB_WESTEND_ED * 100;
+	let native_asset: Assets = (Parent, amount).into();
+
+	test_parachain_is_trusted_teleporter!(
+		CoretimeWestend,       // Origin
+		vec![AssetHubWestend], // Destinations
+		(native_asset, amount),
+		transfer_assets
+	);
+}
+
+#[test]
+fn teleport_via_limited_teleport_assets_from_asset_hub_to_coretime() {
+	let amount = CORETIME_WESTEND_ED * 100;
+	let native_asset: Assets = (Parent, amount).into();
+
+	test_parachain_is_trusted_teleporter!(
+		AssetHubWestend,       // Origin
+		vec![CoretimeWestend], // Destinations
+		(native_asset, amount),
+		limited_teleport_assets
+	);
+}
+
+#[test]
+fn teleport_via_transfer_assets_from_asset_hub_to_coretime() {
+	let amount = CORETIME_WESTEND_ED * 100;
+	let native_asset: Assets = (Parent, amount).into();
+
+	test_parachain_is_trusted_teleporter!(
+		AssetHubWestend,       // Origin
+		vec![CoretimeWestend], // Destinations
+		(native_asset, amount),
+		transfer_assets
+	);
+}

cumulus/parachains/integration-tests/emulated/tests/coretime/coretime-westend/src/tests/teleport.rs

@@ -1030,6 +1030,16 @@ impl_runtime_apis! {
 					))
 				}
 
+				fn set_up_complex_asset_transfer() -> Option<(Assets, u32, Location, alloc::boxed::Box<dyn FnOnce()>)> {
+					let native_location = Parent.into();
+					let dest = Parent.into();
+
+					pallet_xcm::benchmarking::helpers::native_teleport_as_asset_transfer::<Runtime>(
+						native_location,
+						dest,
+					)
+				}
+
 				fn get_asset() -> Asset {
 					Asset {
 						id: AssetId(Location::parent()),