Skip to content

Commit d841bdc

Browse files
authored
Revert "companion for 14754: cli: move no-beefy flag to sc-cli (#2996)" (#3007)
* Revert "companion for 14754: cli: move no-beefy flag to sc-cli (#2996)" This reverts commit ab840db. * bump substrate ref * update lockfile for {"polkadot", "substrate"} --------- Co-authored-by: parity-processbot <>
1 parent f75a57a commit d841bdc

File tree

7 files changed

+269
-285
lines changed

7 files changed

+269
-285
lines changed

cumulus/Cargo.lock

Lines changed: 266 additions & 264 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cumulus/client/cli/src/lib.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -394,10 +394,6 @@ impl sc_cli::CliConfiguration for NormalizedRunCmd {
394394
self.base.disable_grandpa()
395395
}
396396

397-
fn disable_beefy(&self) -> sc_cli::Result<bool> {
398-
self.base.disable_beefy()
399-
}
400-
401397
fn rpc_max_connections(&self) -> sc_cli::Result<u32> {
402398
self.base.rpc_max_connections()
403399
}

cumulus/client/relay-chain-inprocess-interface/src/lib.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ pub fn check_block_in_chain(
267267
/// Build the Polkadot full node using the given `config`.
268268
#[sc_tracing::logging::prefix_logs_with("Relaychain")]
269269
fn build_polkadot_full_node(
270-
mut config: Configuration,
270+
config: Configuration,
271271
parachain_config: &Configuration,
272272
telemetry_worker_handle: Option<TelemetryWorkerHandle>,
273273
hwbench: Option<sc_sysinfo::HwBench>,
@@ -279,14 +279,13 @@ fn build_polkadot_full_node(
279279
(polkadot_service::IsParachainNode::FullNode, None)
280280
};
281281

282-
// Disable BEEFY. It should not be required by the internal relay chain node.
283-
config.disable_beefy = true;
284-
285282
let relay_chain_full_node = polkadot_service::build_full(
286283
config,
287284
polkadot_service::NewFullParams {
288285
is_parachain_node,
289286
grandpa_pause: None,
287+
// Disable BEEFY. It should not be required by the internal relay chain node.
288+
enable_beefy: false,
290289
jaeger_agent: None,
291290
telemetry_worker_handle,
292291

cumulus/parachain-template/node/src/command.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -408,10 +408,6 @@ impl CliConfiguration<Self> for RelayChainCli {
408408
self.base.base.disable_grandpa()
409409
}
410410

411-
fn disable_beefy(&self) -> Result<bool> {
412-
self.base.base.disable_beefy()
413-
}
414-
415411
fn max_runtime_instances(&self) -> Result<Option<usize>> {
416412
self.base.base.max_runtime_instances()
417413
}

cumulus/polkadot-parachain/src/command.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1064,10 +1064,6 @@ impl CliConfiguration<Self> for RelayChainCli {
10641064
self.base.base.disable_grandpa()
10651065
}
10661066

1067-
fn disable_beefy(&self) -> Result<bool> {
1068-
self.base.base.disable_beefy()
1069-
}
1070-
10711067
fn max_runtime_instances(&self) -> Result<Option<usize>> {
10721068
self.base.base.max_runtime_instances()
10731069
}

cumulus/test/service/src/cli.rs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,10 +220,6 @@ impl CliConfiguration<Self> for RelayChainCli {
220220
self.base.base.disable_grandpa()
221221
}
222222

223-
fn disable_beefy(&self) -> CliResult<bool> {
224-
self.base.base.disable_beefy()
225-
}
226-
227223
fn max_runtime_instances(&self) -> CliResult<Option<usize>> {
228224
self.base.base.max_runtime_instances()
229225
}

cumulus/test/service/src/lib.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -773,7 +773,6 @@ pub fn node_config(
773773
offchain_worker: OffchainWorkerConfig { enabled: true, indexing_enabled: false },
774774
force_authoring: false,
775775
disable_grandpa: false,
776-
disable_beefy: true,
777776
dev_key_seed: Some(key_seed),
778777
tracing_targets: None,
779778
tracing_receiver: Default::default(),

0 commit comments

Comments
 (0)