fix(in_mem): fix the clone logic (#14038)

yjhmelody · web-flow · commit 74b2c92066ec · 2023-04-29T12:06:42.000+02:00
diff --git a/client/api/src/in_mem.rs b/client/api/src/in_mem.rs
@@ -114,6 +114,7 @@ struct BlockchainStorage<Block: BlockT> {
 }
 
 /// In-memory blockchain. Supports concurrent reads.
+#[derive(Clone)]
 pub struct Blockchain<Block: BlockT> {
 	storage: Arc<RwLock<BlockchainStorage<Block>>>,
 }
@@ -124,13 +125,6 @@ impl<Block: BlockT> Default for Blockchain<Block> {
 	}
 }
 
-impl<Block: BlockT + Clone> Clone for Blockchain<Block> {
-	fn clone(&self) -> Self {
-		let storage = Arc::new(RwLock::new(self.storage.read().clone()));
-		Blockchain { storage }
-	}
-}
-
 impl<Block: BlockT> Blockchain<Block> {
 	/// Get header hash of given block.
 	pub fn id(&self, id: BlockId<Block>) -> Option<Block::Hash> {

Original file line number	Diff line number	Diff line change
`@@ -114,6 +114,7 @@ struct BlockchainStorage<Block: BlockT> {`
`114`	`114`	`}`
`115`	`115`
`116`	`116`	`/// In-memory blockchain. Supports concurrent reads.`
	`117`	`+#[derive(Clone)]`
`117`	`118`	`pub struct Blockchain<Block: BlockT> {`
`118`	`119`	`storage: Arc<RwLock<BlockchainStorage<Block>>>,`
`119`	`120`	`}`
`@@ -124,13 +125,6 @@ impl<Block: BlockT> Default for Blockchain<Block> {`
`124`	`125`	`}`
`125`	`126`	`}`
`126`	`127`
`127`		`-impl<Block: BlockT + Clone> Clone for Blockchain<Block> {`
`128`		`- fn clone(&self) -> Self {`
`129`		`- let storage = Arc::new(RwLock::new(self.storage.read().clone()));`
`130`		`- Blockchain { storage }`
`131`		`- }`
`132`		`-}`
`133`		`-`
`134`	`128`	`impl<Block: BlockT> Blockchain<Block> {`
`135`	`129`	`/// Get header hash of given block.`
`136`	`130`	`pub fn id(&self, id: BlockId<Block>) -> Option<Block::Hash> {`