First pass converting historic metadatas to our subxt::Metadata type

Author: jsdw

Cargo.lock

@@ -192,3 +192,6 @@ opt-level = 2
 opt-level = 2
 [profile.test.package.smoldot]
 opt-level = 2
+
+[patch.crates-io]
+frame-decode = { path = "../frame-decode" }

Cargo.toml

@@ -494,7 +494,7 @@ mod tests {
         let metadata = metadata();
 
         // Except our metadata to contain the registered types.
-        let pallet = metadata.pallet_by_index(0).expect("pallet exists");
+        let pallet = metadata.pallet_by_call_index(0).expect("pallet exists");
         let extrinsic = pallet
             .call_variant_by_index(2)
             .expect("metadata contains the RuntimeCall enum with this pallet");

core/src/blocks/extrinsics.rs

@@ -262,7 +262,7 @@ impl<T: Config> EventDetails<T> {
 
         // Get metadata for the event:
         let event_pallet = metadata
-            .pallet_by_index(pallet_index)
+            .pallet_by_event_index(pallet_index)
             .ok_or_else(|| EventsError::CannotFindPalletWithIndex(pallet_index))?;
         let event_variant = event_pallet
             .event_variant_by_index(variant_index)
@@ -359,7 +359,7 @@ impl<T: Config> EventDetails<T> {
     pub fn event_metadata(&self) -> EventMetadataDetails<'_> {
         let pallet = self
             .metadata
-            .pallet_by_index(self.pallet_index())
+            .pallet_by_event_index(self.pallet_index())
             .expect("event pallet to be found; we did this already during decoding");
         let variant = pallet
             .event_variant_by_index(self.variant_index())

core/src/events.rs

@@ -182,7 +182,7 @@ impl<CallData: EncodeAsFields> Payload for DefaultPayload<CallData> {
                 call_name: self.call_name.to_string(),
             })?;
 
-        let pallet_index = pallet.index();
+        let pallet_index = pallet.call_index();
         let call_index = call.index;
 
         pallet_index.encode_to(out);

core/src/tx/payload.rs

@@ -14,11 +14,16 @@ homepage.workspace = true
 description = "Command line utilities for checking metadata compatibility between nodes."
 
 [features]
-default = ["std"]
+default = ["std", "legacy"]
 std = ["scale-info/std", "frame-metadata/std"]
 
+# Enable decoding of legacy metadata, too.
+legacy = ["dep:scale-info-legacy", "dep:scale-type-resolver"]
+
 [dependencies]
 scale-info = { workspace = true, default-features = false }
+scale-info-legacy = { workspace = true, optional = true }
+scale-type-resolver = { workspace = true, optional = true }
 frame-decode = { workspace = true }
 frame-metadata = { workspace = true, default-features = false, features = ["current", "decode"] }
 codec = { package = "parity-scale-codec", workspace = true, default-features = false, features = ["derive"] }