refactor: Ruff check --fix + manual fixes

Author: Pefington

benchmark/benchmark_snapshot.py

@@ -80,10 +80,7 @@ def benchmark(args, executor):
     image = Image.open(args.image)
     for resolution in [(800, 600), (1280, 720), (1920, 1080), (2560, 1440), (3840, 2160)]:
         image.resize(resolution).save("/tmp/platerec-benchmark.jpg")
-        if args.blur:
-            configs = [{}]
-        else:
-            configs = [{}, dict(mode="fast")]
+        configs = [{}] if args.blur else [{}, dict(mode="fast")]
 
         for config in configs:
             stats = list(
@@ -99,7 +96,7 @@ def benchmark(args, executor):
                 )
             )
             yield dict(
-                resolution="%sx%s" % resolution,
+                resolution=f"{resolution[0]}x{resolution[1]}",
                 mode=config.get("mode", "regular"),
                 min=min(stats),
                 max=max(stats),

blur/main.py

@@ -101,11 +101,7 @@ def process(args, path: Path, output: Path, logo=None):
         }
         if args.copy_metadata:
             data["copy_metadata"] = "true"
-
-        if args.api_key:
-            headers = {"Authorization": f"Token {args.api_key}"}
-        else:
-            headers = None
+        headers = {"Authorization": f"Token {args.api_key}"} if args.api_key else None
 
         response = requests.post(
             args.blur_url,

docker/platerec_installer/installer_helpers.py

@@ -117,9 +117,7 @@ def verify_token(token, license_key, get_license=True, product="stream"):
         return False, "API token and license key is required."
     try:
         req = Request(
-            "https://api.platerecognizer.com/v1/{}/{}/".format(
-                path, license_key.strip()
-            )
+            f"https://api.platerecognizer.com/v1/{path}/{license_key.strip()}/"
         )
         req.add_header("Authorization", f"Token {token.strip()}")
         urlopen(req).read()

docker/platerec_installer/stream_config.py

@@ -78,7 +78,7 @@ def send_request(section):
     if "/api/v1/webhook-receiver" not in section["webhook_target"]:
         return
     headers = {
-        "Authorization": "Token %s" % section["webhook_header"].split("Token ")[-1]
+        "Authorization": f"Token {section['webhook_header'].split('Token ')[-1]}"
     }
     url = section["webhook_target"].replace("webhook-receiver", "parking-list")
     try:
@@ -184,13 +184,13 @@ def base_config(config_path: Path, config=None):
         error_message = "[STR0021] The config.ini file does not seem to be formatted correctly.  \n [Error details] \n"
         for section_list, key, error in errors:
             if error is False:
-                error = "key %s is missing." % key
+                error = f"key {key} is missing."
             elif key is not None:
                 section_list.append(key)
             section_string = "/".join(section_list)
             logging.error("%s: %s", section_string, error)
             error = f"{section_string}, param: {key}, message: {error}"
-            error_message += "\n%s" % error
+            error_message += f"\n{error}"
         return (
             None,
             error_message

docker/sdk_manager/PlateRec_SDK_Manager.py

@@ -305,18 +305,14 @@ def uninstall():
     token, _ = get_token_input(get_license=False)
     if uninstall_choice == "1":
         stop_container(image)
-        cmd = "docker run --rm -t -v license:/license -e TOKEN={} -e UNINSTALL=1 {}".format(
-            token, image
-        )
+        cmd = f"docker run --rm -t -v license:/license -e TOKEN={token} -e UNINSTALL=1 {image}"
 
         os.system(cmd)
         return main()
 
     elif uninstall_choice == "2":
         container_id = stop_container(image)
-        cmd = "docker run --rm -t -v license:/license -e TOKEN={} -e UNINSTALL=1 {}".format(
-            token, image
-        )
+        cmd = f"docker run --rm -t -v license:/license -e TOKEN={token} -e UNINSTALL=1 {image}"
         os.system(cmd)
         container_id = get_container_id(image)
         if container_id:

ftp_and_sftp_processor.py

@@ -280,11 +280,7 @@ def is_linux_os(self, file_list):
         # check if OS is Linux or Windows
         for info in file_list:
             info_first_possition = info[0]
-            if info_first_possition.startswith("d") or info_first_possition.startswith(
-                "-"
-            ):
-                return True
-            return False
+            return bool(info_first_possition.startswith("d") or info_first_possition.startswith("-"))
 
     def set_ftp_binary_file(self, file, image):
         """Retrieve a file in binary transfer mode

parkpow/auto-file-import-tool/src/config.py

@@ -116,9 +116,9 @@ def load_config() -> dict[str, Any]:
         # Main reading logic (remains the same)
         if config.has_option(section, option):
             try:
-                if data_type == int:
+                if data_type is int:
                     value = config.getint(section, option)
-                elif data_type == bool:
+                elif data_type is bool:
                     value = config.getboolean(section, option)
                 else:
                     value = config.get(section, option)  # type: ignore

parkpow/auto-file-import-tool/src/logger_setup.py

@@ -44,11 +44,11 @@ def setup_logging():
     # logging.getLogger('urllib3').setLevel(logging.WARNING)
 
     # Setup checker errors logger
-    CHECKER_ERRORS_LOG_FILE = os.path.join(LOGS_FOLDER, "checker_errors.log")
+    checker_errors_log_file = os.path.join(LOGS_FOLDER, "checker_errors.log")
     checker_errors_logger = logging.getLogger("checker_errors_logger")
     checker_errors_logger.setLevel(logging.WARNING)
     checker_errors_handler = RotatingFileHandler(
-        CHECKER_ERRORS_LOG_FILE, maxBytes=1024 * 1024 * 5, backupCount=2
+        checker_errors_log_file, maxBytes=1024 * 1024 * 5, backupCount=2
     )
     checker_errors_handler.setFormatter(log_format)
     checker_errors_logger.addHandler(checker_errors_handler)

parkpow/auto-file-import-tool/src/main.py

@@ -52,7 +52,7 @@ def save_current_state(license_plates: set):
         logger.error(f"Error saving current state to {STATE_FILE}: {e}")
 
 
-def main():
+def main():  # noqa: C901 TODO: Break down to reduce cyclomatic complexity
     logger.info("Starting synchronization cycle.")
     all_monitoring_threads = []
 

parkpow/csv-upload/main.py

@@ -118,10 +118,7 @@ def parse_row_result(row: list):
         file = row[1]
         plate = ast.literal_eval(row[5])
         position_sec = row[3]
-        if len(row[4]):
-            direction = row[4]
-        else:
-            direction = None
+        direction = row[4] if len(row[4]) else None
         vehicle = ast.literal_eval(row[6])
 
         # if plate["props"] is None: # TODO how to handle such a case
@@ -132,10 +129,7 @@ def parse_row_result(row: list):
         # candidates,source_url,position_sec,direction
         file = row[4]
         position_sec = row[13]
-        if len(row[14]):
-            direction = row[14]
-        else:
-            direction = None
+        direction = row[14] if len(row[14]) else None
         region = ast.literal_eval(row[9])
         plate = {
             "box": ast.literal_eval(row[5]),