Skip to content

Commit 9a521e9

Browse files
committed
Merge branch 'master' of github.com:ParsePlatform/Parse-SDK-JS into release-1.8.0
Conflicts: src/__tests__/ParseUser-test.js
2 parents 904183c + f6ec683 commit 9a521e9

File tree

6 files changed

+45
-4
lines changed

6 files changed

+45
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "parse",
3-
"version": "1.7.0",
3+
"version": "1.7.1",
44
"description": "The Parse JavaScript SDK",
55
"homepage": "https://www.parse.com",
66
"keywords": [

src/CoreManager.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@ var config: { [key: string]: mixed } = {
113113
// Defaults
114114
IS_NODE: (typeof process !== 'undefined' &&
115115
!!process.versions &&
116-
!!process.versions.node),
116+
!!process.versions.node &&
117+
!process.version.electron),
117118
REQUEST_ATTEMPT_LIMIT: 5,
118119
SERVER_URL: 'https://api.parse.com/1',
119120
VERSION: 'js' + require('../package.json').version,

src/Parse.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ var Parse = {
2525
* You can get your keys from the Data Browser on parse.com.
2626
* @method initialize
2727
* @param {String} applicationId Your Parse Application ID.
28-
* @param {String} javaScriptKey Your Parse JavaScript Key.
28+
* @param {String} javaScriptKey (optional) Your Parse JavaScript Key (Not needed for parse-server)
2929
* @param {String} masterKey (optional) Your Parse Master Key. (Node.js only!)
3030
* @static
3131
*/

src/RESTController.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,10 @@ const RESTController = {
163163
}
164164

165165
payload._ApplicationId = CoreManager.get('APPLICATION_ID');
166-
payload._JavaScriptKey = CoreManager.get('JAVASCRIPT_KEY');
166+
let jsKey = CoreManager.get('JAVASCRIPT_KEY');
167+
if (jsKey) {
168+
payload._JavaScriptKey = jsKey;
169+
}
167170
payload._ClientVersion = CoreManager.get('VERSION');
168171

169172
var useMasterKey = options.useMasterKey;

src/__tests__/CoreManager-test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ describe('CoreManager', () => {
2020
expect(CoreManager.get('VERSION').length).toBeGreaterThan(0);
2121
});
2222

23+
it('detects when running in node', () => {
24+
expect(CoreManager.get('IS_NODE')).toBe(true);
25+
});
26+
2327
it('can set and retrieve arbitrary values', () => {
2428
expect(CoreManager.get.bind(null, 'something')).toThrow(
2529
'Configuration key not found: something'

src/__tests__/ParseUser-test.js

Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,39 @@ describe('ParseUser', () => {
522522
});
523523
}));
524524

525+
it('clears the current user on disk when logged out', asyncHelper((done) => {
526+
ParseUser.enableUnsafeCurrentUser();
527+
ParseUser._clearCache();
528+
Storage._clear();
529+
CoreManager.setRESTController({
530+
request() {
531+
return ParsePromise.as({
532+
objectId: 'uid5',
533+
}, 201);
534+
},
535+
ajax() {}
536+
});
537+
538+
var path = Storage.generatePath('currentUser');
539+
ParseUser.signUp('temporary', 'password').then((u) => {
540+
expect(u.isCurrent()).toBe(true);
541+
expect(Storage.getItem(path)).not.toBe(null);
542+
ParseUser._clearCache();
543+
CoreManager.setRESTController({
544+
request() {
545+
return ParsePromise.as({}, 200);
546+
},
547+
ajax() {}
548+
});
549+
return ParseUser.logOut();
550+
}).then(() => {
551+
ParseUser._clearCache();
552+
expect(ParseUser.current()).toBe(null);
553+
expect(Storage.getItem(path)).toBe(null);
554+
done();
555+
});
556+
}));
557+
525558
it('can get error when recursive _linkWith call fails', asyncHelper((done) => {
526559
CoreManager.setRESTController({
527560
request(method, path, body, options) {

0 commit comments

Comments
 (0)