ci: Fix flaky tests (#1668)

Author: dplewis

integration/test/IdempotencyTest.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const Parse = require('../../node');
+const sleep = require('./sleep');
 
 const Item = Parse.Object.extend('IdempotencyItem');
 const RESTController = Parse.CoreManager.getRESTController();
@@ -47,6 +48,13 @@ describe('Idempotency', () => {
       'Duplicate request'
     );
 
+    const checkJobStatus = async () => {
+      const result = await Parse.Cloud.getJobStatus(jobStatusId);
+      return result && result.get('status') === 'succeeded';
+    };
+    while (!(await checkJobStatus())) {
+      await sleep(100);
+    }
     const jobStatus = await Parse.Cloud.getJobStatus(jobStatusId);
     expect(jobStatus.get('status')).toBe('succeeded');
     expect(jobStatus.get('params').startedBy).toBe('Monty Python');

integration/test/ParseCloudTest.js

@@ -83,17 +83,20 @@ describe('Parse Cloud', () => {
     });
   });
 
-  it('run job', done => {
+  it('run job', async () => {
     const params = { startedBy: 'Monty Python' };
-    Parse.Cloud.startJob('CloudJob1', params)
-      .then(jobStatusId => {
-        return Parse.Cloud.getJobStatus(jobStatusId);
-      })
-      .then(jobStatus => {
-        assert.equal(jobStatus.get('status'), 'succeeded');
-        assert.equal(jobStatus.get('params').startedBy, 'Monty Python');
-        done();
-      });
+    const jobStatusId = await Parse.Cloud.startJob('CloudJob1', params);
+
+    const checkJobStatus = async () => {
+      const result = await Parse.Cloud.getJobStatus(jobStatusId);
+      return result && result.get('status') === 'succeeded';
+    };
+    while (!(await checkJobStatus())) {
+      await sleep(100);
+    }
+    const jobStatus = await Parse.Cloud.getJobStatus(jobStatusId);
+    assert.equal(jobStatus.get('status'), 'succeeded');
+    assert.equal(jobStatus.get('params').startedBy, 'Monty Python');
   });
 
   it('run long job', async () => {

integration/test/ParseObjectTest.js

@@ -1674,6 +1674,7 @@ describe('Parse Object', () => {
     assert.equal(user.createdAt.getTime(), sameUser.createdAt.getTime());
     assert.equal(user.updatedAt.getTime(), sameUser.updatedAt.getTime());
     await Parse.User.logOut();
+    Parse.User.disableUnsafeCurrentUser();
   });
 
   it('can fetchAllIfNeededWithInclude', async () => {
@@ -2014,7 +2015,7 @@ describe('Parse Object', () => {
     assert.equal(user.isDataAvailable(), true);
 
     const query = new Parse.Query(Parse.User);
-    const fetched = await query.get(user.id);
+    const fetched = await query.get(user.id, { useMasterKey: true });
     assert.equal(fetched.isDataAvailable(), true);
   });
 

integration/test/ParseQueryTest.js

@@ -2365,7 +2365,15 @@ describe('Parse Query', () => {
     query.hint('_id_');
     query.explain();
     const explain = await query.find();
-    assert.equal(explain.queryPlanner.winningPlan.inputStage.inputStage.indexName, '_id_');
+    let indexName = '';
+    // https://www.mongodb.com/docs/manual/reference/explain-results/#std-label-queryPlanner
+    const plan = explain.queryPlanner.winningPlan;
+    if (plan.inputStage) {
+      indexName = plan.inputStage.inputStage.indexName;
+    } else {
+      indexName = plan.queryPlan.inputStage.inputStage.indexName;
+    }
+    assert.equal(indexName, '_id_');
   });
 
   it('can query with select on null field', async () => {

integration/test/ParseSchemaTest.js

@@ -26,6 +26,19 @@ const defaultCLPS = {
 };
 
 describe('Schema', () => {
+  beforeEach(async () => {
+    try {
+      const schemas = await Parse.Schema.all();
+      for (const result of schemas) {
+        const schema = new Parse.Schema(result.className);
+        await schema.purge();
+        await schema.delete();
+      }
+    } catch (_) {
+      // Schema not found
+    }
+  });
+
   it('invalid get all no schema', done => {
     Parse.Schema.all()
       .then(() => {})

integration/test/ParseUserTest.js

@@ -185,6 +185,7 @@ describe('Parse User', () => {
   });
 
   it('cannot save non-authed user', done => {
+    Parse.User.enableUnsafeCurrentUser();
     let user = new Parse.User();
     let notAuthed = null;
     user.set({
@@ -220,6 +221,7 @@ describe('Parse User', () => {
   });
 
   it('cannot delete non-authed user', done => {
+    Parse.User.enableUnsafeCurrentUser();
     let user = new Parse.User();
     let notAuthed = null;
     user
@@ -252,6 +254,7 @@ describe('Parse User', () => {
   });
 
   it('cannot saveAll with non-authed user', done => {
+    Parse.User.enableUnsafeCurrentUser();
     let user = new Parse.User();
     let notAuthed = null;
     user
@@ -435,6 +438,7 @@ describe('Parse User', () => {
   });
 
   it('can query for users', done => {
+    Parse.User.enableUnsafeCurrentUser();
     const user = new Parse.User();
     user.set('password', 'asdf');
     user.set('email', '[email protected]');
@@ -457,6 +461,7 @@ describe('Parse User', () => {
   });
 
   it('preserves the session token when querying the current user', done => {
+    Parse.User.enableUnsafeCurrentUser();
     const user = new Parse.User();
     user.set('password', 'asdf');
     user.set('email', '[email protected]');