Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Apr 2, 2025

Pull Request

Issue

Using husky adds significant time when committing code. Per commit can take up to 10 seconds of wait time.

Prettier formats the code which can managed by eslint.
Running prettier then eslint has errors which required --fix. This PR fixes those lint issues so prettier can be removed.

Closes: #2251

Approach

  • Update eslint config to match prettier switch statements indents
  • Refactor reverse order for loops
  • Runs prettier one last time without eslint --fix, basically eslint now has prettier rules without the need for prettier.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Apr 2, 2025

🚀 Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (d706dff) to head (cd8537a).
⚠️ Report is 139 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2550   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6238      6238           
  Branches      1452      1452           
=========================================
  Hits          6238      6238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dplewis dplewis requested a review from a team April 2, 2025 13:45
@mtrezza
Copy link
Member

mtrezza commented Apr 2, 2025

Removing husky? Now I like the sound of that!

@dplewis
Copy link
Member Author

dplewis commented Apr 2, 2025

This is ready to merge

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take a look at the conflicts

@dplewis
Copy link
Member Author

dplewis commented Apr 6, 2025

@mtrezza Done!

@mtrezza mtrezza merged commit c601676 into parse-community:alpha Apr 6, 2025
12 checks passed
@mtrezza
Copy link
Member

mtrezza commented Apr 6, 2025

That would be nice for Parse Server as well!

@dplewis
Copy link
Member Author

dplewis commented Apr 6, 2025

Yep that’s the plan

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.2.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Apr 7, 2025
@dplewis dplewis deleted the lint-check branch April 14, 2025 03:27
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version state:released-alpha Released as alpha version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants