Enforces lint on test (#710)

Author: flovilmart

.eslintrc.json

@@ -4,6 +4,7 @@
         "node": true,
         "browser": true
     },
+    "parser": "babel-eslint",
     "extends": "eslint:recommended",
     "installedESLint": true,
     "parserOptions": {

.gitignore

@@ -5,8 +5,9 @@ PIG/bundles/
 Parse-Dashboard/public/bundles/
 Parse-Dashboard/parse-dashboard-config.json
 npm-debug.log
+.eslintcache
 
 // vim .swp
 *.swp
 .env
-.idea/
+.idea/

Parse-Dashboard/app.js

@@ -31,7 +31,7 @@ function checkIfIconsExistForApps(apps, iconsFolder) {
     var iconName = currentApp.iconName;
     var path = iconsFolder + "/" + iconName;
 
-    fs.stat(path, function(err, stat) {
+    fs.stat(path, function(err) {
       if (err) {
           if ('ENOENT' == err.code) {// file does not exist
               console.warn("Icon with file name: " + iconName +" couldn't be found in icons folder!");

package.json

@@ -47,12 +47,14 @@
   },
   "devDependencies": {
     "babel-core": "~5.8.12",
+    "babel-eslint": "^7.2.3",
     "babel-loader": "~5.3.0",
     "babel-plugin-remove-proptypes": "~1.0.0",
     "babel-polyfill": "^6.7.2",
     "babel-runtime": "~5.8.25",
     "css-loader": "~0.18.0",
     "eslint": "^3.8.1",
+    "eslint-plugin-jest": "^20.0.3",
     "eslint-plugin-react": "^6.4.1",
     "file-loader": "^0.8.5",
     "history": "^2.1.2",
@@ -84,7 +86,8 @@
     "pig": "http-server ./PIG -p 4041 -s & webpack --config webpack/PIG.config.js --progress --watch",
     "build": "NODE_ENV=production webpack --config webpack/production.config.js && webpack --config webpack/PIG.config.js",
     "test": "NODE_PATH=./node_modules jest",
-    "lint": "eslint . --ignore-path .gitignore --ignore-pattern *.test.js",
+    "lint": "eslint . --ignore-path .gitignore --cache",
+    "pretest": "npm run lint",
     "generate": "node scripts/generate.js",
     "prepublish": "webpack --config webpack/publish.config.js",
     "start": "node ./Parse-Dashboard/index.js"

scripts/generate.js

@@ -131,7 +131,7 @@ if (!name) {
     '',
     '  name - The name of the component you wish to create a scaffold for'
   ].join('\n'));
-  return;
+  process.exit(1);
 }
 
 if (name[0] < 'A' || name[0] > 'Z') {
@@ -144,7 +144,7 @@ try {
   // If we don't error, the file exists
   console.log('Error: A component with that name already exists!');
   process.exit(1);
-} catch (e) {}
+} catch (e) {/**/}
 
 try {
   fs.mkdirSync(path.join(rootDir, name));

src/components/BrowserCell/BrowserCell.react.js

@@ -5,15 +5,15 @@
  * This source code is licensed under the license found in the LICENSE file in
  * the root directory of this source tree.
  */
-import { dateStringUTC, isDate } from 'lib/DateUtils';
+import { dateStringUTC }         from 'lib/DateUtils';
 import getFileName               from 'lib/getFileName';
 import Parse                     from 'parse';
 import Pill                      from 'components/Pill/Pill.react';
 import React                     from 'react';
 import styles                    from 'components/BrowserCell/BrowserCell.scss';
 import { unselectable }          from 'stylesheets/base.scss';
 
-let BrowserCell = ({ type, value, hidden, width, current, onSelect, readonly, onEditChange, setRelation,  onPointerClick }) => {
+let BrowserCell = ({ type, value, hidden, width, current, onSelect, onEditChange, setRelation,  onPointerClick }) => {
   let content = value;
   let classes = [styles.cell, unselectable];
   if (hidden) {

src/components/BrowserFilter/BrowserFilter.react.js

@@ -20,7 +20,7 @@ import { List, Map } from 'immutable';
 const BLACKLISTED_FILTERS = [ 'containsAny', 'doesNotContainAny' ];
 
 export default class BrowserFilter extends React.Component {
-  constructor(props) {
+  constructor() {
     super();
 
     this.state = {
@@ -33,7 +33,7 @@ export default class BrowserFilter extends React.Component {
     this.node = ReactDOM.findDOMNode(this);
   }
 
-  componentWillReceiveProps(props, context) {
+  componentWillReceiveProps(props) {
     if (props.schema !== this.props.schema) {
       this.setState({ open: false });
     }
@@ -69,10 +69,11 @@ export default class BrowserFilter extends React.Component {
 
   apply() {
     let formatted = this.state.filters.map((filter) => {
-      let type = this.props.schema[filter.get('field')].type;
+      // TODO: type is unused?
+      /*let type = this.props.schema[filter.get('field')].type;
       if (Filters.Constraints[filter.get('constraint')].hasOwnProperty('field')) {
         type = Filters.Constraints[filter.get('constraint')].field;
-      }
+      }*/
       return filter;
     })
     this.setState({ open: false }, () => {

src/components/CascadingView/CascadingView.react.js

@@ -11,7 +11,7 @@ import React     from 'react';
 import styles    from 'components/CascadingView/CascadingView.scss';
 
 export default class CascadingView extends React.Component {
-  constructor(props) {
+  constructor() {
     super();
     this.state = {
       expanded: false

src/components/ChromeDatePicker/ChromeDatePicker.example.js

@@ -7,10 +7,6 @@
  */
 import ChromeDatePicker from 'components/ChromeDatePicker/ChromeDatePicker.react';
 import { Directions }   from 'lib/Constants';
-import Field            from 'components/Field/Field.react';
-import Fieldset         from 'components/Fieldset/Fieldset.react';
-import Label            from 'components/Label/Label.react';
-import Option           from 'components/Dropdown/Option.react';
 import React            from 'react';
 
 export const component = ChromeDatePicker;

src/components/ChromeDatePicker/ChromeDatePicker.react.js

@@ -9,9 +9,7 @@ import Calendar       from 'components/Calendar/Calendar.react';
 import { Directions } from 'lib/Constants';
 import Icon           from 'components/Icon/Icon.react';
 import {
-  monthDayStringUTC,
-  monthsFrom,
-  daysFrom
+  monthDayStringUTC
 }                     from 'lib/DateUtils';
 import Popover        from 'components/Popover/Popover.react';
 import Position       from 'lib/Position';
@@ -21,7 +19,7 @@ import ReactDOM       from 'react-dom';
 import styles         from 'components/ChromeDatePicker/ChromeDatePicker.scss';
 
 export default class ChromeDatePicker extends React.Component {
-  constructor(props) {
+  constructor() {
     super();
 
     this.state = {
@@ -35,7 +33,7 @@ export default class ChromeDatePicker extends React.Component {
   }
 
   toggle() {
-    this.setState((state) => {
+    this.setState(() => {
       if (this.state.open) {
         return { open: false };
       }