refactor(tests): extract database spy setup into a helper function for beforeFind tests

Author: EmpiDev

spec/CloudCode.spec.js

@@ -201,15 +201,19 @@ describe('Cloud Code', () => {
       done();
     }
   });
-  it('beforeFind can return object without DB operation', async () => {
+  // Helper function to set up database spy
+  function setupDatabaseSpy() {
     const config = Config.get('test');
     const databaseAdapter = config.database.adapter;
-    const findSpy = spyOn(databaseAdapter, 'find').and.callThrough();
+    return spyOn(databaseAdapter, 'find').and.callThrough();
+  }
+
+  it('beforeFind can return object without DB operation', async () => {
+    const findSpy = setupDatabaseSpy();
 
     Parse.Cloud.beforeFind('TestObject', () => {
       return new Parse.Object('TestObject', { foo: 'bar' });
     });
-
     Parse.Cloud.afterFind('TestObject', req => {
       expect(req.objects).toBeDefined();
       expect(req.objects[0].get('foo')).toBe('bar');
@@ -218,21 +222,16 @@ describe('Cloud Code', () => {
     const newObj = await new Parse.Query('TestObject').first();
     expect(newObj.className).toBe('TestObject');
     expect(newObj.toJSON()).toEqual({ foo: 'bar' });
-
     expect(findSpy).not.toHaveBeenCalled();
-
     await newObj.save();
   });
 
   it('beforeFind can return array of objects without DB operation', async () => {
-    const config = Config.get('test');
-    const databaseAdapter = config.database.adapter;
-    const findSpy = spyOn(databaseAdapter, 'find').and.callThrough();
+    const findSpy = setupDatabaseSpy();
 
     Parse.Cloud.beforeFind('TestObject', () => {
       return [new Parse.Object('TestObject', { foo: 'bar' })];
     });
-
     Parse.Cloud.afterFind('TestObject', req => {
       expect(req.objects).toBeDefined();
       expect(req.objects[0].get('foo')).toBe('bar');
@@ -241,64 +240,50 @@ describe('Cloud Code', () => {
     const newObj = await new Parse.Query('TestObject').first();
     expect(newObj.className).toBe('TestObject');
     expect(newObj.toJSON()).toEqual({ foo: 'bar' });
-
     expect(findSpy).not.toHaveBeenCalled();
-
     await newObj.save();
   });
 
   it('beforeFind can return object for get query without DB operation', async () => {
-    const config = Config.get('test');
-    const databaseAdapter = config.database.adapter;
-    const findSpy = spyOn(databaseAdapter, 'find').and.callThrough();
+    const findSpy = setupDatabaseSpy();
 
     Parse.Cloud.beforeFind('TestObject', () => {
       return [new Parse.Object('TestObject', { foo: 'bar' })];
     });
-
     Parse.Cloud.afterFind('TestObject', req => {
       expect(req.objects).toBeDefined();
       expect(req.objects[0].get('foo')).toBe('bar');
     });
 
     const testObj = new Parse.Object('TestObject');
     await testObj.save();
-
     findSpy.calls.reset();
 
     const newObj = await new Parse.Query('TestObject').get(testObj.id);
     expect(newObj.className).toBe('TestObject');
     expect(newObj.toJSON()).toEqual({ foo: 'bar' });
-
     expect(findSpy).not.toHaveBeenCalled();
-
     await newObj.save();
   });
 
   it('beforeFind can return empty array without DB operation', async () => {
-    const config = Config.get('test');
-    const databaseAdapter = config.database.adapter;
-    const findSpy = spyOn(databaseAdapter, 'find').and.callThrough();
+    const findSpy = setupDatabaseSpy();
 
     Parse.Cloud.beforeFind('TestObject', () => {
       return [];
     });
-
     Parse.Cloud.afterFind('TestObject', req => {
       expect(req.objects.length).toBe(0);
     });
 
     const obj = new Parse.Object('TestObject');
     await obj.save();
-
     findSpy.calls.reset();
 
     const newObj = await new Parse.Query('TestObject').first();
     expect(newObj).toBeUndefined();
-
     expect(findSpy).not.toHaveBeenCalled();
   });
-
   const { maybeRunAfterFindTrigger } = require('../lib/triggers');
 
   describe('maybeRunAfterFindTrigger - direct function tests', () => {