Skip to content

Commit a413efd

Browse files
committed
fix: auto review
1 parent a310696 commit a413efd

File tree

3 files changed

+5
-23
lines changed

3 files changed

+5
-23
lines changed

src/SecurityError.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import Parse from 'parse/node';
21
import defaultLogger from './logger';
32

43
/**

src/SharedRest.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
const Parse = require('parse/node');
21
const classesWithMasterOnlyAccess = [
32
'_JobStatus',
43
'_PushStatus',

src/triggers.js

Lines changed: 5 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// triggers.js
22
import Parse from 'parse/node';
33
import { logger } from './logger';
4-
import { createSanitizedError } from './SecurityError';
5-
import defaultLogger from './logger';
64

75
export const Types = {
86
beforeLogin: 'beforeLogin',
@@ -712,24 +710,10 @@ export function maybeRunValidator(request, functionName, auth) {
712710
resolve();
713711
})
714712
.catch(e => {
715-
// Check if this is a security-related validation error
716-
const errorMessage = typeof e === 'string' ? e : (e.message || String(e));
717-
const isSecurityError = errorMessage.includes('Master key is required') || errorMessage.includes('Please login to continue');
718-
719-
let error;
720-
if (isSecurityError) {
721-
// Log detailed error server-side and sanitize for client
722-
defaultLogger.error('Security validation error:', errorMessage);
723-
error = resolveError(e, {
724-
code: Parse.Error.VALIDATION_ERROR,
725-
message: 'Permission denied',
726-
});
727-
} else {
728-
error = resolveError(e, {
729-
code: Parse.Error.VALIDATION_ERROR,
730-
message: 'Validation failed.',
731-
});
732-
}
713+
const error = resolveError(e, {
714+
code: Parse.Error.VALIDATION_ERROR,
715+
message: 'Validation failed.',
716+
});
733717
reject(error);
734718
});
735719
});
@@ -1125,4 +1109,4 @@ export async function maybeRunGlobalConfigTrigger(triggerType, auth, configObjec
11251109
}
11261110
}
11271111
return configObject;
1128-
}
1112+
}

0 commit comments

Comments
 (0)