fix: Added 2 log levels for Testing and followed new ParseServerConfiguration

Author: KrishDave1

spec/ParseUser.spec.js

@@ -4429,13 +4429,27 @@ describe('allowClientClassCreation option', () => {
     // Need to set it back to true to avoid other test fails
     defaultConfiguration.allowClientClassCreation = true;
   });
+});
+
+describe('custom log levels for username already exists error', () => {
+  const logger = require('../lib/logger').logger;
+  let warnSpy, errorSpy, infoSpy;
+
+  beforeEach(() => {
+    warnSpy = spyOn(logger, 'warn').and.callThrough();
+    errorSpy = spyOn(logger, 'error').and.callThrough();
+    infoSpy = spyOn(logger, 'info').and.callThrough();
+  });
 
-  it('should respect custom log level for username already exists error', async () => {
-    const logger = require('../lib/logger').logger;
-    const logSpy = spyOn(logger, 'warn').and.callThrough();
+  afterEach(() => {
+    warnSpy.calls.reset();
+    errorSpy.calls.reset();
+    infoSpy.calls.reset();
+  });
 
+  it('should respect warn log level for username already exists error', async () => {
     await reconfigureServer({
-      logEvents: {
+      logLevels: {
         usernameAlreadyExists: 'warn',
       },
     });
@@ -4453,8 +4467,35 @@ describe('allowClientClassCreation option', () => {
       await duplicateUser.signUp();
     } catch (error) {
       expect(error.code).toBe(Parse.Error.USERNAME_TAKEN);
-      expect(logSpy).toHaveBeenCalled();
-      expect(logger.error).not.toHaveBeenCalled();
+      expect(warnSpy).toHaveBeenCalled();
+      expect(errorSpy).not.toHaveBeenCalled();
+      expect(infoSpy).not.toHaveBeenCalled();
+    }
+  });
+
+  it('should respect info log level for username already exists error', async () => {
+    await reconfigureServer({
+      logLevels: {
+        usernameAlreadyExists: 'info',
+      },
+    });
+
+    const user = new Parse.User();
+    user.setUsername('anotherExistingUser');
+    user.setPassword('password');
+    await user.signUp();
+
+    const duplicateUser = new Parse.User();
+    duplicateUser.setUsername('anotherExistingUser');
+    duplicateUser.setPassword('password');
+
+    try {
+      await duplicateUser.signUp();
+    } catch (error) {
+      expect(error.code).toBe(Parse.Error.USERNAME_TAKEN);
+      expect(infoSpy).toHaveBeenCalled();
+      expect(warnSpy).not.toHaveBeenCalled();
+      expect(errorSpy).not.toHaveBeenCalled();
     }
   });
 });

src/Options/Definitions.js

@@ -1117,4 +1117,10 @@ module.exports.LogLevels = {
       'Log level used by the Cloud Code Triggers `beforeSave`, `beforeDelete`, `beforeFind`, `beforeLogin` on success. Default is `info`.',
     default: 'info',
   },
+  usernameAlreadyExists: {
+    env: 'PARSE_SERVER_LOG_LEVELS_USERNAME_ALREADY_EXISTS',
+    help:
+      'Log level for the username already exists error when trying to sign up.Default is `error`.',
+    default: 'error',
+  },
 };

src/Options/docs.js

@@ -87,7 +87,7 @@ export interface ParseServerOptions {
   verbose: ?boolean;
   /* Sets the level for logs */
   logLevel: ?string;
-  /* Options for customizing log levels for specific events
+  /* (Optional) Overrides the log levels used internally by Parse Server to log events.
   :DEFAULT: {} */
   logLevels: ?LogLevels;
   /* Maximum number of logs to keep. If not set, no logs will be removed. This can be a number of files or number of days. If using days, add 'd' as the suffix. (default: null) */
@@ -635,10 +635,8 @@ export interface LogLevels {
   :DEFAULT: error
   */
   cloudFunctionError: ?string;
-  /* Log level for the "username already exists" error when trying to sign up.
-  Possible values: 'info', 'error', 'verbose', or false to disable logging.
-  If not specified, the default behavior (logging as an error) will be used.
-  :DEFAULT: undefined 
+  /* Log level for the username already exists error when trying to sign up.Default is `error`.
+  :DEFAULT: error
   */
-  usernameAlreadyExists: 'silent' | 'error' | 'info' | 'verbose';
+  usernameAlreadyExists: ?string;
 }

src/Options/index.js

@@ -1557,7 +1557,6 @@ RestWrite.prototype.runDatabaseOperation = function () {
 
         // Quick check, if we were able to infer the duplicated field name
         if (error && error.userInfo && error.userInfo.duplicated_field === 'username') {
-          //Instead of directly throwing the error, we will give error based on logEvent
           const usernameError = new Parse.Error(
             Parse.Error.USERNAME_TAKEN,
             'Account already exists for this username.'