Update mongodb to the latest version 🚀 (#6348)

* fix(package): update mongodb to version 3.5.0

* chore(package): update lockfile package-lock.json

* Fix shutdown issues

Properly retrieves the number of connections

https://docs.mongodb.com/manual/reference/command/serverStatus/#connections

Bump to 3.5.1

* remove fit

Co-authored-by: Diamond Lewis <[email protected]>

Author: greenkeeper[bot]

package-lock.json

@@ -43,7 +43,7 @@
     "lodash": "4.17.15",
     "lru-cache": "5.1.1",
     "mime": "2.4.4",
-    "mongodb": "3.4.1",
+    "mongodb": "3.5.1",
     "node-rsa": "1.0.7",
     "parse": "2.11.0",
     "pg-promise": "10.4.0",

package.json

@@ -61,16 +61,20 @@ describe('GridFSBucket and GridStore interop', () => {
     await expectMissingFile(gfsAdapter, 'myFileName');
   });
 
-  it('handleShutdown, close connection', done => {
+  it('handleShutdown, close connection', async () => {
     const databaseURI = 'mongodb://localhost:27017/parse';
     const gfsAdapter = new GridFSBucketAdapter(databaseURI);
 
-    gfsAdapter._connect().then(db => {
-      expect(db.serverConfig.connections().length > 0).toEqual(true);
-      gfsAdapter.handleShutdown().then(() => {
-        expect(db.serverConfig.connections().length > 0).toEqual(false);
-        done();
-      });
-    });
+    const db = await gfsAdapter._connect();
+    const status = await db.admin().serverStatus();
+    expect(status.connections.current > 0).toEqual(true);
+
+    await gfsAdapter.handleShutdown();
+    try {
+      await db.admin().serverStatus();
+      expect(false).toBe(true);
+    } catch (e) {
+      expect(e.message).toEqual('topology was destroyed');
+    }
   });
 });

spec/GridFSBucketStorageAdapter.spec.js

@@ -97,16 +97,20 @@ describe_only_db('mongo')('GridStoreAdapter', () => {
       .catch(fail);
   });
 
-  it('handleShutdown, close connection', done => {
+  it('handleShutdown, close connection', async () => {
     const databaseURI = 'mongodb://localhost:27017/parse';
     const gridStoreAdapter = new GridStoreAdapter(databaseURI);
 
-    gridStoreAdapter._connect().then(db => {
-      expect(db.serverConfig.connections().length > 0).toEqual(true);
-      gridStoreAdapter.handleShutdown().then(() => {
-        expect(db.serverConfig.connections().length > 0).toEqual(false);
-        done();
-      });
-    });
+    const db = await gridStoreAdapter._connect();
+    const status = await db.admin().serverStatus();
+    expect(status.connections.current > 0).toEqual(true);
+
+    await gridStoreAdapter.handleShutdown();
+    try {
+      await db.admin().serverStatus();
+      expect(false).toBe(true);
+    } catch (e) {
+      expect(e.message).toEqual('topology was destroyed');
+    }
   });
 });

spec/GridStoreAdapter.spec.js

@@ -271,7 +271,7 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
       });
   });
 
-  it('handleShutdown, close connection', done => {
+  it('handleShutdown, close connection', async () => {
     const adapter = new MongoStorageAdapter({ uri: databaseURI });
 
     const schema = {
@@ -282,17 +282,17 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
       },
     };
 
-    adapter.createObject('MyClass', schema, {}).then(() => {
-      expect(adapter.database.serverConfig.connections().length > 0).toEqual(
-        true
-      );
-      adapter.handleShutdown().then(() => {
-        expect(adapter.database.serverConfig.connections().length > 0).toEqual(
-          false
-        );
-        done();
-      });
-    });
+    await adapter.createObject('MyClass', schema, {});
+    const status = await adapter.database.admin().serverStatus();
+    expect(status.connections.current > 0).toEqual(true);
+
+    await adapter.handleShutdown();
+    try {
+      await adapter.database.admin().serverStatus();
+      expect(false).toBe(true);
+    } catch (e) {
+      expect(e.message).toEqual('topology was destroyed');
+    }
   });
 
   it('getClass if exists', async () => {

spec/MongoStorageAdapter.spec.js

@@ -106,7 +106,7 @@ describe('Server Url Checks', () => {
     parseServerProcess.on('close', code => {
       expect(code).toEqual(1);
       expect(stdout).toBeUndefined();
-      expect(stderr).toContain('MongoNetworkError');
+      expect(stderr).toContain('MongoServerSelectionError');
       done();
     });
   });