fix(Adapters): ensure mongodb metadata is passed from the first handshake

Author: RaschidJFR

spec/GridFSBucketStorageAdapter.spec.js

@@ -1,7 +1,6 @@
 const GridFSBucketAdapter = require('../lib/Adapters/Files/GridFSBucketAdapter')
   .GridFSBucketAdapter;
 const { randomString } = require('../lib/cryptoUtils');
-const { MongoClient } = require('mongodb');
 const databaseURI = 'mongodb://localhost:27017/parse';
 const request = require('../lib/request');
 
@@ -479,11 +478,9 @@ describe_only_db('mongo')('GridFSBucket', () => {
 
   it('pass metadata to MongoClient', async () => {
     const pkg = require('../package.json');
-    spyOn(MongoClient.prototype, 'appendMetadata').and.callThrough();
-
     const gfsAdapter = new GridFSBucketAdapter(databaseURI);
     await gfsAdapter._connect();
-    expect(MongoClient.prototype.appendMetadata).toHaveBeenCalledWith({
+    expect(gfsAdapter._client.s.options.driverInfo).toEqual({
       name: 'Parse Server',
       version: pkg.version,
     });

spec/MongoStorageAdapter.spec.js

@@ -451,11 +451,9 @@ describe_only_db('mongo')('MongoStorageAdapter', () => {
 
   it('pass metadata to MongoClient', async () => {
     const pkg = require('../package.json');
-    spyOn(MongoClient.prototype, 'appendMetadata').and.callThrough();
-
     const adapter = new MongoStorageAdapter({ uri: databaseURI });
     await adapter.connect();
-    expect(adapter.client.appendMetadata).toHaveBeenCalledWith({
+    expect(adapter.client.s.options.driverInfo).toEqual({
       name: 'Parse Server',
       version: pkg.version,
     });

src/Adapters/Files/GridFSBucketAdapter.js

@@ -46,12 +46,15 @@ export class GridFSBucketAdapter extends FilesAdapter {
 
   _connect() {
     if (!this._connectionPromise) {
-      this._connectionPromise = MongoClient.connect(this._databaseURI, this._mongoOptions).then(
+      // Add wrapping library metadata.
+      const driverInfo = {
+        name: 'Parse Server',
+        version: pkg.version,
+      };
+      const mongoclient = new MongoClient(this._databaseURI, this._mongoOptions);
+      mongoclient.appendMetadata(driverInfo);
+      this._connectionPromise = mongoclient.connect().then(
         client => {
-          client.appendMetadata?.({
-            name: 'Parse Server',
-            version: pkg.version,
-          });
           this._client = client;
           return client.db(client.s.options.dbName);
         }

src/Adapters/Storage/Mongo/MongoStorageAdapter.js

@@ -180,15 +180,18 @@ export class MongoStorageAdapter implements StorageAdapter {
     // parsing and re-formatting causes the auth value (if there) to get URI
     // encoded
     const encodedUri = formatUrl(parseUrl(this._uri));
-    this.connectionPromise = MongoClient.connect(encodedUri, this._mongoOptions)
+    // Add wrapping library metadata.
+    const driverInfo = {
+      name: 'Parse Server',
+      version: pkg.version,
+    }
+    const mongoclient = new MongoClient(encodedUri, this._mongoOptions)
+    mongoclient.appendMetadata(driverInfo);
+    this.connectionPromise = mongoclient.connect()
       .then(client => {
         // Starting mongoDB 3.0, the MongoClient.connect don't return a DB anymore but a client
         // Fortunately, we can get back the options and use them to select the proper DB.
         // https://github.com/mongodb/node-mongodb-native/blob/2c35d76f08574225b8db02d7bef687123e6bb018/lib/mongo_client.js#L885
-        client.appendMetadata?.({
-          name: 'Parse Server',
-          version: pkg.version,
-        });
         const options = client.s.options;
         const database = client.db(options.dbName);
         if (!database) {