Skip to content

Transaction parameter for saveAll missing #9862

@jonas-db

Description

@jonas-db

New Issue Checklist

Issue Description

It seems the transaction parameter is missing from the node.js server side SDK for saveAll, and potentially others?

Steps to reproduce

client side interface:
https://github.com/parse-community/Parse-SDK-JS/pull/2265/files

  static saveAll(list, options) {
    const saveOptions = ParseObject._getRequestOptions(options);
    return _CoreManager.default.getObjectController().save(list, saveOptions);
  }

...
static _getRequestOptions() {
    ...
    if (hasOwn(options, 'transaction') && typeof options.transaction === 'boolean') {
      requestOptions.transaction = options.transaction;
    }
    ...
}

in server side interface, there is no TransactionOption?

        interface ObjectStatic<T extends Object = Object> {
            ...
            saveAll<T extends readonly Object[]>(list: T, options?: Object.SaveAllOptions): Promise<T>;
            ...
        }

interface SaveAllOptions extends BatchSizeOption, ScopeOptions {}

Can someone verify this, and figure out if this is a small change? @mtrezza ?

Server

  • Parse Server version: latest
  • Operating system: latest
  • Local or remote host (AWS, Azure, Google Cloud, Heroku, Digital Ocean, etc): both

Database

  • System (MongoDB or Postgres): postgresql
  • Database version: latest
  • Local or remote host (MongoDB Atlas, mLab, AWS, Azure, Google Cloud, etc): both

Client

  • SDK (iOS, Android, JavaScript, PHP, Unity, etc): latest
  • SDK version: latest

Logs

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions