Skip to content

Commit 2f56ac7

Browse files
review comments incorporated
1 parent f52bd18 commit 2f56ac7

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

src/event/format/json.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -185,9 +185,9 @@ fn valid_type(data_type: &DataType, value: &Value) -> bool {
185185
DataType::Boolean => value.is_boolean(),
186186
DataType::Int8 | DataType::Int16 | DataType::Int32 | DataType::Int64 => value.is_i64(),
187187
DataType::UInt8 | DataType::UInt16 | DataType::UInt32 | DataType::UInt64 => value.is_u64(),
188-
DataType::Float16 | DataType::Float32 | DataType::Float64 => {
189-
value.is_f64() || value.is_i64() || value.is_u64()
190-
}
188+
DataType::Float16 | DataType::Float32 => value.is_f64(),
189+
// NOTE: All numbers can be ingested as Float64
190+
DataType::Float64 => value.is_number(),
191191
DataType::Utf8 => value.is_string(),
192192
DataType::List(field) => {
193193
let data_type = field.data_type();

src/event/format/mod.rs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -204,20 +204,14 @@ pub fn override_timestamp_fields(
204204
Arc::new(Schema::new(updated_fields))
205205
}
206206

207+
/// All number fields from inferred schema are forced into Float64
207208
pub fn override_num_fields_from_schema(schema: Arc<Schema>) -> Arc<Schema> {
208209
Arc::new(Schema::new(
209210
schema
210211
.fields()
211212
.iter()
212213
.map(|field| {
213-
if field.data_type() == &DataType::Int64
214-
|| field.data_type() == &DataType::Int32
215-
|| field.data_type() == &DataType::Int16
216-
|| field.data_type() == &DataType::Int8
217-
|| field.data_type() == &DataType::Float64
218-
|| field.data_type() == &DataType::Float32
219-
|| field.data_type() == &DataType::Float16
220-
{
214+
if field.data_type().is_numeric() {
221215
Arc::new(Field::new(
222216
field.name(),
223217
DataType::Float64,

0 commit comments

Comments
 (0)