refactor: hot_tier_enabled: bool

Author: Devdutt Shenoi

src/handlers/http/logstream.rs

@@ -631,7 +631,7 @@ pub async fn put_stream_hot_tier(
             .await?;
         let storage = CONFIG.storage().get_object_store();
         let mut stream_metadata = storage.get_object_store_format(&stream_name).await?;
-        stream_metadata.hot_tier_enabled = Some(true);
+        stream_metadata.hot_tier_enabled = true;
         storage
             .put_stream_manifest(&stream_name, &stream_metadata)
             .await?;

src/metadata.rs

@@ -74,7 +74,7 @@ pub struct LogStreamMetadata {
     pub time_partition_limit: Option<NonZeroU32>,
     pub custom_partition: Option<String>,
     pub static_schema_flag: bool,
-    pub hot_tier_enabled: Option<bool>,
+    pub hot_tier_enabled: bool,
     pub stream_type: Option<String>,
     pub log_source: LogSource,
 }
@@ -257,7 +257,7 @@ impl StreamInfo {
         let stream = map
             .get_mut(stream_name)
             .ok_or(MetadataError::StreamMetaNotFound(stream_name.to_string()))?;
-        stream.hot_tier_enabled = Some(enable);
+        stream.hot_tier_enabled = enable;
         Ok(())
     }
 

src/storage/mod.rs

@@ -113,8 +113,8 @@ pub struct ObjectStoreFormat {
         skip_serializing_if = "std::ops::Not::not"
     )]
     pub static_schema_flag: bool,
-    #[serde(skip_serializing_if = "Option::is_none")]
-    pub hot_tier_enabled: Option<bool>,
+    #[serde(default)]
+    pub hot_tier_enabled: bool,
     pub stream_type: Option<String>,
     #[serde(default)]
     pub log_source: LogSource,
@@ -217,7 +217,7 @@ impl Default for ObjectStoreFormat {
             time_partition_limit: None,
             custom_partition: None,
             static_schema_flag: false,
-            hot_tier_enabled: None,
+            hot_tier_enabled: false,
             log_source: LogSource::default(),
         }
     }