perf: to_string is an indirection

Author: Devdutt Shenoi

src/handlers/http/modal/ingest_server.rs

@@ -43,7 +43,6 @@ use crate::storage::PARSEABLE_ROOT_DIRECTORY;
 use crate::sync;
 
 use crate::{handlers::http::base_path, option::CONFIG};
-use actix_web::body::MessageBody;
 use actix_web::web;
 use actix_web::web::resource;
 use actix_web::Scope;
@@ -323,9 +322,7 @@ impl IngestServer {
                     .clone_from(&INGESTOR_META.domain_name);
                 store_data.port.clone_from(&INGESTOR_META.port);
 
-                let resource = serde_json::to_string(&store_data)?
-                    .try_into_bytes()
-                    .map_err(|err| anyhow!(err))?;
+                let resource = Bytes::from(serde_json::to_vec(&store_data)?);
 
                 // if pushing to object store fails propagate the error
                 return store
@@ -334,9 +331,7 @@ impl IngestServer {
                     .map_err(|err| anyhow!(err));
             }
         } else {
-            let resource = serde_json::to_string(&resource)?
-                .try_into_bytes()
-                .map_err(|err| anyhow!(err))?;
+            let resource = Bytes::from(serde_json::to_vec(&resource)?);
 
             store.put_object(&path, resource).await?;
         }

src/handlers/http/modal/mod.rs

@@ -220,6 +220,7 @@ impl IngestorMetadata {
 #[cfg(test)]
 mod test {
     use actix_web::body::MessageBody;
+    use bytes::Bytes;
     use rstest::rstest;
 
     use super::{IngestorMetadata, DEFAULT_VERSION};
@@ -255,10 +256,7 @@ mod test {
             "8002".to_string(),
         );
 
-        let lhs = serde_json::to_string(&im)
-            .unwrap()
-            .try_into_bytes()
-            .unwrap();
+        let lhs = Bytes::from(serde_json::to_vec(&im).unwrap());
         let rhs = br#"{"version":"v3","port":"8000","domain_name":"https://localhost:8000","bucket_name":"somebucket","token":"Basic YWRtaW46YWRtaW4=","ingestor_id":"ingestor_id","flight_port":"8002"}"#
                 .try_into_bytes()
                 .unwrap();

src/migration/metadata_migration.rs

@@ -16,6 +16,7 @@
  *
  */
 
+use bytes::Bytes;
 use rand::distributions::DistString;
 use serde_json::{json, Map, Value as JsonValue};
 
@@ -24,7 +25,6 @@ use crate::{
     option::CONFIG,
     storage::{object_storage::ingestor_metadata_path, staging},
 };
-use actix_web::body::MessageBody;
 
 /*
 v1
@@ -194,9 +194,7 @@ pub async fn migrate_ingester_metadata() -> anyhow::Result<Option<IngestorMetada
             JsonValue::String(CONFIG.parseable.flight_port.to_string()),
         );
     }
-    let bytes = serde_json::to_string(&json)?
-        .try_into_bytes()
-        .map_err(|err| anyhow::anyhow!(err))?;
+    let bytes = Bytes::from(serde_json::to_vec(&json)?);
 
     let resource: IngestorMetadata = serde_json::from_value(json)?;
     staging::put_ingestor_info(resource.clone())?;

src/storage/staging.rs

@@ -462,7 +462,7 @@ pub fn put_ingestor_info(info: IngestorMetadata) -> anyhow::Result<()> {
     let file_name = format!("ingestor.{}.json", info.ingestor_id);
     let file_path = path.join(file_name);
 
-    std::fs::write(file_path, serde_json::to_string(&info)?)?;
+    std::fs::write(file_path, serde_json::to_vec(&info)?)?;
 
     Ok(())
 }