refactor: use bools for flags
#1070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 6, 2025 14:15
NOTE: Only "true" is valid, deserializing anything else is not allowed, if the field doesn't exist only then value is set to false, this is perfectly fine because we are reading from file and this will not impact previous behvaiour as well
de-sh
changed the title
static_schema_flag: boolbools for flags
Pull Request Test Coverage Report for Build 12654063585Details
💛 - Coveralls |
nikhilsinhaparseable
approved these changes
Jan 7, 2025
parmesant
pushed a commit
to parmesant/parseable
that referenced
this pull request
Jan 13, 2025
NOTE: Only "true" is valid, de-serializing anything else is not allowed, if the field doesn't exist only then value is set to false, this is perfectly fine because we are reading from file and this will not impact previous behaviour as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
Only "true" is valid, deserializing anything else is not allowed, if the field doesn't exist only then value is set to false, this is perfectly fine when reading from file and this will not impact previous behaviour since we also serialize only true as "true" and ignore false value(as we have been doing previously).
This improve perf by not having to pass along an entire
String, and being able to make do with a bool, in memory.This PR has: