Gambit 4.9.7

[bkmgit]

The latest release of Gambit 4.9.7 produces code that will compile with GCC 15, older versions will not. Some of the included C libraries may also fail to compile with GCC 15. It may be helpful to update or add compatibility options.

[mgorges]

libraries/libgambit/make.sh uses 4.9.2 and has a warning not to go to 4.9.3. It can be used via changing modules/config/LIBRARIES from containing libgambc liblambdanative to libgambit liblambdanative, which I have used in my own work since early 2019, and it seemed stable and fine. There are other issues like #457, #343, #238 that outline some of our hesitation to change this, as we don't have the capacity to test and subsequently troubleshoot everyone's apps if this update breaks something majorly (most of us work on MacOS, where gcc is a wrapper for clang-17). This is also the reason we never changed the default from 4.7.2.

If there is a patch you suggest that maintains the old version but works for GCC 15, we'd happily review and accept that, but otherwise, this might have to be a wontfix - similarly, as stated before (including #456), we may have reached the end-of-life for LambdaNative. Sorry!

[mgorges]

The actual patch to change the version is two lines in libraries/libgambit/make.sh, plus deleting all the patches in libraries/libgambit - its possible some have to be modified but removing them all would be the best start, but the fallout from it is unknown!

diff --git a/libraries/libgambit/make.sh b/libraries/libgambit/make.sh
index d12d1f8..a48cfe6 100755
--- a/libraries/libgambit/make.sh
+++ b/libraries/libgambit/make.sh
@@ -2,12 +2,13 @@
 # see https://github.com/gambit/gambit/issues/384
 # PKGURL=https://www.iro.umontreal.ca/~gambit/download/gambit/v4.9/source/gambit-v4_9_3.tgz
 # PKGHASH=a3f836f732f367601d0df8bedb8e1324a14c413b
-PKGURL=https://github.com/gambit/gambit/archive/v4.9.2.tar.gz
-PKGHASH=3e0521b84ba4a13cafac04eb6671a13fe10a3b01
+PKGURL=https://github.com/gambit/gambit/archive/v4.9.7.tar.gz
+PKGHASH=3bf9b4d9aadf3499db2e005aea115e7d31453550
 
 package_download $PKGURL $PKGHASH
 
 package_patch
+rmifexists $SYS_PREFIX/include/gambit*.h
 
 case $SYS_PLATFORM in
 ios)

[bkmgit]

Thanks for the hint.

[mgorges]

Actually, the compilation fails for me:

[...]
gcc -DMACOSX -m64 -mmacosx-version-min=10.6 -I/Users/mgorges/Library/Caches/lambdanative/macosx/include -L/Users/mgorges/Library/Caches/lambdanative/macosx/lib -O3 -no-cpp-precomp -Wno-unused -Wno-write-strings -Wdisabled-optimization -fwrapv -fno-strict-aliasing -fno-trapping-math -fno-math-errno -fPIC -fno-common    -I"../include" -c -o os_thread.o -I. -DHAVE_CONFIG_H -D___GAMBITDIR="\"/Users/mgorges/Library/Caches/lambdanative/macosx\"" -D___GAMBITDIR_USERLIB="\"\176/.gambit_userlib\"" -D___GAMBITDIR_INSTLIB="\"\176\176userlib\"" -D___SYS_TYPE_CPU="\"x86_64\"" -D___SYS_TYPE_VENDOR="\"apple\"" -D___SYS_TYPE_OS="\"darwin24.6.0\"" -D___CONFIGURE_COMMAND="\"./configure '--prefix=/Users/mgorges/Library/Caches/lambdanative/macosx' 'CC=gcc -DMACOSX -m64 -mmacosx-version-min=10.6 -I/Users/mgorges/Library/Caches/lambdanative/macosx/include -L/Users/mgorges/Library/Caches/lambdanative/macosx/lib' 'LDFLAGS=-L/Users/mgorges/Library/Caches/lambdanative/macosx/lib' 'CPPFLAGS=-I/Users/mgorges/Library/Caches/lambdanative/macosx/include' 'CPP=' 'CXX=g++ -DMACOSX -m64 -mmacosx-version-min=10.6 -I/Users/mgorges/Library/Caches/lambdanative/macosx/include -L/Users/mgorges/Library/Caches/lambdanative/macosx/lib'"\" -D___OBJ_EXTENSION="\".o\"" -D___EXE_EXTENSION="\"\"" -D___BAT_EXTENSION="\"\"" -D___PRIMAL os_thread.c -D___LIBRARY
clang: warning: argument unused during compilation: '-L/Users/mgorges/Library/Caches/lambdanative/macosx/lib' [-Wunused-command-line-argument]
os_thread.c:992:11: error: call to undeclared function 'hash_mutex_destroy'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  992 |           hash_mutex_destroy (___thread_mod.hash_mutex,
      |           ^
os_thread.c:992:11: note: did you mean 'pthread_mutex_destroy'?
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/pthread.h:381:5: note: 'pthread_mutex_destroy' declared here
  381 | int pthread_mutex_destroy(pthread_mutex_t *);
      |     ^
os_thread.c:992:45: error: no member named 'hash_mutex' in 'struct ___thread_module_struct'
  992 |           hash_mutex_destroy (___thread_mod.hash_mutex,
      |                               ~~~~~~~~~~~~~ ^
2 errors generated.
gmake[5]: *** [makefile:348: os_thread.o] Error 1
gmake[5]: Leaving directory '/Users/mgorges/.lambdanative/tmp_install/gambit-4.9.7/lib'
gmake[4]: *** [makefile:135: lib-phase3] Error 1
gmake[4]: *** Waiting for unfinished jobs....

[bkmgit]

Have a CI workflow pull request:
#467

There are images available for Linux, Windows and Mac. Am most familiar with Linux. It maybe helpful to get that working first as it will enable easier debugging with known reference environments.