Customize log tag of SimpleLogDestination (#313)

Or default to "Partout" if nil. Also, fix an issue with Android log
level mapping, whose fallthrough switch/case was always ending up with
the fault level.

Author: keeshux

Sources/PartoutCore/Logging/SimpleLogDestination.swift

@@ -6,7 +6,10 @@ internal import _PartoutCore_C
 
 /// A ``LoggerDestination`` that prints messages to the default platform logger.
 public struct SimpleLogDestination: LoggerDestination {
-    public init() {
+    private let tag: String?
+
+    public init(tag: String?) {
+        self.tag = tag
     }
 
     public func append(_ level: DebugLog.Level, _ msg: String) {
@@ -18,7 +21,13 @@ public struct SimpleLogDestination: LoggerDestination {
 #else
         let cLevel = pp_log_level(UInt32(level.rawValue))
 #endif
-        pp_log_simple_append(cLevel, msg)
+        if let tag {
+            tag.withCString {
+                pp_log_simple_append($0, cLevel, msg)
+            }
+        } else {
+            pp_log_simple_append(nil, cLevel, msg)
+        }
 #endif
     }
 }

Sources/PartoutCore_C/common.c

@@ -25,25 +25,30 @@ void pp_clog_v(pp_log_category category,
 
 #ifdef __ANDROID__
 #include <android/log.h>
-void pp_log_simple_append(pp_log_level level, const char *_Nonnull message) {
-    const char *log_tag = "Partout";
+void pp_log_simple_append(const char *tag, pp_log_level level, const char *_Nonnull message) {
+    const char *log_tag = tag ? tag : "Partout";
     int android_level = 0;
     switch (level) {
     case PPLogLevelDebug:
         android_level = ANDROID_LOG_VERBOSE;
+        break;
     case PPLogLevelInfo:
         android_level = ANDROID_LOG_DEBUG;
+        break;
     case PPLogLevelNotice:
         android_level = ANDROID_LOG_INFO;
+        break;
     case PPLogLevelError:
         android_level = ANDROID_LOG_WARN;
+        break;
     case PPLogLevelFault:
         android_level = ANDROID_LOG_FATAL;
+        break;
     }
     __android_log_print(android_level, log_tag, "%s", message);
 }
 #else
-void pp_log_simple_append(pp_log_level level, const char *_Nonnull message) {
+void pp_log_simple_append(const char *tag, pp_log_level level, const char *_Nonnull message) {
     FILE *out = NULL;
     switch (level) {
     case PPLogLevelError:
@@ -54,6 +59,6 @@ void pp_log_simple_append(pp_log_level level, const char *_Nonnull message) {
         out = stdout;
         break;
     }
-    fprintf(out, "Partout[%d]: %s\n", level, message);
+    fprintf(out, "%s[%d]: %s\n", tag ? tag : "Partout", level, message);
 }
 #endif

Sources/PartoutCore_C/include/portable/common.h

@@ -33,7 +33,9 @@ void pp_clog_v(pp_log_category category,
                pp_log_level level,
                const char *_Nonnull fmt, ...);
 
-void pp_log_simple_append(pp_log_level level, const char *_Nonnull message);
+void pp_log_simple_append(const char *_Nullable tag,
+                          pp_log_level level,
+                          const char *_Nonnull message);
 
 // Use inline rather than #define to make available to Swift
 

Tests/PartoutCoreTests/Helpers.swift

@@ -9,7 +9,7 @@ import Testing
 
 func setUpLogging() {
     var logger = PartoutLogger.Builder()
-    logger.setDestination(SimpleLogDestination(), for: [.core])
+    logger.setDestination(SimpleLogDestination(tag: nil), for: [.core])
     PartoutLogger.register(logger.build())
 }