fix: resource_me_identity update

Author: fehrnah

ovh/resource_me_identity_user.go

@@ -138,17 +138,15 @@ func resourceMeIdentityUserUpdate(d *schema.ResourceData, meta interface{}) erro
 	description := d.Get("description").(string)
 	email := d.Get("email").(string)
 	group := d.Get("group").(string)
-	login := d.Get("login").(string)
 	params := &MeIdentityUserUpdateOpts{
-		Login:       login,
 		Description: description,
 		Email:       email,
 		Group:       group,
 	}
 	err := config.OVHClient.Put(
 		fmt.Sprintf("/me/identity/user/%s", id),
-		nil,
 		params,
+		nil,
 	)
 	if err != nil {
 		return fmt.Errorf("Unable to update identity user %s:\n\t %q", id, err)

ovh/resource_me_identity_user_test.go

@@ -80,6 +80,34 @@ func TestAccMeIdentityUser_basic(t *testing.T) {
 	})
 }
 
+func TestAccMeIdentityUser_update(t *testing.T) {
+	desc := "Identity user created by Terraform Acc."
+	email := "[email protected]"
+	group := "DEFAULT"
+	login := acctest.RandomWithPrefix(test_prefix)
+	password := base64.StdEncoding.EncodeToString([]byte(acctest.RandomWithPrefix(test_prefix)))
+
+	newEmail := "[email protected]"
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:  func() { testAccPreCheckCredentials(t) },
+		Providers: testAccProviders,
+		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf(testAccMeIdentityUserConfig, desc, email, group, login, password),
+				Check: resource.ComposeTestCheckFunc(
+					checkIdentityUserResourceAttr("ovh_me_identity_user.user_1", desc, email, group, login)...,
+				),
+			},
+			{
+				Config: fmt.Sprintf(testAccMeIdentityUserConfig, desc, newEmail, group, login, password),
+				Check: resource.ComposeTestCheckFunc(
+					checkIdentityUserResourceAttr("ovh_me_identity_user.user_1", desc, newEmail, group, login)...,
+				),
+			}},
+	})
+}
+
 const testAccMeIdentityUserConfig = `
 resource "ovh_me_identity_user" "user_1" {
 	description = "%s"

ovh/types_me.go

@@ -173,7 +173,6 @@ type MeIdentityUserCreateOpts struct {
 }
 
 type MeIdentityUserUpdateOpts struct {
-	Login       string `json:"user"`
 	Description string `json:"description"`
 	Email       string `json:"email"`
 	Group       string `json:"group"`