Merge pull request ovh#389 from matprig/fix/370

desired_nodes to 0 was not taken into account into ovh_cloud_project_kube_nodepool resource

Author: scraly

ovh/helpers/helpers.go

@@ -232,6 +232,7 @@ func GetNilIntPointerFromDataAndNilIfNotPresent(data interface{}, id string) *in
 		if val, ok := resourceData.GetOk(id); ok {
 			return GetNilIntPointer(val)
 		}
+		return GetNilIntPointer(resourceData.Get(id)) // read the 0 value
 	} else if mapData, tok := data.(map[string]interface{}); tok {
 		if val, ok := mapData[id]; ok {
 			return GetNilIntPointer(val)

ovh/resource_cloud_project_kube_nodepool_test.go

@@ -142,6 +142,35 @@ resource "ovh_cloud_project_kube_nodepool" "pool" {
 }
 `
 
+var testAccCloudProjectKubeNodePoolConfigUpdatedScaleToZero = `
+resource "ovh_cloud_project_kube" "cluster" {
+	service_name  = "%s"
+	name          = "%s"
+	region        = "%s"
+	version       = "%s"
+}
+
+resource "ovh_cloud_project_kube_nodepool" "pool" {
+	service_name	= ovh_cloud_project_kube.cluster.service_name
+	kube_id			= ovh_cloud_project_kube.cluster.id
+	name			= ovh_cloud_project_kube.cluster.name
+	flavor_name		= "b2-7"
+	desired_nodes	= 0
+	min_nodes		= 0
+	max_nodes		= 2
+	template {
+		metadata {
+			annotations = {
+				a2 = "av2"
+			}
+			labels = {
+				l2 = "lv2"
+			}
+		}
+	}
+}
+`
+
 func TestAccCloudProjectKubeNodePool(t *testing.T) {
 	name := acctest.RandomWithPrefix(test_prefix)
 	region := os.Getenv("OVH_CLOUD_PROJECT_KUBE_REGION_TEST")
@@ -161,6 +190,13 @@ func TestAccCloudProjectKubeNodePool(t *testing.T) {
 		region,
 		version,
 	)
+	configUpdatedScaleToZero := fmt.Sprintf(
+		testAccCloudProjectKubeNodePoolConfigUpdatedScaleToZero,
+		os.Getenv("OVH_CLOUD_PROJECT_SERVICE_TEST"),
+		name,
+		region,
+		version,
+	)
 
 	resource.Test(t, resource.TestCase{
 		PreCheck: func() {
@@ -209,6 +245,24 @@ func TestAccCloudProjectKubeNodePool(t *testing.T) {
 					resource.TestCheckResourceAttr("ovh_cloud_project_kube_nodepool.pool", "template.0.spec.0.taints.#", "0"),
 				),
 			},
+			{
+				Config: configUpdatedScaleToZero,
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube.cluster", "region", region),
+					resource.TestCheckResourceAttrSet("ovh_cloud_project_kube.cluster", "kubeconfig"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube.cluster", "name", name),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube.cluster", "version", version),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube_nodepool.pool", "name", name),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube_nodepool.pool", "flavor_name", "b2-7"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube_nodepool.pool", "desired_nodes", "0"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube_nodepool.pool", "min_nodes", "0"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube_nodepool.pool", "max_nodes", "2"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube_nodepool.pool", "template.0.metadata.0.annotations.a2", "av2"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube_nodepool.pool", "template.0.metadata.0.finalizers.#", "0"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube_nodepool.pool", "template.0.metadata.0.labels.l2", "lv2"),
+					resource.TestCheckResourceAttr("ovh_cloud_project_kube_nodepool.pool", "template.0.spec.0.taints.#", "0"),
+				),
+			},
 			{
 				ResourceName:      resourceName,
 				ImportState:       true,