Should pgxmock.Rows implement pgx.Rows interface?

[VictorDotZ]

pgx.Rows returned from pgxmock.NewRows is not pgx.Rows and can not be passed into a function that handles pgx.Rows. But the query with WillReturnRows has rows as pgxmock.rowSets and all is fine.

So, should pgxmock.Rows implement pgx.Rows interface, or have you any idea how to test that kind of function without wrapping it by empty queries?

[pashagolub]

Hi, would you please provide a code sample that should work and doesn't right now?

Thanks in advance

[VictorDotZ]

for example, I have a method that handle type Rows interface

func collectPostsFromRows(rows pgx.Rows) (Posts, error) {
	for rows.Next() {
		...
	}
}

and I want to test this method by passing some rows directly. pgxmock provide NewRows that passing into WillReturnRows, so I try do something like this

rows := pgxmock.NewRows([]string{"field_one", "field_two"}).
	AddRow("some value", "other value").
	AddRow("another value", "something")

collectPostsFromRows(rows)

but that's impossible because

cannot use rows (variable of type *pgxmock.Rows) as pgx.Rows value in argument to collectPostsFromRows: *pgxmock.Rows does not implement pgx.Rows

pgxmock/rows.go

Line 180 in 64ed29d

type Rows struct {

and I have to write something like

mock.ExpectQuery("").WillReturnRows(rows)

returnedRows, _ := mock.Query(context.Background(), "")

collectPostsFromRows(returnedRows)

because WillReturnRows make rowSets from Rows, which in turn implement the required interface

pgxmock/expectations.go

Line 373 in 64ed29d

func (e *ExpectedQuery) WillReturnRows(rows ...*Rows) *ExpectedQuery {

but rowSets inaccessible from my code since tha's start with lowercase

pgxmock/rows.go

Line 24 in 64ed29d

type rowSets struct {

that's no critical, but it would be nice to have easy accessible struct for that example

[pashagolub]

Sounds good to me. Please, consider providing a pull request for this feature. I'm in a tight loop at the moment