Bump up codesniffer version and fix reported issues. (cakephp#18240)

Author: ADmad

composer.json

@@ -57,7 +57,7 @@
         "cakephp/validation": "self.version"
     },
     "require-dev": {
-        "cakephp/cakephp-codesniffer": "^5.0",
+        "cakephp/cakephp-codesniffer": "^5.2",
         "http-interop/http-factory-tests": "^2.0",
         "mikey179/vfsstream": "^1.6.10",
         "mockery/mockery": "^1.6",

src/Collection/CollectionTrait.php

@@ -82,7 +82,7 @@ public function each(callable $callback)
      */
     public function filter(?callable $callback = null): CollectionInterface
     {
-        $callback ??= fn ($v) => (bool)$v;
+        $callback ??= fn($v) => (bool)$v;
 
         return new FilterIterator($this->unwrap(), $callback);
     }
@@ -92,17 +92,17 @@ public function filter(?callable $callback = null): CollectionInterface
      */
     public function reject(?callable $callback = null): CollectionInterface
     {
-        $callback ??= fn ($v) => (bool)$v;
+        $callback ??= fn($v) => (bool)$v;
 
-        return new FilterIterator($this->unwrap(), fn ($value, $key, $items) => !$callback($value, $key, $items));
+        return new FilterIterator($this->unwrap(), fn($value, $key, $items) => !$callback($value, $key, $items));
     }
 
     /**
      * @inheritDoc
      */
     public function unique(?callable $callback = null): CollectionInterface
     {
-        $callback ??= fn ($v) => $v;
+        $callback ??= fn($v) => $v;
 
         return new UniqueIterator($this->unwrap(), $callback);
     }
@@ -373,8 +373,8 @@ public function countBy(callable|string $path): CollectionInterface
     {
         $callback = $this->_propertyExtractor($path);
 
-        $mapper = fn ($value, $key, MapReduce $mr) => $mr->emitIntermediate($value, $callback($value));
-        $reducer = fn ($values, $key, MapReduce $mr) => $mr->emit(count($values), $key);
+        $mapper = fn($value, $key, MapReduce $mr) => $mr->emitIntermediate($value, $callback($value));
+        $reducer = fn($values, $key, MapReduce $mr) => $mr->emit(count($values), $key);
 
         return $this->newCollection(new MapReduce($this->unwrap(), $mapper, $reducer));
     }
@@ -877,7 +877,7 @@ public function stopWhen(callable|array $condition): CollectionInterface
      */
     public function unfold(?callable $callback = null): CollectionInterface
     {
-        $callback ??= fn ($v) => $v;
+        $callback ??= fn($v) => $v;
 
         return $this->newCollection(
             new RecursiveIteratorIterator(

src/Collection/ExtractTrait.php

@@ -43,7 +43,7 @@ protected function _propertyExtractor(callable|string $path): Closure
         $parts = explode('.', $path);
 
         if (str_contains($path, '{*}')) {
-            return fn ($element) => $this->_extract($element, $parts);
+            return fn($element) => $this->_extract($element, $parts);
         }
 
         return function ($element) use ($parts) {

src/Command/Helper/BannerHelper.php

@@ -74,7 +74,7 @@ public function withStyle(string $style)
      */
     public function output(array $args): void
     {
-        $lengths = array_map(fn ($i) => mb_strlen($i), $args);
+        $lengths = array_map(fn($i) => mb_strlen($i), $args);
         $maxLength = max($lengths);
         $bannerLength = $maxLength + $this->padding * 2;
         $start = "<{$this->style}>";

src/Database/Connection.php

@@ -265,7 +265,7 @@ public function getDriver(string $role = self::ROLE_WRITE): Driver
      */
     public function execute(string $sql, array $params = [], array $types = []): StatementInterface
     {
-        return $this->getDisconnectRetry()->run(fn () => $this->getDriver()->execute($sql, $params, $types));
+        return $this->getDisconnectRetry()->run(fn() => $this->getDriver()->execute($sql, $params, $types));
     }
 
     /**
@@ -277,7 +277,7 @@ public function execute(string $sql, array $params = [], array $types = []): Sta
      */
     public function run(Query $query): StatementInterface
     {
-        return $this->getDisconnectRetry()->run(fn () => $this->getDriver($query->getConnectionRole())->run($query));
+        return $this->getDisconnectRetry()->run(fn() => $this->getDriver($query->getConnectionRole())->run($query));
     }
 
     /**

src/Database/Driver.php

@@ -187,7 +187,7 @@ public function config(): array
      */
     protected function createPdo(string $dsn, array $config): PDO
     {
-        $action = fn (): PDO => new PDO(
+        $action = fn(): PDO => new PDO(
             $dsn,
             $config['username'] ?: null,
             $config['password'] ?: null,

src/Database/Expression/CommonTableExpression.php

@@ -187,7 +187,7 @@ public function sql(ValueBinder $binder): string
     {
         $fields = '';
         if ($this->fields) {
-            $expressions = array_map(fn (IdentifierExpression $e) => $e->sql($binder), $this->fields);
+            $expressions = array_map(fn(IdentifierExpression $e) => $e->sql($binder), $this->fields);
             $fields = sprintf('(%s)', implode(', ', $expressions));
         }
 

src/Database/Query.php

@@ -1607,7 +1607,7 @@ public function clause(string $name): mixed
     {
         if (!array_key_exists($name, $this->_parts)) {
             $clauses = array_keys($this->_parts);
-            array_walk($clauses, fn (&$x) => $x = "`{$x}`");
+            array_walk($clauses, fn(&$x) => $x = "`{$x}`");
             $clauses = implode(', ', $clauses);
             throw new InvalidArgumentException(sprintf(
                 'The `%s` clause is not defined. Valid clauses are: %s.',
@@ -1660,7 +1660,7 @@ protected function _expressionsVisitor(mixed $expression, Closure $callback): vo
         }
 
         if ($expression instanceof ExpressionInterface) {
-            $expression->traverse(fn ($exp) => $this->_expressionsVisitor($exp, $callback));
+            $expression->traverse(fn($exp) => $this->_expressionsVisitor($exp, $callback));
 
             if (!$expression instanceof self) {
                 $callback($expression);

src/Database/Schema/SqliteSchemaDialect.php

@@ -388,7 +388,7 @@ public function convertIndexDescription(TableSchema $schema, array $row): void
                     $columnsPattern = implode(
                         '\s*,\s*',
                         array_map(
-                            fn ($column) => '(?:' . $this->possiblyQuotedIdentifierRegex($column) . ')',
+                            fn($column) => '(?:' . $this->possiblyQuotedIdentifierRegex($column) . ')',
                             $columns,
                         ),
                     );

src/Datasource/EntityTrait.php

@@ -1289,7 +1289,7 @@ public function setInvalidField(string $field, mixed $value)
     public function setAccess(array|string $field, bool $set)
     {
         if ($field === '*') {
-            $this->_accessible = array_map(fn ($p) => $set, $this->_accessible);
+            $this->_accessible = array_map(fn($p) => $set, $this->_accessible);
             $this->_accessible['*'] = $set;
 
             return $this;