Skip to content

Commit 24e2626

Browse files
joegoldman2joegoldman2
authored
Remove AuthenticatorSelection extension (#435)
1 parent ec12c81 commit 24e2626

File tree

4 files changed

+0
-37
lines changed

4 files changed

+0
-37
lines changed

‎Src/Fido2.Models/Objects/AuthenticationExtensionsClientInputs.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,6 @@ public sealed class AuthenticationExtensionsClientInputs
2222
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
2323
public string AppID { get; set; }
2424

25-
/// <summary>
26-
/// This extension allows a WebAuthn Relying Party to guide the selection of the authenticator that will be leveraged when creating the credential. It is intended primarily for Relying Parties that wish to tightly control the experience around credential creation.
27-
/// https://www.w3.org/TR/webauthn/#sctn-authenticator-selection-extension
28-
/// </summary>
29-
[JsonPropertyName("authnSel")]
30-
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
31-
public byte[][] AuthenticatorSelection { get; set; }
32-
3325
/// <summary>
3426
/// This extension enables the WebAuthn Relying Party to determine which extensions the authenticator supports.
3527
/// https://www.w3.org/TR/webauthn/#sctn-supported-extensions-extension

‎Src/Fido2.Models/Objects/AuthenticationExtensionsClientOutputs.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,6 @@ public class AuthenticationExtensionsClientOutputs
2020
[JsonPropertyName("appid")]
2121
public bool AppID { get; set; }
2222

23-
/// <summary>
24-
/// This extension allows a WebAuthn Relying Party to guide the selection of the authenticator that will be leveraged when creating the credential. It is intended primarily for Relying Parties that wish to tightly control the experience around credential creation.
25-
/// https://www.w3.org/TR/webauthn/#sctn-authenticator-selection-extension
26-
/// </summary>
27-
[JsonPropertyName("authnSel")]
28-
public bool AuthenticatorSelection { get; set; }
29-
3023
/// <summary>
3124
/// This extension enables the WebAuthn Relying Party to determine which extensions the authenticator supports.
3225
/// https://www.w3.org/TR/webauthn/#sctn-supported-extensions-extension

‎Test/AuthenticatorResponse.cs

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,6 @@ public void TestAuthenticatorAttestationRawResponse()
256256
Extensions = new AuthenticationExtensionsClientOutputs
257257
{
258258
AppID = true,
259-
AuthenticatorSelection = true,
260259
Extensions = new string[] { "foo", "bar" },
261260
Example = "test",
262261
UserVerificationMethod = new ulong[][]
@@ -283,7 +282,6 @@ public void TestAuthenticatorAttestationRawResponse()
283282
Assert.Equal(new byte[] { 0xa0 }, rawResponse.Response.AttestationObject);
284283
Assert.Equal(clientDataJson, rawResponse.Response.ClientDataJson);
285284
Assert.True(rawResponse.Extensions.AppID);
286-
Assert.True(rawResponse.Extensions.AuthenticatorSelection);
287285
Assert.Equal(new string[] { "foo", "bar" }, rawResponse.Extensions.Extensions);
288286
Assert.Equal("test", rawResponse.Extensions.Example);
289287
Assert.Equal((ulong)4, rawResponse.Extensions.UserVerificationMethod[0][0]);
@@ -1239,7 +1237,6 @@ public void TestAuthenticatorAssertionRawResponse()
12391237
Extensions = new AuthenticationExtensionsClientOutputs
12401238
{
12411239
AppID = true,
1242-
AuthenticatorSelection = true,
12431240
Extensions = new string[] { "foo", "bar" },
12441241
Example = "test",
12451242
UserVerificationMethod = new ulong[][]
@@ -1268,7 +1265,6 @@ public void TestAuthenticatorAssertionRawResponse()
12681265
Assert.Equal(clientDataJson, assertionResponse.Response.ClientDataJson);
12691266
Assert.Equal(new byte[] { 0xf1, 0xd0 }, assertionResponse.Response.UserHandle);
12701267
Assert.True(assertionResponse.Extensions.AppID);
1271-
Assert.True(assertionResponse.Extensions.AuthenticatorSelection);
12721268
Assert.Equal(new string[] { "foo", "bar" }, assertionResponse.Extensions.Extensions);
12731269
Assert.Equal("test", assertionResponse.Extensions.Example);
12741270
Assert.Equal((ulong)4, assertionResponse.Extensions.UserVerificationMethod[0][0]);
@@ -1317,7 +1313,6 @@ public void TestAuthenticatorAssertionTypeNotPublicKey()
13171313
Extensions = new AuthenticationExtensionsClientOutputs
13181314
{
13191315
AppID = false,
1320-
AuthenticatorSelection = true,
13211316
Extensions = new string[] { "foo", "bar" },
13221317
Example = "test",
13231318
UserVerificationMethod = new ulong[][]
@@ -1386,7 +1381,6 @@ public void TestAuthenticatorAssertionIdMissing()
13861381
Extensions = new AuthenticationExtensionsClientOutputs
13871382
{
13881383
AppID = false,
1389-
AuthenticatorSelection = true,
13901384
Extensions = new string[] { "foo", "bar" },
13911385
Example = "test",
13921386
UserVerificationMethod = new ulong[][]
@@ -1456,7 +1450,6 @@ public void TestAuthenticatorAssertionRawIdMissing()
14561450
Extensions = new AuthenticationExtensionsClientOutputs()
14571451
{
14581452
AppID = false,
1459-
AuthenticatorSelection = true,
14601453
Extensions = new string[] { "foo", "bar" },
14611454
Example = "test",
14621455
UserVerificationMethod = new ulong[][]
@@ -1526,7 +1519,6 @@ public void TestAuthenticatorAssertionUserHandleEmpty()
15261519
Extensions = new AuthenticationExtensionsClientOutputs()
15271520
{
15281521
AppID = false,
1529-
AuthenticatorSelection = true,
15301522
Extensions = new string[] { "foo", "bar" },
15311523
Example = "test",
15321524
UserVerificationMethod = new ulong[][]
@@ -1596,7 +1588,6 @@ public void TestAuthenticatorAssertionUserHandleNotOwnerOfPublicKey()
15961588
Extensions = new AuthenticationExtensionsClientOutputs()
15971589
{
15981590
AppID = false,
1599-
AuthenticatorSelection = true,
16001591
Extensions = new string[] { "foo", "bar" },
16011592
Example = "test",
16021593
UserVerificationMethod = new ulong[][]
@@ -1666,7 +1657,6 @@ public void TestAuthenticatorAssertionTypeNotWebAuthnGet()
16661657
Extensions = new AuthenticationExtensionsClientOutputs
16671658
{
16681659
AppID = false,
1669-
AuthenticatorSelection = true,
16701660
Extensions = new string[] { "foo", "bar" },
16711661
Example = "test",
16721662
UserVerificationMethod = new ulong[][]
@@ -1738,7 +1728,6 @@ public void TestAuthenticatorAssertionAppId()
17381728
Extensions = new AuthenticationExtensionsClientOutputs()
17391729
{
17401730
AppID = true,
1741-
AuthenticatorSelection = true,
17421731
Extensions = new string[] { "foo", "bar" },
17431732
Example = "test",
17441733
UserVerificationMethod = new ulong[][]
@@ -1809,7 +1798,6 @@ public void TestAuthenticatorAssertionInvalidRpIdHash()
18091798
Extensions = new AuthenticationExtensionsClientOutputs()
18101799
{
18111800
AppID = false,
1812-
AuthenticatorSelection = true,
18131801
Extensions = new string[] { "foo", "bar" },
18141802
Example = "test",
18151803
UserVerificationMethod = new ulong[][]
@@ -1881,7 +1869,6 @@ public void TestAuthenticatorAssertionUPRequirementNotMet()
18811869
Extensions = new AuthenticationExtensionsClientOutputs
18821870
{
18831871
AppID = false,
1884-
AuthenticatorSelection = true,
18851872
Extensions = new string[] { "foo", "bar" },
18861873
Example = "test",
18871874
UserVerificationMethod = new ulong[][]
@@ -1952,7 +1939,6 @@ public void TestAuthenticatorAssertionUVPolicyNotMet()
19521939
Extensions = new AuthenticationExtensionsClientOutputs
19531940
{
19541941
AppID = false,
1955-
AuthenticatorSelection = true,
19561942
Extensions = new string[] { "foo", "bar" },
19571943
Example = "test",
19581944
UserVerificationMethod = new ulong[][]
@@ -2021,7 +2007,6 @@ public void TestAuthenticatorAssertionBEPolicyRequired()
20212007
Extensions = new AuthenticationExtensionsClientOutputs()
20222008
{
20232009
AppID = false,
2024-
AuthenticatorSelection = true,
20252010
Extensions = new string[] { "foo", "bar" },
20262011
Example = "test",
20272012
UserVerificationMethod = new ulong[][]
@@ -2091,7 +2076,6 @@ public void TestAuthenticatorAssertionBEPolicyDisallow()
20912076
Extensions = new AuthenticationExtensionsClientOutputs
20922077
{
20932078
AppID = false,
2094-
AuthenticatorSelection = true,
20952079
Extensions = new string[] { "foo", "bar" },
20962080
Example = "test",
20972081
UserVerificationMethod = new ulong[][]
@@ -2161,7 +2145,6 @@ public void TestAuthenticatorAssertionBSPolicyRequired()
21612145
Extensions = new AuthenticationExtensionsClientOutputs
21622146
{
21632147
AppID = false,
2164-
AuthenticatorSelection = true,
21652148
Extensions = new string[] { "foo", "bar" },
21662149
Example = "test",
21672150
UserVerificationMethod = new ulong[][]
@@ -2231,7 +2214,6 @@ public void TestAuthenticatorAssertionBSPolicyDisallow()
22312214
Extensions = new AuthenticationExtensionsClientOutputs
22322215
{
22332216
AppID = false,
2234-
AuthenticatorSelection = true,
22352217
Extensions = new string[] { "foo", "bar" },
22362218
Example = "test",
22372219
UserVerificationMethod = new ulong[][]
@@ -2302,7 +2284,6 @@ public void TestAuthenticatorAssertionStoredPublicKeyMissing()
23022284
Extensions = new AuthenticationExtensionsClientOutputs()
23032285
{
23042286
AppID = false,
2305-
AuthenticatorSelection = true,
23062287
Extensions = new string[] { "foo", "bar" },
23072288
Example = "test",
23082289
UserVerificationMethod = new ulong[][]
@@ -2372,7 +2353,6 @@ public void TestAuthenticatorAssertionInvalidSignature()
23722353
Extensions = new AuthenticationExtensionsClientOutputs()
23732354
{
23742355
AppID = false,
2375-
AuthenticatorSelection = true,
23762356
Extensions = new string[] { "foo", "bar" },
23772357
Example = "test",
23782358
UserVerificationMethod = new ulong[][]
@@ -2449,7 +2429,6 @@ public void TestAuthenticatorAssertionSignCountSignature()
24492429
Extensions = new AuthenticationExtensionsClientOutputs()
24502430
{
24512431
AppID = false,
2452-
AuthenticatorSelection = true,
24532432
Extensions = new string[] { "foo", "bar" },
24542433
Example = "test",
24552434
UserVerificationMethod = new ulong[][]

‎Test/Fido2Tests.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,6 @@ public Attestation()
167167
Extensions = new AuthenticationExtensionsClientOutputs()
168168
{
169169
AppID = true,
170-
AuthenticatorSelection = true,
171170
Extensions = new string[] { "foo", "bar" },
172171
Example = "test",
173172
UserVerificationMethod = new ulong[][]

0 commit comments

Comments
 (0)