Skip to content

Commit 555e95c

Browse files
j-rafiquej-rafique
authored
Merge pull request #835 from pastelnetwork/PSL-1138_removeDebugLogs
[PSL-1138] remove debug logs from storage & healthcheck challenges
2 parents 0a1632c + c37534a commit 555e95c

14 files changed

+151
-242
lines changed

‎supernode/services/healthcheckchallenge/broadcast_healthcheck_challenge_metrics.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616

1717
// BroadcastHealthCheckChallengeMetrics worker broadcasts the metrics to the entire network
1818
func (task *HCTask) BroadcastHealthCheckChallengeMetrics(ctx context.Context) error {
19-
log.WithContext(ctx).Infoln("BroadcastHealthCheckChallengeMetrics has been invoked")
19+
log.WithContext(ctx).Debug("BroadcastHealthCheckChallengeMetrics has been invoked")
2020

2121
pingInfos, err := task.historyDB.GetAllPingInfoForOnlineNodes()
2222
if err != nil {

‎supernode/services/healthcheckchallenge/broadcast_healthcheck_challenge_result.go‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ import (
1515
func (task *HCTask) BroadcastHealthCheckChallengeResult(ctx context.Context, incomingBroadcastMsg types.BroadcastHealthCheckMessage) (types.HealthCheckMessage, error) {
1616
log.WithContext(ctx).WithField("method", "BroadcastHealthCheckChallengeResult").
1717
WithField("challengeID", incomingBroadcastMsg.ChallengeID).
18-
Info("Start processing broadcasting message") // Incoming challenge message validation
18+
Debug("Start processing broadcasting message") // Incoming challenge message validation
1919

2020
if err := task.storeBroadcastChallengeMsg(ctx, incomingBroadcastMsg); err != nil {
2121
log.WithContext(ctx).WithError(err).Error("error storing broadcast message")
2222
}
2323
log.WithContext(ctx).WithField("challenge_id", incomingBroadcastMsg.ChallengeID).
24-
Info("Broadcast message has been stored")
24+
Debug("Broadcast message has been stored")
2525

2626
return types.HealthCheckMessage{}, nil
2727
}

supernode/services/healthcheckchallenge/process_broadcast_storage_challenge_metrics.go renamed to supernode/services/healthcheckchallenge/process_broadcast_hc_challenge_metrics.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import (
1111
func (task *HCTask) ProcessBroadcastHealthCheckChallengeMetrics(ctx context.Context, req types.ProcessBroadcastHealthCheckChallengeMetricsRequest) error {
1212
logger := log.WithContext(ctx).WithField("sender_id", req.SenderID)
1313

14-
logger.Info("healthcheck-challenge metrics broadcast msg has been received")
14+
logger.Debug("healthcheck-challenge metrics broadcast msg has been received")
1515

1616
metrics, err := task.decompressData(req.Data)
1717
if err != nil {
@@ -24,6 +24,6 @@ func (task *HCTask) ProcessBroadcastHealthCheckChallengeMetrics(ctx context.Cont
2424
return err
2525
}
2626

27-
logger.Info("hc metrics have been stored")
27+
logger.Debug("hc metrics have been stored")
2828
return nil
2929
}

‎supernode/services/healthcheckchallenge/process_healthcheck_challenge.go‎

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,28 +25,27 @@ func (task *HCTask) ProcessHealthCheckChallenge(ctx context.Context, incomingCha
2525
logger.WithError(err).Error("Error validating healthcheck challenge incoming data: ")
2626
return nil, err
2727
}
28-
logger.Info("incoming health-check challenge validated")
28+
logger.Debug("incoming health-check challenge validated")
2929

3030
//if the message is received by one of the observer then save the challenge message, lock the file & return
3131
if task.isObserver(incomingChallengeMessage.Data.Observers) {
3232
logger.WithField("node_id", task.nodeID).WithField("hc_challenge_id",
3333
incomingChallengeMessage.ChallengeID)
3434

3535
if err := task.StoreChallengeMessage(ctx, incomingChallengeMessage); err != nil {
36-
logger.
37-
WithField("node_id", task.nodeID).
36+
logger.WithField("node_id", task.nodeID).
3837
WithError(err).
3938
Error("error storing health-check challenge message")
4039
}
41-
logger.Info("health-check challenge message has been stored by the observer")
40+
logger.Debug("health-check challenge message has been stored by the observer")
4241

4342
return nil, nil
4443
}
4544

4645
//if not the challenge recipient, should return, otherwise proceed
4746
if task.nodeID != incomingChallengeMessage.Data.RecipientID {
4847
logger.WithField("node_id", task.nodeID).
49-
Info("current node is not the health-check challenge recipient to process challenge message")
48+
Debug("current node is not the health-check challenge recipient to process challenge message")
5049

5150
return nil, nil
5251
}
@@ -56,7 +55,7 @@ func (task *HCTask) ProcessHealthCheckChallenge(ctx context.Context, incomingCha
5655
WithError(err).
5756
Error("error storing health-check challenge message")
5857
}
59-
logger.Info("health-check challenge message has been stored by the recipient")
58+
logger.Debug("health-check challenge message has been stored by the recipient")
6059

6160
blockNumChallengeRespondedTo, err := task.SuperNodeService.PastelClient.GetBlockCount(ctx)
6261
if err != nil {
@@ -182,18 +181,18 @@ func (task *HCTask) sendVerifyHealthCheckChallenge(ctx context.Context, challeng
182181
return
183182
}
184183

185-
logger.Info("response message has been sent")
184+
logger.Debug("response message has been sent")
186185
}()
187186
}
188187
wg.Wait()
189-
logger.WithField("challenge_id", challengeMessage.ChallengeID).Info("response message has been sent to observers")
188+
logger.WithField("challenge_id", challengeMessage.ChallengeID).Debug("response message has been sent to observers")
190189

191190
if err := task.SendMessage(ctx, &msg, challengerNode.ExtAddress); err != nil {
192191
logger.WithField("node_address", challengerNode.ExtAddress).WithError(err).Error("error sending response message to challenger for verification")
193192
return err
194193
}
195194
logger.WithField("hc_challenge_id", challengeMessage.ChallengeID).
196-
WithField("node_address", challengerNode.ExtAddress).Info("response message has been sent to challenger")
195+
WithField("node_address", challengerNode.ExtAddress).Debug("response message has been sent to challenger")
197196

198197
return nil
199198
}

‎supernode/services/healthcheckchallenge/verify_evaluation_result.go‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,13 @@ func (task *HCTask) VerifyHealthCheckEvaluationResult(ctx context.Context, incom
2929
if err := task.validateVerifyingHealthCheckChallengeEvaluationReport(ctx, incomingEvaluationResult); err != nil {
3030
return types.HealthCheckMessage{}, err
3131
}
32-
logger.Info("Incoming evaluation signature validated")
32+
logger.Debug("Incoming evaluation signature validated")
3333

3434
receivedAt := time.Now().UTC()
3535

3636
//if observers then save the evaluation message
3737
if task.isObserver(incomingEvaluationResult.Data.Observers) {
38-
logger := logger.WithField("node_id", task.nodeID)
38+
logger.WithField("node_id", task.nodeID)
3939

4040
if err := task.StoreChallengeMessage(ctx, incomingEvaluationResult); err != nil {
4141
logger.
@@ -44,9 +44,9 @@ func (task *HCTask) VerifyHealthCheckEvaluationResult(ctx context.Context, incom
4444
Error("error storing challenge message")
4545
}
4646

47-
logger.Info("health-check challenge evaluation report by challenger has been stored by the observer")
47+
logger.Debug("health-check challenge evaluation report by challenger has been stored by the observer")
4848
} else {
49-
logger.WithField("node_id", task.nodeID).Info("not the observer to process evaluation report")
49+
logger.WithField("node_id", task.nodeID).Debug("not the observer to process evaluation report")
5050
return types.HealthCheckMessage{}, nil
5151
}
5252

@@ -124,11 +124,11 @@ func (task *HCTask) VerifyHealthCheckEvaluationResult(ctx context.Context, incom
124124
logger.WithError(err).Error("error signing evaluation response")
125125
}
126126
evaluationResultResponse.SenderSignature = signature
127-
logger.Info("evaluation report has been signed")
127+
128128
if err := task.StoreChallengeMessage(ctx, evaluationResultResponse); err != nil {
129129
logger.WithError(err).Error("error storing evaluation response ")
130130
}
131-
logger.Info("evaluation report has been stored")
131+
logger.WithField("node_id", task.nodeID).Info("evaluation report has been evaluated by observer")
132132

133133
return evaluationResultResponse, nil
134134
}

‎supernode/services/healthcheckchallenge/verify_healthcheck_challenge.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func (task *HCTask) VerifyHealthCheckChallenge(ctx context.Context, incomingResp
4747
//if not the challenger, should return, otherwise proceed
4848
if task.nodeID != incomingResponseMessage.Data.ChallengerID {
4949
logger.WithField("node_id", task.nodeID).
50-
Info("current node is not the health-check challenger to verify the response message")
50+
Debug("current node is not the health-check challenger to verify the response message")
5151

5252
return nil, nil
5353
}
@@ -59,7 +59,7 @@ func (task *HCTask) VerifyHealthCheckChallenge(ctx context.Context, incomingResp
5959
WithError(err).
6060
Error("error storing response message")
6161
} else {
62-
logger.Info("response health-check message has been stored by the challenger")
62+
logger.Debug("response health-check message has been stored by the challenger")
6363
}
6464

6565
// Verifies the challenger's time against the recipient's time.
@@ -80,7 +80,7 @@ func (task *HCTask) VerifyHealthCheckChallenge(ctx context.Context, incomingResp
8080

8181
blockNumChallengeSent := incomingResponseMessage.Data.Challenge.Block
8282
blocksVerifyStorageChallengeInBlocks := blockNumChallengeVerified - blockNumChallengeSent
83-
logger.WithField("no_of_blocks", blocksVerifyStorageChallengeInBlocks).Info("No of blocks from the time HC challenge being sent and verified")
83+
logger.WithField("no_of_blocks", blocksVerifyStorageChallengeInBlocks).Debug("No of blocks from the time HC challenge being sent and verified")
8484

8585
evaluationMessage := types.HealthCheckMessage{
8686
MessageType: types.HealthCheckEvaluationMessageType,

‎supernode/services/storagechallenge/broadcast_storage_challenge_metrics.go‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import (
1616

1717
// BroadcastStorageChallengeMetrics worker broadcasts the metrics to the entire network
1818
func (task *SCTask) BroadcastStorageChallengeMetrics(ctx context.Context) error {
19-
log.WithContext(ctx).Infoln("BroadcastStorageChallengeMetrics has been invoked")
19+
log.WithContext(ctx).Debug("BroadcastStorageChallengeMetrics has been invoked")
2020

2121
pingInfos, err := task.historyDB.GetAllPingInfoForOnlineNodes()
2222
if err != nil {

‎supernode/services/storagechallenge/broadcast_storage_challenge_result.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ import (
1515
func (task *SCTask) BroadcastStorageChallengeResult(ctx context.Context, incomingBroadcastMsg types.BroadcastMessage) (types.Message, error) {
1616
log.WithContext(ctx).WithField("method", "BroadcastStorageChallengeResult").
1717
WithField("challengeID", incomingBroadcastMsg.ChallengeID).
18-
Info("Start processing broadcasting message") // Incoming challenge message validation
18+
Debug("Start processing broadcasting message") // Incoming challenge message validation
1919

2020
if err := task.storeBroadcastChallengeMsg(ctx, incomingBroadcastMsg); err != nil {
2121
log.WithContext(ctx).WithError(err).Error("error storing broadcast message")
2222
}
2323
log.WithContext(ctx).WithField("challenge_id", incomingBroadcastMsg.ChallengeID).
24-
Info("Broadcast message has been stored")
24+
Debug("Broadcast message has been stored")
2525

2626
return types.Message{}, nil
2727
}
@@ -52,7 +52,7 @@ func (task *SCTask) storeBroadcastChallengeMsg(ctx context.Context, msg types.Br
5252
}
5353

5454
if store != nil {
55-
log.WithContext(ctx).Info("store")
55+
log.WithContext(ctx).Debug("store")
5656
broadcastMsgLog := types.BroadcastLogMessage{
5757
ChallengeID: msg.ChallengeID,
5858
Challenger: challengerNodeIDAndAddress,

0 commit comments

Comments
 (0)