[PSL-1174] pasteld: update googletest library to the latest 1.14 - updated googletest library from v1.11 to v1.14 (08/02/2023) (#253)

[PSL-1177] pasteld: update zstd library to the latest v1.5.6
 - updated zstd library from v.1.5.5 to v1.5.6 (03/30/2024)

[PSL-1173] pasteld: existing ticket validation in the forked chain
pasteld v2.3.0-beta2
 - mainnet chain forked at height 657,925 and the same ticket was registered in both chains at different heights: 658,421 and 658,564
 - the node active chain was the forked one
 - main chain at one point became longer (more work) than the forked one, but it couldn't switch to that better chain
 because of ticket validation failure (action registration ticket could not be validated - because it was finding
 existing ticket registered in the forked chain, that ticket was written to the Ticket DB)
 - ticket processor functions to find/list/process/get tickets by primary/secondary/mv keys were changed to make
 them fork-aware. Optional parameter pindexPrev that points to the previous block being validated was passed to
 all the functions. If this parameter is passed and the function finds the ticket in DB - it checks if this ticket
 transaction is in the block which is direct ancestor of the pindexPrev block. If not - it will not return this ticket.
 This way when validating forked chain ticket processor won't see tickets registered in the active chain after the fork point.
 - corrected IsValid functions for all ticket types to work with new ticket processor functions including functions that work with
signatures, collections, collection items, dependent tickets, etc...
 - switch to the better chain can be automatic if the reorg length is not longer that 99 blocks, for longer reorgs you have
 to specify parameter in the command-line or pastel.conf: -rewindchain=_block_hash_.
 - fixed IsIntendedChainRewind to allow specify -rewindchain block as fork block or its direct ancestor (up to 1000 blocks)

Author: akobrin1

build-aux/vs2022/settings/googletest.props

@@ -9,7 +9,7 @@
   <ItemDefinitionGroup>
     <ClCompile>
       <AdditionalIncludeDirectories>%(AdditionalIncludeDirectories)</AdditionalIncludeDirectories>
-      <PreprocessorDefinitions>_CONSOLE;GOOGLETEST;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PreprocessorDefinitions>_CONSOLE;GOOGLETEST;GTEST_LINKED_AS_SHARED_LIBRARY;%(PreprocessorDefinitions)</PreprocessorDefinitions>
     </ClCompile>
     <Link>
       <Profile>true</Profile>

configure.ac

@@ -3,7 +3,7 @@ AC_PREREQ([2.60])
 define(_CLIENT_VERSION_MAJOR, 2)
 define(_CLIENT_VERSION_MINOR, 3)
 define(_CLIENT_VERSION_REVISION, 0)
-define(_CLIENT_VERSION_BUILD, 0)
+define(_CLIENT_VERSION_BUILD, 1)
 define(_ZC_BUILD_VAL,
     m4_if(m4_eval(_CLIENT_VERSION_BUILD < 25), 1, m4_incr(_CLIENT_VERSION_BUILD),
         m4_eval(_CLIENT_VERSION_BUILD < 50), 1, 

depends/packages/googletest.mk

@@ -1,9 +1,9 @@
 package=googletest
-$(package)_version=1.11.0
+$(package)_version=1.14.0
 $(package)_download_path=https://github.com/google/$(package)/archive/refs/tags
 $(package)_file_name=$(package)-$($(package)_version).tar.gz
-$(package)_download_file=release-$($(package)_version).tar.gz
-$(package)_sha256_hash=b4870bf121ff7795ba20d20bcdd8627b8e088f2d1dab299a031c1034eddc93d5
+$(package)_download_file=v$($(package)_version).tar.gz
+$(package)_sha256_hash=8ad598c73ad796e0d8280b082cebd82a630d73e73cd3c70057938a6501bba5d7
 
 define $(package)_set_vars
 $(package)_cxxflags+= -std=c++17

depends/packages/zstd.mk

@@ -1,8 +1,8 @@
 package=zstd
-$(package)_version=1.5.5
+$(package)_version=1.5.6
 $(package)_download_path=https://github.com/facebook/zstd/releases/download/v$($(package)_version)/
 $(package)_file_name=$(package)-$($(package)_version).tar.gz
-$(package)_sha256_hash=9c4396cc829cfae319a6e2615202e82aad41372073482fce286fac78646d3ee4
+$(package)_sha256_hash=8c29e06cf42aacc1eafc4077ae2ec6c6fcb96a626157e0593d5e82a34fd403c1
 
 define $(package)_preprocess_cmds
   mkdir -p bld
@@ -16,6 +16,7 @@ $(package)_cmake_opts+= -DCMAKE_CXX_STANDARD_REQUIRED=ON
 $(package)_cmake_opts+= -DCMAKE_POSITION_INDEPENDENT_CODE=ON
 $(package)_cmake_opts+= -DZSTD_BUILD_SHARED=OFF
 $(package)_cmake_opts+= -DZSTD_BUILD_PROGRAMS=OFF
+$(package)_cmake_opts+= -DZSTD_MULTITHREAD_SUPPORT=ON
 $(package)_cmake_opts+= -DSYSINSTALL_BINDINGS=ON
 $(package)_cmake_opts+= -DCMAKE_INSTALL_PREFIX=$($(package)_staging_prefix_dir)
 endef

src/accept_to_mempool.cpp

@@ -283,14 +283,16 @@ bool AreInputsStandard(const CTransaction& tx, const CCoinsViewCache& mapInputs,
  * \param state - validation state
  * \param chainparams - chain parameters
  * \param nHeight - height of the block being evaluated
+ * \param pindexPrev - pointer to the previous block index
  * \param isInitBlockDownload - functor to check IBD mode
- * \return 
+ * \return true if the transaction is valid, false otherwise
  */
 bool ContextualCheckTransaction(
     const CTransaction& tx,
     CValidationState &state,
     const CChainParams& chainparams,
     const int nHeight,
+    const CBlockIndex *pindexPrev,
     funcIsInitialBlockDownload_t isInitBlockDownload)
 {
     const auto& consensusParams = chainparams.GetConsensus();
@@ -512,7 +514,7 @@ bool ContextualCheckTransaction(
     }
 
     // Check Pastel Ticket transactions
-    const auto tv = CPastelTicketProcessor::ValidateIfTicketTransaction(state, nHeight, tx);
+    const auto tv = CPastelTicketProcessor::ValidateIfTicketTransaction(state, nHeight, tx, pindexPrev);
     if (tv.state == TICKET_VALIDATION_STATE::NOT_TICKET || tv.state == TICKET_VALIDATION_STATE::VALID)
         return true;
     if (tv.state == TICKET_VALIDATION_STATE::MISSING_INPUTS)
@@ -526,11 +528,20 @@ bool ContextualCheckTransaction(
                      REJECT_INVALID, "bad-tx-invalid-ticket", false, strRejectReasonDetails);
 }
 
+/**
+ * Contextual validation of the block and its transactions.
+ * 
+ * \param block - block to check
+ * \param state - validation state
+ * \param chainparams - chain parameters
+ * \param pindexPrev - pointer to the previous block index
+ * \return true if the block is valid, false otherwise
+ */
 bool ContextualCheckBlock(
     const CBlock& block,
     CValidationState& state,
     const CChainParams& chainparams,
-    CBlockIndex * const pindexPrev)
+    const CBlockIndex *pindexPrev)
 {
     const int nHeight = !pindexPrev ? 0 : pindexPrev->nHeight + 1;
     const auto& consensusParams = chainparams.GetConsensus();
@@ -540,7 +551,7 @@ bool ContextualCheckBlock(
     for (const auto& tx : block.vtx)
     {
         // Check transaction contextually against consensus rules at block height
-        if (!ContextualCheckTransaction(tx, state, chainparams, nHeight))
+        if (!ContextualCheckTransaction(tx, state, chainparams, nHeight, pindexPrev, fnIsInitialBlockDownload))
             return false; // Failure reason has been set in validation state object
 
         int nLockTimeFlags = 0;
@@ -839,7 +850,7 @@ bool AcceptToMemoryPool(
         return error("%s: CheckTransaction failed. %s", sFuncLog, state.GetRejectReason());
 
     // Check transaction contextually against the set of consensus rules which apply in the next block to be mined.
-    if (!ContextualCheckTransaction(tx, state, chainparams, nextBlockHeight))
+    if (!ContextualCheckTransaction(tx, state, chainparams, nextBlockHeight, nullptr, fnIsInitialBlockDownload))
     {
         if (state.IsRejectCode(REJECT_MISSING_INPUTS))
         {

src/accept_to_mempool.h

@@ -12,6 +12,7 @@
 #include <consensus/params.h>
 #include <primitives/transaction.h>
 #include <txmempool.h>
+#include <chain.h>
 
 /** Check whether we are doing an initial block download (synchronizing from disk or network) */
 extern funcIsInitialBlockDownload_t fnIsInitialBlockDownload;
@@ -24,7 +25,8 @@ bool ContextualCheckTransaction(
     CValidationState &state,
     const CChainParams& chainparams,
     const int nHeight,
-    funcIsInitialBlockDownload_t isInitBlockDownload = fnIsInitialBlockDownload);
+    const CBlockIndex *pindexPrev,
+    funcIsInitialBlockDownload_t isInitBlockDownload);
 
 /** Context-independent validity checks */
 bool CheckTransaction(const CTransaction& tx, CValidationState& state, libzcash::ProofVerifier& verifier);

src/chain.cpp

@@ -452,6 +452,24 @@ CBlockIndex* FindLastCommonAncestorBlockIndex(CBlockIndex* pa, CBlockIndex* pb)
     return pa;
 }
 
+const CBlockIndex* FindLastCommonAncestorBlockIndex(const CBlockIndex* pa, const CBlockIndex* pb)
+{
+    if (pa->nHeight > pb->nHeight)
+        pa = pa->GetAncestor(pb->nHeight);
+    else if (pb->nHeight > pa->nHeight)
+        pb = pb->GetAncestor(pa->nHeight);
+
+    while (pa != pb && pa && pb)
+    {
+        pa = pa->pprev;
+        pb = pb->pprev;
+    }
+
+    // Eventually all chain branches meet at the genesis block.
+    assert(pa == pb);
+    return pa;
+}
+
 int64_t CBlockIndex::GetMedianTimePast() const noexcept
 {
     int64_t pmedian[nMedianTimeSpan];

src/chain.h

@@ -453,3 +453,4 @@ class CChain {
 
 // Find the last common ancestor two blocks have.
 CBlockIndex* FindLastCommonAncestorBlockIndex(CBlockIndex* pa, CBlockIndex* pb);
+const CBlockIndex* FindLastCommonAncestorBlockIndex(const CBlockIndex* pa, const CBlockIndex* pb);

src/clientversion.h

@@ -17,7 +17,7 @@
 #define CLIENT_VERSION_MAJOR 2
 #define CLIENT_VERSION_MINOR 3
 #define CLIENT_VERSION_REVISION 0
-#define CLIENT_VERSION_BUILD 0
+#define CLIENT_VERSION_BUILD 1
 
 //! Set to true for release, false for prerelease or test build
 #define CLIENT_VERSION_IS_RELEASE true

src/coins.h

@@ -1,7 +1,7 @@
 #pragma once
 // Copyright (c) 2009-2010 Satoshi Nakamoto
 // Copyright (c) 2009-2014 The Bitcoin Core developers
-// Copyright (c) 2018-2023 The Pastel Core developers
+// Copyright (c) 2018-2024 The Pastel Core developers
 // Distributed under the MIT software license, see the accompanying
 // file COPYING or https://www.opensource.org/licenses/mit-license.php.
 #include <assert.h>
@@ -74,7 +74,7 @@ class CCoins
     bool fCoinBase;
 
     //! unspent transaction outputs; spent outputs are .IsNull(); spent outputs at the end of the array are dropped
-    std::vector<CTxOut> vout;
+    v_txouts vout;
 
     //! at which height this transaction was included in the active block chain
     int nHeight;
@@ -98,7 +98,7 @@ class CCoins
 
     void Clear() {
         fCoinBase = false;
-        std::vector<CTxOut>().swap(vout);
+        v_txouts().swap(vout);
         nHeight = 0;
         nVersion = 0;
     }
@@ -111,7 +111,7 @@ class CCoins
         while (vout.size() > 0 && vout.back().IsNull())
             vout.pop_back();
         if (vout.empty())
-            std::vector<CTxOut>().swap(vout);
+            v_txouts().swap(vout);
     }
 
     void ClearUnspendable() {