Merge pull request #265 from pastelnetwork/PSL-1249

1) [PSL-1249] pasteld: create index for Sender2Recipient mapping and API using it (`getaddressutxosextra`)
2) Fix for "simple" flag of `getaddressutxosextra`
3) Skip dust checks on transactions to burnaddress

Author: a-ok123

.gitignore

@@ -5,6 +5,7 @@ venv/
 venv27/
 
 compile_commands.json
+pastel-config.h.in
 
 *.tar.gz
 *.deb

build-aux/vs2022/libbitcoin_server/libbitcoin_server.vcxproj

@@ -198,6 +198,7 @@
     <ClCompile Include="..\..\..\src\timedata.cpp" />
     <ClCompile Include="..\..\..\src\torcontrol.cpp" />
     <ClCompile Include="..\..\..\src\txdb\txdb.cpp" />
+    <ClCompile Include="..\..\..\src\txdb\txidxprocessor.cpp" />
     <ClCompile Include="..\..\..\src\txmempool.cpp" />
     <ClCompile Include="..\..\..\src\validationinterface.cpp" />
     <ClCompile Include="..\..\vs\port\cyclicbarrier\cyclicbarrier.cpp" />
@@ -326,9 +327,12 @@
     <ClInclude Include="..\..\..\src\timedata.h" />
     <ClInclude Include="..\..\..\src\torcontrol.h" />
     <ClInclude Include="..\..\..\src\txdb\addressindex.h" />
+    <ClInclude Include="..\..\..\src\txdb\fundstransferindex.h" />
+    <ClInclude Include="..\..\..\src\txdb\index_defs.h" />
     <ClInclude Include="..\..\..\src\txdb\spentindex.h" />
     <ClInclude Include="..\..\..\src\txdb\timestampindex.h" />
     <ClInclude Include="..\..\..\src\txdb\txdb.h" />
+    <ClInclude Include="..\..\..\src\txdb\txidxprocessor.h" />
     <ClInclude Include="..\..\..\src\txmempool.h" />
     <ClInclude Include="..\..\..\src\txmempool_entry.h" />
     <ClInclude Include="..\..\..\src\ui_interface.h" />

build-aux/vs2022/libbitcoin_server/libbitcoin_server.vcxproj.filters

@@ -373,6 +373,9 @@
     <ClCompile Include="..\..\..\src\txdb\txdb.cpp">
       <Filter>Source Files\txdb</Filter>
     </ClCompile>
+    <ClCompile Include="..\..\..\src\txdb\txidxprocessor.cpp">
+      <Filter>Source Files\txdb</Filter>
+    </ClCompile>
   </ItemGroup>
   <ItemGroup>
     <ClInclude Include="..\..\..\src\addrman.h">
@@ -771,5 +774,14 @@
     <ClInclude Include="..\..\..\src\txdb\timestampindex.h">
       <Filter>Source Files\txdb</Filter>
     </ClInclude>
+    <ClInclude Include="..\..\..\src\txdb\txidxprocessor.h">
+      <Filter>Source Files\txdb</Filter>
+    </ClInclude>
+    <ClInclude Include="..\..\..\src\txdb\index_defs.h">
+      <Filter>Source Files\txdb</Filter>
+    </ClInclude>
+    <ClInclude Include="..\..\..\src\txdb\fundstransferindex.h">
+      <Filter>Source Files\txdb</Filter>
+    </ClInclude>
   </ItemGroup>
 </Project>

configure.ac

@@ -3,7 +3,7 @@ AC_PREREQ([2.60])
 define(_CLIENT_VERSION_MAJOR, 2)
 define(_CLIENT_VERSION_MINOR, 2)
 define(_CLIENT_VERSION_REVISION, 7)
-define(_CLIENT_VERSION_BUILD, 1)
+define(_CLIENT_VERSION_BUILD, 2)
 define(_ZC_BUILD_VAL,
     m4_if(m4_eval(_CLIENT_VERSION_BUILD < 25), 1, m4_incr(_CLIENT_VERSION_BUILD),
         m4_eval(_CLIENT_VERSION_BUILD < 50), 1, 

src/Makefile.am

@@ -336,7 +336,10 @@ PASTEL_CORE_H = \
   core_io.h \
   core_memusage.h \
   txdb/addressindex.h \
+  txdb/fundstransferindex.h \
+  txdb/index_defs.h \
   txdb/spentindex.h \
+  txdb/txidxprocessor.h \
   txdb/timestampindex.h \
   txdb/txdb.h \
   deprecation.h \
@@ -375,7 +378,6 @@ PASTEL_CORE_H = \
   noui.h \
   orphan-tx.h\
   policy/fees.h \
-  port_config.h \
   primitives/block.h \
   primitives/transaction.h \
   protocol.h \
@@ -489,6 +491,7 @@ libbitcoin_server_a_SOURCES = \
   timedata.cpp \
   torcontrol.cpp \
   txdb/txdb.cpp \
+  txdb/txidxprocessor.cpp \
   txmempool.cpp \
   validationinterface.cpp \
   $(MNODE_CPP) \

src/accept_to_mempool.cpp

@@ -79,6 +79,7 @@ bool IsStandardTx(const CTransaction& tx, string& reason, const CChainParams& ch
         }
     }
 
+    const auto& destBurnAddress = chainparams.getPastelBurnAddressHash();
     for (const auto& txin : tx.vin)
     {
         // Biggest 'standard' txin is a 15-of-15 P2SH multisig with compressed
@@ -115,7 +116,16 @@ bool IsStandardTx(const CTransaction& tx, string& reason, const CChainParams& ch
         else if ((whichType == TX_MULTISIG) && (!fIsBareMultisigStd)) {
             reason = "bare-multisig";
             return false;
-        } else if (txout.IsDust(gl_ChainOptions.minRelayTxFee)) {
+        }
+
+        // skip dust check if transaction is to the burn transaction
+        bool bSkipDustCheck = false;
+        if ((whichType == TX_PUBKEYHASH) || (whichType == TX_SCRIPTHASH))
+        {
+            const uint160 addressHash = txout.scriptPubKey.AddressHash();
+            bSkipDustCheck = (addressHash == destBurnAddress);
+        }
+        if (!bSkipDustCheck && txout.IsDust(gl_ChainOptions.minRelayTxFee)) {
             reason = "dust";
             return false;
         }

src/chain.h

@@ -383,6 +383,13 @@ class CDiskBlockIndex : public CBlockIndex
     }
 };
 
+typedef enum class _BlockDisconnectResult
+{
+    OK,      // All good.
+    UNCLEAN, // Rolled back, but UTXO set was inconsistent with block.
+    FAILED   // Something else went wrong.
+} BlockDisconnectResult;
+
 using block_index_cvector_t = std::vector<const CBlockIndex*>;
 using block_index_vector_t = std::vector<CBlockIndex*>;
 

src/chain_options.cpp

@@ -10,6 +10,7 @@ atomic_bool fInsightExplorer = false;
 atomic_bool fAddressIndex = false;
 atomic_bool fSpentIndex = true;
 atomic_bool fTimestampIndex = false;
+atomic_bool fFundsTransferIndex = false;
 
 CChainOptions gl_ChainOptions;
 

src/chain_options.h

@@ -43,8 +43,15 @@ extern std::atomic_bool fSpentIndex;
 
 // Maintain a full timestamp index, used to query for blocks within a time range
 extern std::atomic_bool fTimestampIndex;
+
+// Maintain a full funds transfer index
+extern std::atomic_bool fFundsTransferIndex;
 // END insightexplorer
 
+// range of block heights from start to end
+using height_range_t = std::pair<uint32_t, uint32_t>;
+using height_range_opt_t = std::optional<height_range_t>;
+
 class CChainOptions
 {
 public:

src/chainparams.cpp

@@ -42,7 +42,6 @@ Genesis block for RegTest found
 #include <utils/utilstrencodings.h>
 #include <utils/arith_uint256.h>
 #include <key_io.h>
-#include <main.h>
 #include <net.h>
 #include <netmsg/netconsts.h>
 #include <crypto/equihash.h>
@@ -350,6 +349,20 @@ static CBlock CreateRegtestGenesisBlock()
     return block;
 }
 
+bool CChainParams::DecodePastelBurnAddress()
+{
+    KeyIO keyIO(*this);
+    ScriptType scriptType;
+    const CTxDestination dest = keyIO.DecodeDestination(m_sPastelBurnAddress);
+    return GetTxDestinationHash(dest, m_pastelBurnAddressHash, scriptType);
+}
+
+constexpr size_t equihash_parameters_acceptable(const int N, const int K) noexcept
+{
+    return ((CBlockHeader::HEADER_SIZE + equihash_solution_size(N, K)) * MAX_HEADERS_RESULTS < \
+        MAX_PROTOCOL_MESSAGE_LENGTH - 1000);
+}
+
 /**
  * Main network
  */
@@ -703,6 +716,8 @@ class CRegTestParams : public CChainParams
     {
         strNetworkID = "regtest";
         strCurrencyUnits = "REG";
+        // cUUjBtKN8BRriP1STe1KkEhJUpdARf8tj9T5gKuJPuY5mjtd2jP5
+        m_sPastelBurnAddress = "tPotfXKvYRAmJepR8rm849pRP2nmbyt2bGu";
         bip44CoinType = 1;
         consensus.nSubsidyHalvingInterval = 150;
         consensus.nMajorityEnforceBlockUpgrade = 750;
@@ -740,7 +755,6 @@ class CRegTestParams : public CChainParams
         pchMessageStart[1] = 0xd8;
         pchMessageStart[2] = 0xfa;
         pchMessageStart[3] = 0x9e;
-        //vAlertPubKey = ParseHex("04b985ccafe6d17ac5d84cb8c06a69cefad733ee96b4b93bcf5ef0897778c227ee7e74e7680cc219236e4c6a609dbcdeb5bf65cea9c2576c2a0fbef590657c8e7a");
         vAlertPubKey = ParseHex("04d8a5b9bf6ef2396204fc879d370c85b3ccd665b6a06b9600165ceed4233ca38d27010abd3b6e607b46663ce21e8473df0e30f1bf7e425a3bdd58d2a6d1bb2049");
         nDefaultPort = REGTEST_DEFAULT_PORT;
         m_nPruneAfterHeight = 1000;
@@ -836,6 +850,8 @@ unique_ptr<const CChainParams> CreateChainParams(const ChainNetwork network)
             ChainParams = make_unique<CMainParams>();
             break;
     }
+    if (ChainParams)
+        ChainParams->DecodePastelBurnAddress();
     return std::move(ChainParams);
 }