Commit 7a6db32
authored
fix: use has_side_effect=True in FFI calls (#44)
The [JAX
docs](https://docs.jax.dev/en/latest/_autosummary/jax.pure_callback.html)
state this:
> In the context of JAX transformations, Python exceptions should be
considered side-effects: this means that intentionally raising an error
within a pure_callback breaks the API contract, and the behavior of the
resulting program is undefined.
Our callbacks can raise, so switching `has_side_effect` to `True` seems
like the safer option. I don't know if this has any runtime impact right
now (didn't notice any while testing).1 parent bc5040d commit 7a6db32
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
229 | 229 | | |
230 | 230 | | |
231 | 231 | | |
232 | | - | |
| 232 | + | |
233 | 233 | | |
234 | 234 | | |
235 | 235 | | |
| |||
0 commit comments