Skip to content

Commit c8b4f10

Browse files
authored
Ruby - Minor QoL improvements (#38)
* Remove the ignore list in code gen * Remove unused models * Bump version * Bump ruby version and fix empty parameters * Bump version * Revert
1 parent 860631f commit c8b4f10

File tree

7 files changed

+32
-22
lines changed

7 files changed

+32
-22
lines changed

.ruby-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
3.0.0
1+
3.0.2

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [1.10.2] - 2021-09-01
9+
10+
### Fixed
11+
12+
- Allows methods to be called with no parameters
13+
814
## [1.10.0] - 2021-08-27
915

1016
### Added

Gemfile.lock

Lines changed: 19 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ GEM
1717
byebug (11.1.3)
1818
coderay (1.1.3)
1919
concurrent-ruby (1.1.9)
20-
diff-lcs (1.4.3)
20+
diff-lcs (1.4.4)
2121
ethon (0.14.0)
2222
ffi (>= 1.15.0)
2323
factory_bot (6.2.0)
@@ -31,28 +31,28 @@ GEM
3131
parallel (1.20.1)
3232
parser (3.0.2.0)
3333
ast (~> 2.4.1)
34-
pry (0.13.1)
34+
pry (0.14.1)
3535
coderay (~> 1.1)
3636
method_source (~> 1.0)
37-
pry-byebug (3.9.0)
37+
pry-byebug (3.8.0)
3838
byebug (~> 11.0)
39-
pry (~> 0.13.0)
39+
pry (~> 0.10)
4040
psych (4.0.1)
4141
rainbow (3.0.0)
42-
rake (13.0.1)
43-
rspec (3.9.0)
44-
rspec-core (~> 3.9.0)
45-
rspec-expectations (~> 3.9.0)
46-
rspec-mocks (~> 3.9.0)
47-
rspec-core (3.9.2)
48-
rspec-support (~> 3.9.3)
49-
rspec-expectations (3.9.2)
42+
rake (13.0.6)
43+
rspec (3.10.0)
44+
rspec-core (~> 3.10.0)
45+
rspec-expectations (~> 3.10.0)
46+
rspec-mocks (~> 3.10.0)
47+
rspec-core (3.10.1)
48+
rspec-support (~> 3.10.0)
49+
rspec-expectations (3.10.1)
5050
diff-lcs (>= 1.2.0, < 2.0)
51-
rspec-support (~> 3.9.0)
52-
rspec-mocks (3.9.1)
51+
rspec-support (~> 3.10.0)
52+
rspec-mocks (3.10.2)
5353
diff-lcs (>= 1.2.0, < 2.0)
54-
rspec-support (~> 3.9.0)
55-
rspec-support (3.9.3)
54+
rspec-support (~> 3.10.0)
55+
rspec-support (3.10.2)
5656
rubocop (0.66.0)
5757
jaro_winkler (~> 1.5.1)
5858
parallel (~> 1.10)
@@ -70,15 +70,16 @@ GEM
7070
zeitwerk (2.4.2)
7171

7272
PLATFORMS
73-
ruby
73+
x86_64-darwin-20
7474

7575
DEPENDENCIES
7676
factory_bot (~> 6.2)
7777
patch_ruby!
78+
pry
7879
pry-byebug
7980
rake (~> 13.0.1)
8081
rspec (~> 3.6, >= 3.6.0)
8182
rubocop (~> 0.66.0)
8283

8384
BUNDLED WITH
84-
2.2.14
85+
2.2.22

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
SHELL = /bin/bash
22

33
build:
4-
rubocop -a && \
5-
bundle install
4+
bundle install && \
5+
rubocop -a
66

77
test:
88
bundle exec rspec

patch_ruby.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ Gem::Specification.new do |s|
3838

3939
# Start custom
4040
s.add_development_dependency 'factory_bot', '~> 6.2'
41+
s.add_development_dependency 'pry'
4142
# End custom
4243

4344
end

spec/integration/estimates_spec.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,8 +74,9 @@
7474
expect(create_estimate_response.data.mass_g).to eq 12_431
7575
end
7676

77+
7778
it 'supports creating bitcoin estimates with partial information' do
78-
bitcoin_estimate = Patch::Estimate.create_bitcoin_estimate({ create_order: false })
79+
bitcoin_estimate = Patch::Estimate.create_bitcoin_estimate({})
7980

8081
expect(bitcoin_estimate.data.type).to eq 'bitcoin'
8182
expect(bitcoin_estimate.data.mass_g).to be >= 2_000

spec/spec_helper.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
# Start custom
1616
require 'constants'
1717
require 'factory_bot'
18+
require 'pry'
1819
# End custom
1920

2021
# Require shared spec examples

0 commit comments

Comments
 (0)