Fix notification payload params absence (reidmorrison#127)

* Fix notification payload params absence

* Remove byebug dependency

* Added missed files

Author: dsalahutdinov

lib/rails_semantic_logger/action_controller/log_subscriber.rb

@@ -18,7 +18,7 @@ def process_action(event)
           # According to PR https://github.com/rocketjob/rails_semantic_logger/pull/37/files
           # payload[:params] is not always a Hash.
           payload[:params] = payload[:params].to_unsafe_h unless payload[:params].is_a?(Hash)
-          payload[:params].except!(*INTERNAL_PARAMS)
+          payload[:params] = payload[:params].except(*INTERNAL_PARAMS)
           payload.delete(:params) if payload[:params].empty?
 
           format           = payload[:format]

test/controllers/dashboard_controller_test.rb

@@ -23,7 +23,9 @@ class DashboardControllerTest < ActionDispatch::IntegrationTest
   end
 
   test "get show successfully logs message" do
-    get dashboard_url
+    PayloadCollector.wrap do
+      get dashboard_url
+    end
 
     SemanticLogger.flush
     actual = @mock_logger.message
@@ -39,5 +41,8 @@ class DashboardControllerTest < ActionDispatch::IntegrationTest
     assert_equal "/dashboard", payload[:path], payload
     assert_equal 200, payload[:status], payload
     assert_equal "OK", payload[:status_message], payload
+
+    payload = PayloadCollector.last
+    assert_equal payload[:params], {"controller"=>"dashboard", "action"=>"show"}
   end
 end

test/dummy/config/initializers/payload_collector.rb

@@ -0,0 +1,4 @@
+ActiveSupport::Notifications.subscribe "process_action.action_controller" do |*args|
+  event = ActiveSupport::Notifications::Event.new(*args)
+  PayloadCollector.append(event.payload)
+end

test/payload_collector.rb

@@ -0,0 +1,28 @@
+class PayloadCollector
+  class << self
+    def wrap
+      @store = true
+      yield
+    ensure
+      @store = false
+    end
+
+    def append(payload)
+      data.append(payload) if @store
+    end
+
+    def last
+      data.last
+    end
+
+    def flush
+      @data = []
+    end
+
+    private
+
+    def data
+      @data ||= []
+    end
+  end
+end

test/test_helper.rb

@@ -7,6 +7,7 @@
 
 require "rails/test_help"
 require_relative "mock_logger"
+require_relative "payload_collector"
 
 # Include the complete backtrace?
 Minitest.backtrace_filter = Minitest::BacktraceFilter.new if ENV["BACKTRACE"].present?