Skip to content

Commit 58c7cce

Browse files
committed
Only replace default Sidekiq error handler when present
for Sidekiq >= v6.5, < V7
1 parent 87b8641 commit 58c7cce

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ The queue latency is the time between when the job was enqueued and when it was
8787
filter environment = "production"
8888
filter level = "info"
8989
filter metric = "sidekiq.queue.latency"
90-
timechart latency:avg(metric_amount), group_by(name)
90+
timechart latency:avg(metric_amount/1000), group_by(string(named_tags.queue))
9191
~~~
9292

9393
* http://github.com/reidmorrison/rails_semantic_logger

lib/rails_semantic_logger/extensions/sidekiq/sidekiq.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,9 @@ class Config
129129
end
130130
end
131131
end
132-
else
132+
elsif Sidekiq.error_handlers.delete(Sidekiq::DEFAULT_ERROR_HANDLER)
133133
# Sidekiq >= 6.5
134-
Sidekiq.error_handlers.delete(Sidekiq::DEFAULT_ERROR_HANDLER)
134+
# Replace default error handler if present
135135
Sidekiq.error_handlers << ->(ex, ctx) do
136136
unless ctx.empty?
137137
job_hash = ctx[:job] || {}

0 commit comments

Comments
 (0)