Skip to content

Commit cca0312

Browse files
committed
Update Github Workflows
1 parent d5d976f commit cca0312

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ jobs:
3131

3232
- rails: "7.1"
3333
ruby: "3.1"
34+
- rails: "7.1b"
35+
ruby: "3.1"
3436
- rails: "7.1.1"
3537
ruby: "3.2"
3638
- rails: "7.1"

rails_semantic_logger.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
1616
s.required_ruby_version = ">= 2.5"
1717
s.add_dependency "rack"
1818
s.add_dependency "railties", ">= 5.1"
19-
s.add_dependency "semantic_logger", "~> 4.13"
19+
s.add_dependency "semantic_logger", "~> 4.16"
2020
s.metadata = {
2121
"bug_tracker_uri" => "https://github.com/reidmorrison/rails_semantic_logger/issues",
2222
"documentation_uri" => "https://logger.rocketjob.io",

test/sidekiq_test.rb

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ class SidekiqTest < Minitest::Test
9191
name: "BadJob",
9292
message: "Start #perform",
9393
metric: "sidekiq.queue.latency",
94-
named_tags: {jid: nil, queue: "default"}
94+
named_tags: {jid: nil, queue: "default"},
95+
exception: :nil
9596
)
9697
assert messages[0].metric_amount.is_a?(Float)
9798

@@ -101,8 +102,8 @@ class SidekiqTest < Minitest::Test
101102
name: "BadJob",
102103
message: "Completed #perform",
103104
metric: "sidekiq.job.perform",
104-
named_tags: {jid: nil, queue: "default"}
105-
# exception: { name: "ArgumentError", message: "This is a bad job" }
105+
named_tags: {jid: nil, queue: "default"},
106+
exception: ArgumentError
106107
)
107108
assert messages[1].duration.is_a?(Float)
108109

@@ -111,8 +112,8 @@ class SidekiqTest < Minitest::Test
111112
level: :warn,
112113
name: "BadJob",
113114
message: "Job raised exception",
114-
payload_includes: {context: "Job raised exception"}
115-
# exception: { name: "ArgumentError", message: "This is a bad job" }
115+
payload_includes: {context: "Job raised exception"},
116+
exception: :nil
116117
)
117118
assert_equal messages[2].payload[:job]["class"], "BadJob"
118119
assert_equal messages[2].payload[:job]["args"], []

0 commit comments

Comments
 (0)