Skip to content

Commit ce29f55

Browse files
committed
Duplicate fixes to Sidekiq v4 patches
1 parent abee430 commit ce29f55

File tree

1 file changed

+17
-18
lines changed
  • lib/rails_semantic_logger/extensions/sidekiq

1 file changed

+17
-18
lines changed

lib/rails_semantic_logger/extensions/sidekiq/sidekiq.rb

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -147,9 +147,9 @@ class Config
147147
when 4
148148
module Worker
149149
def self.included(base)
150-
raise ArgumentError, "You cannot include Sidekiq::Worker in an ActiveJob: #{base.name}" if base.ancestors.any? do |c|
151-
c.name == "ActiveJob::Base"
152-
end
150+
if base.ancestors.any? { |c| c.name == "ActiveJob::Base" }
151+
raise ArgumentError, "You cannot include Sidekiq::Worker in an ActiveJob: #{base.name}"
152+
end
153153

154154
base.extend(ClassMethods)
155155
base.include(SemanticLogger::Loggable)
@@ -161,9 +161,9 @@ def self.included(base)
161161
when 5
162162
module Worker
163163
def self.included(base)
164-
raise ArgumentError, "You cannot include Sidekiq::Worker in an ActiveJob: #{base.name}" if base.ancestors.any? do |c|
165-
c.name == "ActiveJob::Base"
166-
end
164+
if base.ancestors.any? { |c| c.name == "ActiveJob::Base" }
165+
raise ArgumentError, "You cannot include Sidekiq::Worker in an ActiveJob: #{base.name}"
166+
end
167167

168168
base.extend(ClassMethods)
169169
base.include(SemanticLogger::Loggable)
@@ -175,9 +175,9 @@ def self.included(base)
175175
when 6
176176
module Worker
177177
def self.included(base)
178-
raise ArgumentError, "Sidekiq::Worker cannot be included in an ActiveJob: #{base.name}" if base.ancestors.any? do |c|
179-
c.name == "ActiveJob::Base"
180-
end
178+
if base.ancestors.any? { |c| c.name == "ActiveJob::Base" }
179+
raise ArgumentError, "Sidekiq::Worker cannot be included in an ActiveJob: #{base.name}"
180+
end
181181

182182
base.include(Options)
183183
base.extend(ClassMethods)
@@ -187,9 +187,9 @@ def self.included(base)
187187
else
188188
module Job
189189
def self.included(base)
190-
raise ArgumentError, "Sidekiq::Job cannot be included in an ActiveJob: #{base.name}" if base.ancestors.any? do |c|
191-
c.name == "ActiveJob::Base"
192-
end
190+
if base.ancestors.any? { |c| c.name == "ActiveJob::Base" }
191+
raise ArgumentError, "Sidekiq::Job cannot be included in an ActiveJob: #{base.name}"
192+
end
193193

194194
base.include(Options)
195195
base.extend(ClassMethods)
@@ -213,8 +213,8 @@ def log_context(job_hash)
213213
module Middleware
214214
module Server
215215
class Logging
216-
def call(worker, item, queue, &block)
217-
SemanticLogger.named_tags(queue: queue) do
216+
def call(worker, item, queue)
217+
SemanticLogger.tagged(queue: queue) do
218218
worker.logger.info(
219219
"Start #perform",
220220
metric: "sidekiq.queue.latency",
@@ -224,16 +224,15 @@ def call(worker, item, queue, &block)
224224
"Completed #perform",
225225
on_exception_level: :error,
226226
log_exception: :full,
227-
metric: "sidekiq.job.perform",
228-
&block
229-
)
227+
metric: "sidekiq.job.perform"
228+
) { yield }
230229
end
231230
end
232231

233232
def job_latency_ms(job)
234233
return unless job && job["enqueued_at"]
235234

236-
(Time.now.to_f - job["enqueued_at"]) * 1000
235+
(Time.now.to_f - job["enqueued_at"].to_f) * 1000
237236
end
238237
end
239238
end

0 commit comments

Comments
 (0)